1. Patchew
  2. QEMU
  3. View series

[PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space

Ani Sinha posted 1 patch 7 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230912120650.371781-1-anisinha@redhat.com
target/i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
Posted by Ani Sinha 7 months, 2 weeks ago 
PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
guest processor and set phys_bits to 36 if PAE feature is set. This is in
addition to checking the presence of PSE36 CPUID feature for setting 36 bit
phys_bits.

Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
 target/i386/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Note: Not sure what tests I should be running in order to make sure I am
not breaking any guest OSes. Usual qtests pass.

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 24ee67b42d..f3a5c99117 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
             return;
         }
 
-        if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
+        if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
             cpu->phys_bits = 36;
         } else {
             cpu->phys_bits = 32;
-- 
2.39.1
Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
Posted by Paolo Bonzini 6 months, 1 week ago 
On 9/12/23 14:06, Ani Sinha wrote:
> PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
> guest processor and set phys_bits to 36 if PAE feature is set. This is in
> addition to checking the presence of PSE36 CPUID feature for setting 36 bit
> phys_bits.
> 
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
>   target/i386/cpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Note: Not sure what tests I should be running in order to make sure I am
> not breaking any guest OSes. Usual qtests pass.

Queued, thanks.

Paolo

> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 24ee67b42d..f3a5c99117 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
>               return;
>           }
>   
> -        if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
> +        if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
>               cpu->phys_bits = 36;
>           } else {
>               cpu->phys_bits = 32;
Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
Posted by Michael S. Tsirkin 6 months, 1 week ago 
On Tue, Sep 12, 2023 at 05:36:50PM +0530, Ani Sinha wrote:
> PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
> guest processor and set phys_bits to 36 if PAE feature is set. This is in
> addition to checking the presence of PSE36 CPUID feature for setting 36 bit
> phys_bits.
> 
> Signed-off-by: Ani Sinha <anisinha@redhat.com>

Acked-by: Michael S. Tsirkin <mst@redhat.com>

who's applying this?

> ---
>  target/i386/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Note: Not sure what tests I should be running in order to make sure I am
> not breaking any guest OSes. Usual qtests pass.
> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 24ee67b42d..f3a5c99117 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
>              return;
>          }
>  
> -        if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
> +        if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
>              cpu->phys_bits = 36;
>          } else {
>              cpu->phys_bits = 32;
> -- 
> 2.39.1
Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
Posted by Ani Sinha 6 months, 1 week ago 
On Wed, 18 Oct, 2023, 5:35 pm Michael S. Tsirkin, <mst@redhat.com> wrote:

> On Tue, Sep 12, 2023 at 05:36:50PM +0530, Ani Sinha wrote:
> > PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
> > guest processor and set phys_bits to 36 if PAE feature is set. This is in
> > addition to checking the presence of PSE36 CPUID feature for setting 36
> bit
> > phys_bits.
> >
> > Signed-off-by: Ani Sinha <anisinha@redhat.com>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> who's applying this?
>

I thought it would be you? What did I miss?


> > ---
> >  target/i386/cpu.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Note: Not sure what tests I should be running in order to make sure I am
> > not breaking any guest OSes. Usual qtests pass.
> >
> > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> > index 24ee67b42d..f3a5c99117 100644
> > --- a/target/i386/cpu.c
> > +++ b/target/i386/cpu.c
> > @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev,
> Error **errp)
> >              return;
> >          }
> >
> > -        if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
> > +        if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
> >              cpu->phys_bits = 36;
> >          } else {
> >              cpu->phys_bits = 32;
> > --
> > 2.39.1
>
>
Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
Posted by Michael S. Tsirkin 6 months, 1 week ago 
On Wed, Oct 18, 2023 at 11:08:11PM +0530, Ani Sinha wrote:
> 
> 
> On Wed, 18 Oct, 2023, 5:35 pm Michael S. Tsirkin, <mst@redhat.com> wrote:
> 
>     On Tue, Sep 12, 2023 at 05:36:50PM +0530, Ani Sinha wrote:
>     > PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
>     > guest processor and set phys_bits to 36 if PAE feature is set. This is in
>     > addition to checking the presence of PSE36 CPUID feature for setting 36
>     bit
>     > phys_bits.
>     >
>     > Signed-off-by: Ani Sinha <anisinha@redhat.com>
> 
>     Acked-by: Michael S. Tsirkin <mst@redhat.com>
> 
>     who's applying this?
> 
> 
> I thought it would be you? What did I miss?

I just don't play a lot with CPUID flags and might easily miss things.
Used to be Eduardo .. maybe CC him.

> 
> 
>     > ---
>     >  target/i386/cpu.c | 2 +-
>     >  1 file changed, 1 insertion(+), 1 deletion(-)
>     >
>     > Note: Not sure what tests I should be running in order to make sure I am
>     > not breaking any guest OSes. Usual qtests pass.
>     >
>     > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>     > index 24ee67b42d..f3a5c99117 100644
>     > --- a/target/i386/cpu.c
>     > +++ b/target/i386/cpu.c
>     > @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev,
>     Error **errp)
>     >              return;
>     >          }
>     > 
>     > -        if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
>     > +        if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
>     >              cpu->phys_bits = 36;
>     >          } else {
>     >              cpu->phys_bits = 32;
>     > --
>     > 2.39.1
> 
>
Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
Posted by Ani Sinha 6 months, 1 week ago 
On Wed, 18 Oct, 2023, 11:14 pm Michael S. Tsirkin, <mst@redhat.com> wrote:

> On Wed, Oct 18, 2023 at 11:08:11PM +0530, Ani Sinha wrote:
> >
> >
> > On Wed, 18 Oct, 2023, 5:35 pm Michael S. Tsirkin, <mst@redhat.com>
> wrote:
> >
> >     On Tue, Sep 12, 2023 at 05:36:50PM +0530, Ani Sinha wrote:
> >     > PAE mode in x86 supports 36 bit address space. Check the PAE CPUID
> on the
> >     > guest processor and set phys_bits to 36 if PAE feature is set.
> This is in
> >     > addition to checking the presence of PSE36 CPUID feature for
> setting 36
> >     bit
> >     > phys_bits.
> >     >
> >     > Signed-off-by: Ani Sinha <anisinha@redhat.com>
> >
> >     Acked-by: Michael S. Tsirkin <mst@redhat.com>
> >
> >     who's applying this?
> >
> >
> > I thought it would be you? What did I miss?
>
> I just don't play a lot with CPUID flags and might easily miss things.
> Used to be Eduardo .. maybe CC him.
>

Eduardo can you pick this up?


> >
> >
> >     > ---
> >     >  target/i386/cpu.c | 2 +-
> >     >  1 file changed, 1 insertion(+), 1 deletion(-)
> >     >
> >     > Note: Not sure what tests I should be running in order to make
> sure I am
> >     > not breaking any guest OSes. Usual qtests pass.
> >     >
> >     > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> >     > index 24ee67b42d..f3a5c99117 100644
> >     > --- a/target/i386/cpu.c
> >     > +++ b/target/i386/cpu.c
> >     > @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState
> *dev,
> >     Error **errp)
> >     >              return;
> >     >          }
> >     >
> >     > -        if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
> >     > +        if (env->features[FEAT_1_EDX] & (CPUID_PSE36 |
> CPUID_PAE)) {
> >     >              cpu->phys_bits = 36;
> >     >          } else {
> >     >              cpu->phys_bits = 32;
> >     > --
> >     > 2.39.1
> >
> >
>
>
Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
Posted by Ani Sinha 6 months, 1 week ago 
On Thu, 19 Oct, 2023, 7:36 am Ani Sinha, <anisinha@redhat.com> wrote:

>
>
> On Wed, 18 Oct, 2023, 11:14 pm Michael S. Tsirkin, <mst@redhat.com> wrote:
>
>> On Wed, Oct 18, 2023 at 11:08:11PM +0530, Ani Sinha wrote:
>> >
>> >
>> > On Wed, 18 Oct, 2023, 5:35 pm Michael S. Tsirkin, <mst@redhat.com>
>> wrote:
>> >
>> >     On Tue, Sep 12, 2023 at 05:36:50PM +0530, Ani Sinha wrote:
>> >     > PAE mode in x86 supports 36 bit address space. Check the PAE
>> CPUID on the
>> >     > guest processor and set phys_bits to 36 if PAE feature is set.
>> This is in
>> >     > addition to checking the presence of PSE36 CPUID feature for
>> setting 36
>> >     bit
>> >     > phys_bits.
>> >     >
>> >     > Signed-off-by: Ani Sinha <anisinha@redhat.com>
>> >
>> >     Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> >
>> >     who's applying this?
>> >
>> >
>> > I thought it would be you? What did I miss?
>>
>> I just don't play a lot with CPUID flags and might easily miss things.
>> Used to be Eduardo .. maybe CC him.
>>
>
> Eduardo can you pick this up?
>

If Eduardo doesn't respond I'll send a PR for this.


>
>> >
>> >
>> >     > ---
>> >     >  target/i386/cpu.c | 2 +-
>> >     >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >     >
>> >     > Note: Not sure what tests I should be running in order to make
>> sure I am
>> >     > not breaking any guest OSes. Usual qtests pass.
>> >     >
>> >     > diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> >     > index 24ee67b42d..f3a5c99117 100644
>> >     > --- a/target/i386/cpu.c
>> >     > +++ b/target/i386/cpu.c
>> >     > @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState
>> *dev,
>> >     Error **errp)
>> >     >              return;
>> >     >          }
>> >     >
>> >     > -        if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
>> >     > +        if (env->features[FEAT_1_EDX] & (CPUID_PSE36 |
>> CPUID_PAE)) {
>> >     >              cpu->phys_bits = 36;
>> >     >          } else {
>> >     >              cpu->phys_bits = 32;
>> >     > --
>> >     > 2.39.1
>> >
>> >
>>
>>
Re: [PATCH] cpu/cpuid: check CPUID_PAE to determine 36 bit processor address space
Posted by David Hildenbrand 7 months, 2 weeks ago 
On 12.09.23 14:06, Ani Sinha wrote:
> PAE mode in x86 supports 36 bit address space. Check the PAE CPUID on the
> guest processor and set phys_bits to 36 if PAE feature is set. This is in
> addition to checking the presence of PSE36 CPUID feature for setting 36 bit
> phys_bits.
> 
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
>   target/i386/cpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Note: Not sure what tests I should be running in order to make sure I am
> not breaking any guest OSes. Usual qtests pass.
> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 24ee67b42d..f3a5c99117 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -7375,7 +7375,7 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp)
>               return;
>           }
>   
> -        if (env->features[FEAT_1_EDX] & CPUID_PSE36) {
> +        if (env->features[FEAT_1_EDX] & (CPUID_PSE36 | CPUID_PAE)) {
>               cpu->phys_bits = 36;
>           } else {
>               cpu->phys_bits = 32;

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.