[v2] riscv: fix --enable-debug in riscv-to-apply.next

[PATCH v2 0/2] riscv: fix --enable-debug in riscv-to-apply.next

Posted by Daniel Henrique Barboza 8 months ago

Hi,

This is the second version of the --enable-debug build fix for the
riscv-to-apply.next branch:

https://github.com/alistair23/qemu/tree/riscv-to-apply.next

This implements suggestions from Richard Henderson made in v1. Most
notable difference is that riscv_kvm_aplic_request() was moved to
kvm.c and it's now being declared in kvm_riscv.h.

Changes from v1:
- changed patch order
- patch 1 (former 2):
  - use kvm_enabled() to crop the whole block
- patch 2 (former 1):
  - move riscv_kvm_aplic_request() to kvm_riscv.h
  - use kvm_enabled() to crop the whole block
- v1 link: https://lore.kernel.org/qemu-riscv/20230829122144.464489-1-dbarboza@ventanamicro.com/


Daniel Henrique Barboza (2):
  hw/riscv/virt.c: fix non-KVM --enable-debug build
  hw/intc/riscv_aplic.c fix non-KVM --enable-debug build

 hw/intc/riscv_aplic.c    | 8 ++------
 hw/riscv/virt.c          | 6 +++---
 target/riscv/kvm.c       | 5 +++++
 target/riscv/kvm_riscv.h | 1 +
 4 files changed, 11 insertions(+), 9 deletions(-)

-- 
2.41.0

Re: [PATCH v2 0/2] riscv: fix --enable-debug in riscv-to-apply.next

Posted by Alistair Francis 8 months ago

On Wed, Aug 30, 2023 at 11:36 PM Daniel Henrique Barboza
<dbarboza@ventanamicro.com> wrote:
>
> Hi,
>
> This is the second version of the --enable-debug build fix for the
> riscv-to-apply.next branch:
>
> https://github.com/alistair23/qemu/tree/riscv-to-apply.next
>
> This implements suggestions from Richard Henderson made in v1. Most
> notable difference is that riscv_kvm_aplic_request() was moved to
> kvm.c and it's now being declared in kvm_riscv.h.

Thanks!

Applied to riscv-to-apply.next

Alistair

>
> Changes from v1:
> - changed patch order
> - patch 1 (former 2):
>   - use kvm_enabled() to crop the whole block
> - patch 2 (former 1):
>   - move riscv_kvm_aplic_request() to kvm_riscv.h
>   - use kvm_enabled() to crop the whole block
> - v1 link: https://lore.kernel.org/qemu-riscv/20230829122144.464489-1-dbarboza@ventanamicro.com/
>
>
> Daniel Henrique Barboza (2):
>   hw/riscv/virt.c: fix non-KVM --enable-debug build
>   hw/intc/riscv_aplic.c fix non-KVM --enable-debug build
>
>  hw/intc/riscv_aplic.c    | 8 ++------
>  hw/riscv/virt.c          | 6 +++---
>  target/riscv/kvm.c       | 5 +++++
>  target/riscv/kvm_riscv.h | 1 +
>  4 files changed, 11 insertions(+), 9 deletions(-)
>
> --
> 2.41.0
>
>