From nobody Tue May 14 17:46:50 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1693322802; cv=none; d=zohomail.com; s=zohoarc; b=BdMUmhCxI25j2pIXJ/t0zXTEagXkFbqSryhFJuMunY0ATTTO0QNrhccMUHS6ZPdcCo4fel18RL+q4UWxjblQyfSv/HHoQx574DA6ps8y5j9EBtWa0oSrhKlByLlZG6FPUDiYB1TE6uJJKko/RE7oaR4iha6A/8N+jmpQFdN3IEo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693322802; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=CMuAafKXq3gse0UedUzJh/uxFnCA61JyJOs1yFqIgas=; b=YoQvb3p7CoxldxAmyPnT8hnMvW6LQeWTlwBF82+a7cM1/mGeNyedcyZVzdyFvMgxHVHKxFpF2AbQ+MoU8CIf46I5p9+ILZJR/fV/JLE4hs3nuvoaPgNZh4fcdDw4JVZ/jCgvTrFZ5VmXPX0cV3mDTMvIZLV1ijzzPoaDcwAgN3A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1693322802618775.9911550954995; Tue, 29 Aug 2023 08:26:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qb0bj-0005wJ-UI; Tue, 29 Aug 2023 11:26:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qb0bi-0005vj-KJ for qemu-devel@nongnu.org; Tue, 29 Aug 2023 11:26:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qb0bf-00055Z-Rk for qemu-devel@nongnu.org; Tue, 29 Aug 2023 11:26:17 -0400 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-4HX8gB8DOJOWY65ZBF7b3w-1; Tue, 29 Aug 2023 11:26:08 -0400 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fbdf341934so31896165e9.3 for ; Tue, 29 Aug 2023 08:26:08 -0700 (PDT) Received: from [192.168.1.174] ([151.48.237.81]) by smtp.gmail.com with ESMTPSA id m15-20020adffe4f000000b003195504c754sm13997876wrs.31.2023.08.29.08.26.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 08:26:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693322770; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CMuAafKXq3gse0UedUzJh/uxFnCA61JyJOs1yFqIgas=; b=SluMMWqGg8sDkC9e9FiWcBC3KTQJGXeBxz4O9RYk6OnXfBFeyXmj6ewejD/8pLSN4PfPcf sYNEF1snG+kqC/7JHdIb7leHdm2a54TLAReRVk94swdr2og0C3mr9r+5KblFOY1BwYprTi mj7cA6pMZKXX2KOSAmN15Bd72jKtENE= X-MC-Unique: 4HX8gB8DOJOWY65ZBF7b3w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693322767; x=1693927567; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CMuAafKXq3gse0UedUzJh/uxFnCA61JyJOs1yFqIgas=; b=NbZK6GvcHgexjf4wWpW4nvjKnx/rqB0sqFAKrcujxPz6s0bdfgEgUdN52zodWg4rGH Eoxmb3Ei7bBSzMBa8DPmx1KeJMmk/KAuI/CsjL51sj097c1cUs7lLi9vo0zRYrt1E+9e AR9HD7WzhJalS6tkP7Uz7QkfN4RxOyv/UaacU3bFPxmbdG3NxyfqX689eL3bqkIGgINp a3FiaCSo1gRyDlwu7u+IpI3BKJxDNx8QETd+PWWjAOVRlclSTmCR6yAP7bdGi0n3uH4I KANvZNklTdvmgcTjekIoqu9CPtVobzBDk1n2wEeLYLKKJ5oGqR2ZmZGfSHlH/sLcmDLL OezA== X-Gm-Message-State: AOJu0Yy5VnECqe0KPCjUj5RTHRkIiV7EIOzm/qJRx5sHHhyK7oI0C5GE km1nrqO7kqdaXKgYR2Cf3j75QwMuLV+1nGFD4X6Pe5NJk+zsacG+MWl/5zJ51C6Lhzl8zJLN56U DAT3yvm/W29pQU6tthI7VGf7cjxVDP7ybniRkCVjhF7SfHV4q7wLarmhIG9shuPuABzvjCpsatu c= X-Received: by 2002:adf:e645:0:b0:31a:d90e:42cd with SMTP id b5-20020adfe645000000b0031ad90e42cdmr22103393wrn.35.1693322767034; Tue, 29 Aug 2023 08:26:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGqIsEdNToOFQFbNDdhgvtQosr+FhRUX97Ta4NwQeP9yVUQBkrKUsSwohXd07gTVrP5s7uALw== X-Received: by 2002:adf:e645:0:b0:31a:d90e:42cd with SMTP id b5-20020adfe645000000b0031ad90e42cdmr22103374wrn.35.1693322766535; Tue, 29 Aug 2023 08:26:06 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org Subject: [PATCH] target/i386: raise FERR interrupt with iothread locked Date: Tue, 29 Aug 2023 17:25:55 +0200 Message-ID: <20230829152604.101542-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1693322804558100003 Content-Type: text/plain; charset="utf-8" Otherwise tcg_handle_interrupt() triggers an assertion failure: #5 0x0000555555c97369 in tcg_handle_interrupt (cpu=3D0x555557434cb0, mas= k=3D2) at ../accel/tcg/tcg-accel-ops.c:83 #6 tcg_handle_interrupt (cpu=3D0x555557434cb0, mask=3D2) at ../accel/tcg= /tcg-accel-ops.c:81 #7 0x0000555555b4d58b in pic_irq_request (opaque=3D, irq= =3D, level=3D1) at ../hw/i386/x86.c:555 #8 0x0000555555b4f218 in gsi_handler (opaque=3D0x5555579423d0, n=3D13, l= evel=3D1) at ../hw/i386/x86.c:611 #9 0x00007fffa42bde14 in code_gen_buffer () #10 0x0000555555c724bb in cpu_tb_exec (cpu=3Dcpu@entry=3D0x555557434cb0, = itb=3D, tb_exit=3Dtb_exit@entry=3D0x7fffe9bfd658) at ../acce= l/tcg/cpu-exec.c:457 Cc: qemu-stable@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1808 Reported-by: NyanCatTW1 Signed-off-by: Paolo Bonzini Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/tcg/sysemu/fpu_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/tcg/sysemu/fpu_helper.c b/target/i386/tcg/sysemu/f= pu_helper.c index 1c3610da3b9..fd8cc72a026 100644 --- a/target/i386/tcg/sysemu/fpu_helper.c +++ b/target/i386/tcg/sysemu/fpu_helper.c @@ -31,7 +31,9 @@ void x86_register_ferr_irq(qemu_irq irq) void fpu_check_raise_ferr_irq(CPUX86State *env) { if (ferr_irq && !(env->hflags2 & HF2_IGNNE_MASK)) { + qemu_mutex_lock_iothread(); qemu_irq_raise(ferr_irq); + qemu_mutex_unlock_iothread(); return; } } --=20 2.41.0