[v1] qapi/migration: Dedup migration parameter objects and fix tls-authz crash

[PATCH for-8.2 0/4] qapi/migration: Dedup migration parameter objects and fix tls-authz crash

Peter Xu posted 4 patches 9 months ago

Diff against v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230814221947.353093-1-peterx@redhat.com

Maintainers: Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

There is a newer version of this series

qapi/migration.json            | 364 +--------------------------------
migration/options.h            |  47 +++++
migration/migration-hmp-cmds.c |  19 +-
migration/options.c            | 191 ++++++-----------
tests/qtest/migration-test.c   |  24 +++
5 files changed, 136 insertions(+), 509 deletions(-)

Expand all Fold all

[PATCH for-8.2 0/4] qapi/migration: Dedup migration parameter objects and fix tls-authz crash

Posted by Peter Xu 9 months ago

Patch 1 fixes the tls-authz crashing when someone specifies "null"
parameter for tls-authz.

Patch 2 added a test case for all three tls-auth parameters specifying
"null" to make sure nothing will crash ever with 'null' passed into it.

Patch 3-4 are the proposed patches to deduplicate the three migration
parameter objects in qapi/migration.json.  Note that in this version (patch
3) we used 'str' to replace 'StrOrNull' for tls-* parameters to make then
deduplicate-able.

Please review, thanks.

Peter Xu (4):
  migration/qmp: Fix crash on setting tls-authz with null
  tests/migration-test: Add a test for null parameter setups
  migration/qapi: Replace @MigrateSetParameters with
    @MigrationParameters
  migration/qapi: Drop @MigrationParameter enum

 qapi/migration.json            | 364 +--------------------------------
 migration/options.h            |  47 +++++
 migration/migration-hmp-cmds.c |  19 +-
 migration/options.c            | 191 ++++++-----------
 tests/qtest/migration-test.c   |  24 +++
 5 files changed, 136 insertions(+), 509 deletions(-)

-- 
2.41.0