Fix the build on CentOS 7

[PATCH 0/3] Fix the build on CentOS 7

Ilya Leoshkevich posted 3 patches 9 months, 2 weeks ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230810215706.1394220-1-iii@linux.ibm.com

Maintainers: Laurent Vivier <laurent@vivier.eu>

linux-user/mmap.c    | 1 +
linux-user/syscall.c | 3 +++
2 files changed, 4 insertions(+)

Expand all Fold all

[PATCH 0/3] Fix the build on CentOS 7

Posted by Ilya Leoshkevich 9 months, 2 weeks ago

Hi,

I know that CentOS 7 is not tested anymore, but unfortunately it's the
only ppc64le system that I have, so I had to fix a few build issues
that crept in since the testing stopped. The fixes are simple and may
be helpful to people in the same situation.

Best regards,
Ilya

Ilya Leoshkevich (3):
  linux-user: Fix the build on systems without SOL_ALG
  linux-user: Fix the build on systems without MAP_SHARED_VALIDATE
  linux-user: Fix the build on systems without MADV_{KEEP,WIPE}ONFORK

 linux-user/mmap.c    | 1 +
 linux-user/syscall.c | 3 +++
 2 files changed, 4 insertions(+)

-- 
2.41.0

Re: [PATCH 0/3] Fix the build on CentOS 7

Posted by Daniel P. Berrangé 9 months, 1 week ago

On Thu, Aug 10, 2023 at 11:51:30PM +0200, Ilya Leoshkevich wrote:
> Hi,
> 
> I know that CentOS 7 is not tested anymore, but unfortunately it's the
> only ppc64le system that I have, so I had to fix a few build issues
> that crept in since the testing stopped. The fixes are simple and may
> be helpful to people in the same situation.

Actually it is more than not tested. CentOS 7 is explicitly
unsupported per our platform support matrix:

https://www.qemu.org/docs/master/about/build-platforms.html

and thus we will *intentionally* delete backwards compatibility code
that it needs, in order to simplify QEMU's codebase.

> Ilya Leoshkevich (3):
>   linux-user: Fix the build on systems without SOL_ALG
>   linux-user: Fix the build on systems without MAP_SHARED_VALIDATE
>   linux-user: Fix the build on systems without MADV_{KEEP,WIPE}ONFORK

We explicitly do NOT want to add this kind of back compat code
for unsupported platforms.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|