configure | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
The tricore tools are not detected when they are installed in
the host system, only if they are taken from an external
container. For this reason the build-tricore-softmmu job
was not running the TCG tests.
In addition the container provides all tools, not just as/ld/gcc,
so there is no need to special case tricore.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/configure b/configure
index 133f4e32351..f2bd8858d6c 100755
--- a/configure
+++ b/configure
@@ -1271,6 +1271,7 @@ fi
: ${cross_prefix_sh4="sh4-linux-gnu-"}
: ${cross_prefix_sparc64="sparc64-linux-gnu-"}
: ${cross_prefix_sparc="$cross_prefix_sparc64"}
+: ${cross_prefix_tricore="tricore-"}
: ${cross_prefix_x86_64="x86_64-linux-gnu-"}
: ${cross_cc_aarch64_be="$cross_cc_aarch64"}
@@ -1458,10 +1459,6 @@ probe_target_compiler() {
tricore)
container_image=debian-tricore-cross
container_cross_prefix=tricore-
- container_cross_as=tricore-as
- container_cross_ld=tricore-ld
- container_cross_cc=tricore-gcc
- break
;;
x86_64)
container_image=debian-amd64-cross
--
2.41.0
On 9/8/23 10:29, Paolo Bonzini wrote: > The tricore tools are not detected when they are installed in > the host system, only if they are taken from an external > container. For this reason the build-tricore-softmmu job > was not running the TCG tests. > > In addition the container provides all tools, not just as/ld/gcc, > so there is no need to special case tricore. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > configure | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Wed, Aug 09, 2023 at 10:29:44AM +0200, Paolo Bonzini wrote: > The tricore tools are not detected when they are installed in > the host system, only if they are taken from an external > container. For this reason the build-tricore-softmmu job > was not running the TCG tests. > > In addition the container provides all tools, not just as/ld/gcc, > so there is no need to special case tricore. > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > configure | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) I think it would be better to skip debian-11 and use 12 instead. Cheers, Bastian
On Wed, Aug 09, 2023 at 03:49:01PM +0200, Bastian Koppelmann wrote: > On Wed, Aug 09, 2023 at 10:29:44AM +0200, Paolo Bonzini wrote: > > The tricore tools are not detected when they are installed in > > the host system, only if they are taken from an external > > container. For this reason the build-tricore-softmmu job > > was not running the TCG tests. > > > > In addition the container provides all tools, not just as/ld/gcc, > > so there is no need to special case tricore. > > > > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > > --- > > configure | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > I think it would be better to skip debian-11 and use 12 instead. Whoops I mixed it up with the other patch. For this one you can have Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de> Cheers, Bastian > > Cheers, > Bastian
© 2016 - 2024 Red Hat, Inc.