thunk: Delete checks for old host definitions

[PATCH] thunk: Delete checks for old host definitions

Posted by Akihiko Odaki 2 years, 6 months ago

Alpha, IA-64, and PA-RISC hosts are no longer supported.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 include/exec/user/thunk.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
index 300a840d58..d9c131ec80 100644
--- a/include/exec/user/thunk.h
+++ b/include/exec/user/thunk.h
@@ -111,8 +111,7 @@ static inline int thunk_type_size(const argtype *type_ptr, int is_host)
         if (is_host) {
 #if defined(HOST_X86_64)
             return 8;
-#elif defined(HOST_ALPHA) || defined(HOST_IA64) || defined(HOST_MIPS) || \
-      defined(HOST_PARISC) || defined(HOST_SPARC64)
+#elif defined(HOST_MIPS) || defined(HOST_SPARC64)
             return 4;
 #elif defined(HOST_PPC)
             return sizeof(void *);
-- 
2.41.0

Re: [PATCH] thunk: Delete checks for old host definitions

Posted by Philippe Mathieu-Daudé 2 years, 6 months ago

Helge and myself sometime run the tests on a HPPA host
(testing the QEMU tools). I guess remember John Paul
also runs some on Alpha (so Cc'ing him).

Helge, what is your take on this?

On 8/8/23 17:23, Akihiko Odaki wrote:
> Alpha, IA-64, and PA-RISC hosts are no longer supported.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   include/exec/user/thunk.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
> index 300a840d58..d9c131ec80 100644
> --- a/include/exec/user/thunk.h
> +++ b/include/exec/user/thunk.h
> @@ -111,8 +111,7 @@ static inline int thunk_type_size(const argtype *type_ptr, int is_host)
>           if (is_host) {
>   #if defined(HOST_X86_64)
>               return 8;
> -#elif defined(HOST_ALPHA) || defined(HOST_IA64) || defined(HOST_MIPS) || \
> -      defined(HOST_PARISC) || defined(HOST_SPARC64)
> +#elif defined(HOST_MIPS) || defined(HOST_SPARC64)
>               return 4;
>   #elif defined(HOST_PPC)
>               return sizeof(void *);

Re: [PATCH] thunk: Delete checks for old host definitions

Posted by Akihiko Odaki 2 years, 6 months ago

On 2023/08/10 19:56, Philippe Mathieu-Daudé wrote:
> Helge and myself sometime run the tests on a HPPA host
> (testing the QEMU tools). I guess remember John Paul
> also runs some on Alpha (so Cc'ing him).
> 
> Helge, what is your take on this?

This file is only used in userspace emulation so it's not a problem for 
Alpha, which does no longer have userspace emulation.

The story is different for HPPA. HPPA has userspace emulation code and 
there are also references for HOST_HPPA in coroutine code 
(util/async-teardown.c and util/os-posix.c). Probably HPPA support is 
broken both for userspace and system emulation. I think it's time to 
think of dropping HPPA support for both of userspace and system emulation.

> 
> On 8/8/23 17:23, Akihiko Odaki wrote:
>> Alpha, IA-64, and PA-RISC hosts are no longer supported.
>>
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>> ---
>>   include/exec/user/thunk.h | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
>> index 300a840d58..d9c131ec80 100644
>> --- a/include/exec/user/thunk.h
>> +++ b/include/exec/user/thunk.h
>> @@ -111,8 +111,7 @@ static inline int thunk_type_size(const argtype 
>> *type_ptr, int is_host)
>>           if (is_host) {
>>   #if defined(HOST_X86_64)
>>               return 8;
>> -#elif defined(HOST_ALPHA) || defined(HOST_IA64) || defined(HOST_MIPS) 
>> || \
>> -      defined(HOST_PARISC) || defined(HOST_SPARC64)
>> +#elif defined(HOST_MIPS) || defined(HOST_SPARC64)
>>               return 4;
>>   #elif defined(HOST_PPC)
>>               return sizeof(void *);
>

Re: [PATCH] thunk: Delete checks for old host definitions

Posted by Helge Deller 2 years, 6 months ago

On 8/10/23 23:29, Akihiko Odaki wrote:
> On 2023/08/10 19:56, Philippe Mathieu-Daudé wrote:
>> Helge and myself sometime run the tests on a HPPA host

I think we mix up HOST and TARGET here....
I run HPPA target (=guest) on x86-64 host.
That means, both qemu-hppa-user and qemu-hppa-system does
run fine for me (on x86-64 "HOST_X86_64" emulating HPPA).

>> (testing the QEMU tools). I guess remember John Paul
>> also runs some on Alpha (so Cc'ing him).

Yes, I think so.
If I find more time I'd like too.

>> Helge, what is your take on this?
>
> This file is only used in userspace emulation so it's not a problem
> for Alpha, which does no longer have userspace emulation.

Akihiko, your statement is correct, but somewhat misleading.
A native alpha machine (as host) isn't any longer able to run a linux-user
emulation to emulate Linux for some other architecture.
That's true.

> The story is different for HPPA. HPPA has userspace emulation code
> and there are also references for HOST_HPPA in coroutine code
> (util/async-teardown.c and util/os-posix.c). Probably HPPA support is
> broken both for userspace and system emulation. I think it's time to
> think of dropping HPPA support for both of userspace and system
> emulation.
HPPA as host... Yes, I think it doesn't make sense to try to emulate
something else on HPPA.

So, I think the patch below is OK.

Helge

>> On 8/8/23 17:23, Akihiko Odaki wrote:
>>> Alpha, IA-64, and PA-RISC hosts are no longer supported.
>>>
>>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>>> ---
>>>   include/exec/user/thunk.h | 3 +--
>>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
>>> index 300a840d58..d9c131ec80 100644
>>> --- a/include/exec/user/thunk.h
>>> +++ b/include/exec/user/thunk.h
>>> @@ -111,8 +111,7 @@ static inline int thunk_type_size(const argtype *type_ptr, int is_host)
>>>           if (is_host) {
>>>   #if defined(HOST_X86_64)
>>>               return 8;
>>> -#elif defined(HOST_ALPHA) || defined(HOST_IA64) || defined(HOST_MIPS) || \
>>> -      defined(HOST_PARISC) || defined(HOST_SPARC64)
>>> +#elif defined(HOST_MIPS) || defined(HOST_SPARC64)
>>>               return 4;
>>>   #elif defined(HOST_PPC)
>>>               return sizeof(void *);
>>
>

Re: [PATCH] thunk: Delete checks for old host definitions

Posted by Peter Maydell 2 years, 6 months ago

On Tue, 8 Aug 2023 at 16:23, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> Alpha, IA-64, and PA-RISC hosts are no longer supported.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  include/exec/user/thunk.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
> index 300a840d58..d9c131ec80 100644
> --- a/include/exec/user/thunk.h
> +++ b/include/exec/user/thunk.h
> @@ -111,8 +111,7 @@ static inline int thunk_type_size(const argtype *type_ptr, int is_host)
>          if (is_host) {
>  #if defined(HOST_X86_64)
>              return 8;
> -#elif defined(HOST_ALPHA) || defined(HOST_IA64) || defined(HOST_MIPS) || \
> -      defined(HOST_PARISC) || defined(HOST_SPARC64)
> +#elif defined(HOST_MIPS) || defined(HOST_SPARC64)
>              return 4;
>  #elif defined(HOST_PPC)
>              return sizeof(void *);
> --

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM