util: Delete a check for IA-64

[PATCH] util: Delete a check for IA-64

Posted by Akihiko Odaki 9 months, 2 weeks ago

HOST_IA64 will never be defined since IA-64 host is no longer supported.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 util/oslib-posix.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index 760390b31e..f7adb36dfb 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -618,10 +618,7 @@ void *qemu_alloc_stack(size_t *sz)
         abort();
     }
 
-#if defined(HOST_IA64)
-    /* separate register stack */
-    guardpage = ptr + (((*sz - pagesz) / 2) & ~pagesz);
-#elif defined(HOST_HPPA)
+#if defined(HOST_HPPA)
     /* stack grows up */
     guardpage = ptr + *sz - pagesz;
 #else
-- 
2.41.0

Re: [PATCH] util: Delete a check for IA-64

Posted by Philippe Mathieu-Daudé 9 months, 2 weeks ago

On 8/8/23 17:20, Akihiko Odaki wrote:
> HOST_IA64 will never be defined since IA-64 host is no longer supported.

If you send a v2 removing the similar definition in 
include/exec/user/thunk.h, please mention this is since commit 
b1cef6d02f("Drop remaining bits of ia64 host support").

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   util/oslib-posix.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Re: [PATCH] util: Delete a check for IA-64

Posted by Peter Maydell 9 months, 2 weeks ago

On Tue, 8 Aug 2023 at 16:21, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> HOST_IA64 will never be defined since IA-64 host is no longer supported.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  util/oslib-posix.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index 760390b31e..f7adb36dfb 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -618,10 +618,7 @@ void *qemu_alloc_stack(size_t *sz)
>          abort();
>      }
>
> -#if defined(HOST_IA64)
> -    /* separate register stack */
> -    guardpage = ptr + (((*sz - pagesz) / 2) & ~pagesz);
> -#elif defined(HOST_HPPA)
> +#if defined(HOST_HPPA)
>      /* stack grows up */
>      guardpage = ptr + *sz - pagesz;
>  #else

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

(There's another one in include/exec/user/thunk.h.)

thanks
-- PMM