configure: fix container_hosts misspellings and duplications

[PATCH for-8.2] configure: fix container_hosts misspellings and duplications

Paolo Bonzini posted 1 patch 9 months, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230807092222.467446-1-pbonzini@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>

configure | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[PATCH for-8.2] configure: fix container_hosts misspellings and duplications

Posted by Paolo Bonzini 9 months, 2 weeks ago

container_hosts is matched against $cpu, so it must contain QEMU
canonical architecture names, not Debian architecture names.
Also do not set $container_hosts inside the loop, since it is
already set before.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/configure b/configure
index f5a6624ddf1..0496189787a 100755
--- a/configure
+++ b/configure
@@ -1347,7 +1347,7 @@ probe_target_compiler() {
     sh4) container_hosts=x86_64 ;;
     sparc64) container_hosts=x86_64 ;;
     tricore) container_hosts=x86_64 ;;
-    x86_64) container_hosts="aarch64 ppc64el x86_64" ;;
+    x86_64) container_hosts="aarch64 ppc64le x86_64" ;;
     xtensa*) container_hosts=x86_64 ;;
   esac
 
@@ -1458,7 +1458,6 @@ probe_target_compiler() {
         container_cross_prefix=x86_64-linux-gnu-
         ;;
       xtensa*)
-        container_hosts=x86_64
         container_image=debian-xtensa-cross
 
         # default to the dc232b cpu
-- 
2.41.0

Re: [PATCH for-8.2] configure: fix container_hosts misspellings and duplications

Posted by Philippe Mathieu-Daudé 9 months, 2 weeks ago

On 7/8/23 11:22, Paolo Bonzini wrote:
> container_hosts is matched against $cpu, so it must contain QEMU
> canonical architecture names, not Debian architecture names.
> Also do not set $container_hosts inside the loop, since it is
> already set before.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   configure | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH for-8.2] configure: fix container_hosts misspellings and duplications

Posted by Richard Henderson 9 months, 2 weeks ago

On 8/7/23 02:22, Paolo Bonzini wrote:
> container_hosts is matched against $cpu, so it must contain QEMU
> canonical architecture names, not Debian architecture names.
> Also do not set $container_hosts inside the loop, since it is
> already set before.
> 
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   configure | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~