[v2] block/blkio: fix fd leak and add more comments for the fd passing

[PATCH v2 0/2] block/blkio: fix fd leak and add more comments for the fd passing

Stefano Garzarella posted 2 patches 9 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230803082825.25293-1-sgarzare@redhat.com

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>

block/blkio.c | 26 ++++++++++++++++++++------
1 file changed, 20 insertions(+), 6 deletions(-)

Expand all Fold all

[PATCH v2 0/2] block/blkio: fix fd leak and add more comments for the fd passing

Posted by Stefano Garzarella 9 months ago

Hanna discovered an fd leak in the error path, and a few comments to
improve in the code.

v2:
  - avoid to use `fd_supported` to track a valid fd [Hanna]

v1: https://lore.kernel.org/qemu-devel/20230801160332.122564-1-sgarzare@redhat.com/

Stefano Garzarella (2):
  block/blkio: close the fd when blkio_connect() fails
  block/blkio: add more comments on the fd passing handling

 block/blkio.c | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

-- 
2.41.0

Re: [PATCH v2 0/2] block/blkio: fix fd leak and add more comments for the fd passing

Posted by Stefan Hajnoczi 9 months ago

On Thu, Aug 03, 2023 at 10:28:23AM +0200, Stefano Garzarella wrote:
> Hanna discovered an fd leak in the error path, and a few comments to
> improve in the code.
> 
> v2:
>   - avoid to use `fd_supported` to track a valid fd [Hanna]
> 
> v1: https://lore.kernel.org/qemu-devel/20230801160332.122564-1-sgarzare@redhat.com/
> 
> Stefano Garzarella (2):
>   block/blkio: close the fd when blkio_connect() fails
>   block/blkio: add more comments on the fd passing handling
> 
>  block/blkio.c | 26 ++++++++++++++++++++------
>  1 file changed, 20 insertions(+), 6 deletions(-)
> 
> -- 
> 2.41.0
> 

Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block

Stefan