From nobody Wed May 22 00:31:06 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1690847629; cv=none; d=zohomail.com; s=zohoarc; b=nErNdaXZLYiSv6O+m4KWE7M8GEvTZgSzhxaksAwaLWEUZnfREmSahFOeUJnwxvLrtkcDeqAXqCj62ra78u6hnD5/LBZsYl9/nuaFoRVIIGSHa6Hp8UomUDIqUXG06Ml0O9H+tVt5Wc5ncKxAaJigc7nVRvm1JoKzmTuH0E5cNos= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690847629; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=lBIbXsN4bHfTbFNphLaGoglf79ZRkhCba3B1C8It6qg=; b=PMIzrDMEAc9En2spHLDNDmmfDyJMiQll2z6ZcpStrFnjcO8MvVzrdGvk3hqDQn4EV1MS6flrMjZGkjbT25wNdm+jmLXUIjn+t1BcJleRV1pb+QyIdg/OzF0APEYV2s0eZp1IHBJKK/vVW6Yw+7nGssTezXj6hVr9mrx8CV3PIGs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16908476289221002.7459300678655; Mon, 31 Jul 2023 16:53:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQch7-0005Je-AO; Mon, 31 Jul 2023 19:52:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQch5-0005JV-Fb for qemu-devel@nongnu.org; Mon, 31 Jul 2023 19:52:55 -0400 Received: from home.keithp.com ([63.227.221.253] helo=elaine.keithp.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQch3-00055o-Cu for qemu-devel@nongnu.org; Mon, 31 Jul 2023 19:52:55 -0400 Received: from localhost (localhost [127.0.0.1]) by elaine.keithp.com (Postfix) with ESMTP id 83B693F20874; Mon, 31 Jul 2023 16:52:50 -0700 (PDT) Received: from elaine.keithp.com ([127.0.0.1]) by localhost (elaine.keithp.com [127.0.0.1]) (amavis, port 10024) with LMTP id 6061EUqGBaY0; Mon, 31 Jul 2023 16:52:49 -0700 (PDT) Received: from keithp.com (koto.keithp.com [192.168.11.2]) by elaine.keithp.com (Postfix) with ESMTPSA id A73E03F206C6; Mon, 31 Jul 2023 16:52:49 -0700 (PDT) Received: by keithp.com (Postfix, from userid 1000) id 7337B1E601E9; Mon, 31 Jul 2023 16:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1690847570; bh=xrpd7miS6xdyyh0elVy6E4XLvhnZ9Y4rjUYuH/IPFbs=; h=From:To:Cc:Subject:Date:From; b=qlW1Kh8HwgCqvvoosaK6l1qwAey0GvqA+QCLaCTs6ukkoKuO3uJ8KYZs04EYfCRn+ orBL1VxGJq4HT70Ot8+5Yb/jGG33gKfnpGIWhL19mv3KBj7T1KU1aZh1BQ9b0p5lKT F/D2JTZCdJtH85yVA4N0tatN5OtC9nWKHSWzp34GAkb0HMQFU6maFfJIVIkVUNrEJp xFRmm4cRQK3OgcrobdprmSYjHlVq8TJxgS2veaSFXbLvjeS5Jr6KEx4vun4W9QvQIT qfE7KJYsT9owb22rAOzdhb+8M3BH1rf+No8+AckRXZnU/hlj8GgIzX3zl7Z0xoxtzj vf6nhmgYRtWug== X-Virus-Scanned: Debian amavis at keithp.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=keithp.com; s=mail; t=1690847569; bh=xrpd7miS6xdyyh0elVy6E4XLvhnZ9Y4rjUYuH/IPFbs=; h=From:To:Cc:Subject:Date:From; b=iKMtPkOQ8t/EQRsPF1eZTaXWZEd5lbny+qiufOCPxbA/rB+m1dWjCGpHDY56t7/2v GotkghX4Sonk2+b1aRy0Jy3caXwrHWhC1sJ7dTgG3tNY14pPiq/DDju1ilFperD1SP i6Hw6dLG9QYSJ0tve2akI+SQ+1s8Qt7JHwQwYMd8ekdwoRX/ZppIL7MWuHjLisPoJi IRZbvEi//jkoMRHQ5s1Hw18CytXeB3hmVMI11JWja9qC92ApG0nS+gnqwn9Mt3Vbkv hUBvuAieajhYgcmQWGtLRjx5fN6Ffzuedp8FqqRRMn87rkd6OIb50r/z8g8p+POiW2 5Dc824XtOz1GA== To: qemu-devel@nongnu.org Cc: Chris Wulff , Marek Vasut , Keith Packard Subject: [PATCH] target/nios2: Fix semihost lseek offset computation Date: Mon, 31 Jul 2023 16:52:45 -0700 Message-Id: <20230731235245.295513-1-keithp@keithp.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.227.221.253; envelope-from=keithp@keithp.com; helo=elaine.keithp.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Keith Packard From: Keith Packard via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1690847630778100001 Content-Type: text/plain; charset="utf-8" The arguments for deposit64 are (value, start, length, fieldval); this appears to have thought they were (value, fieldval, start, length). Reorder the parameters to match the actual function. Signed-off-by: Keith Packard Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/nios2/nios2-semi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/nios2/nios2-semi.c b/target/nios2/nios2-semi.c index ffd1f095f6..fc1df1dfeb 100644 --- a/target/nios2/nios2-semi.c +++ b/target/nios2/nios2-semi.c @@ -170,7 +170,7 @@ void do_nios2_semihosting(CPUNios2State *env) GET_ARG64(2); GET_ARG64(3); semihost_sys_lseek(cs, nios2_semi_u64_cb, arg0, - deposit64(arg2, arg1, 32, 32), arg3); + deposit64(arg2, 32, 32, arg1), arg3); break; =20 case HOSTED_RENAME: --=20 2.40.1