From nobody Tue May 21 18:18:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1690812974; cv=none; d=zohomail.com; s=zohoarc; b=CkGsgqOm+PL/RK5GwegpgjYu61R1ejPJw/yjAfJ1H18QVIaPlvzYoZquNmDij68BTQVz1jaB2HWnc5HoSHnxr6fsN5ipXS2x1hq18V5BFilNk5MbkFkwX6ZE2y/ZKfJlaL6ReyqVdRD01cPHKQssXyn5oFfcCU3XEraoeATVl9c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690812974; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=G2c+LxpkCJdqb0ZH/SG20fuSzrbSnvwdJMIMMiLTze0=; b=co8b2AdRNic9Q9eqbGfSX6Bq5Eya507eF37egvCRyF7YwonmrsLzUVufnaPIr9EP2K5+iagat1HqDhVgJeJai/4y5eDqdIz7M1h6XsD6KqPfpOS+J1lWlFZiDY650WYxalam6rXHjxDFsZ3OyAd5+4y8KNBLqs9ZO3aJI3G1rgE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1690812974659137.9674964512766; Mon, 31 Jul 2023 07:16:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQTgT-0005Xg-OA; Mon, 31 Jul 2023 10:15:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQTgS-0005WH-1f for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:40 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQTgP-0007eR-N9 for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:39 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3fe2048c910so9788865e9.1 for ; Mon, 31 Jul 2023 07:15:37 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id z15-20020a05600c114f00b003fbb5506e54sm11450675wmz.29.2023.07.31.07.15.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 07:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690812936; x=1691417736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=G2c+LxpkCJdqb0ZH/SG20fuSzrbSnvwdJMIMMiLTze0=; b=yq/4W2XGdu8ykukOpT6cYpEf3IlhIlZQI+lS53iuJMxn3wIw0Krfh2abatuug68f1N jCLftmQvJI9tUdrjVSwpm60Sfa6O5w3f+mP3hd/tDzTUUJG1djgw90LJJt6SpTSq0p1G nP3J3RKFg8xAeJ+67hwkOTh1PrDAYOkyy39aiExLMWIrfOTNgLklwIDGf/2x9s6ERaJg gWG2QNyyOk7JeU9tu/f20m/cZ6iRXbkFUC7wb5WV1FkzR3eJ6o1NEKoh9YvRsLAyNEI4 +TTgx46WRYQSh8R5gyTxwdHi3SUDpfV9rVwuxVRPtiZI1dqA61ZATot8YZF9U8qtNUcJ SqCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690812936; x=1691417736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G2c+LxpkCJdqb0ZH/SG20fuSzrbSnvwdJMIMMiLTze0=; b=QFtB+MaTwaIDvD5AcAwHZQFBl/KCRxG2WHTzvlubmyPKo7G87r4vNEuGqDXGTaxONW m6ITFGsb4FJm0N+Ojpxx114YOE7UqOlNns37lBByUzVjWr4xBxFVDcnZfHEjaqsLuVu4 2gy+f+nX9ZJ5rNXyYVx0YcrvAbtu5Me2AWPboI9nibJizTLQ5CvBrCmEjBZclRhqsVHB JwFQxVHV4a+EyD6K49BwiYT00ksBxqseHa0rsNyYhCHkcZ8ueE34vCkdn5lXM/3b1UaN QCmD9I/EJPtkzfOxkHLYd3v51hyFUQBOofCGztQtvB3YjaV2zpUu/VtxExAYErCysDIM RAog== X-Gm-Message-State: ABy/qLaz63m0WLMbFWgfHZr0rfjmAaWTvoyupIqWLvsUMdZp2qNOYwEa AVNDxXJI0gUg8bIodiIlWQlv1xdBZyX17PhrFYw= X-Google-Smtp-Source: APBJJlGk8mcii20ejdalQtBStTUHOKxfovSuCt9Zo5krGCsix3g1wnlrZMlBHKOdbKU1QAMTAShEKQ== X-Received: by 2002:a1c:7c03:0:b0:3fe:2140:f504 with SMTP id x3-20020a1c7c03000000b003fe2140f504mr71732wmc.20.1690812935803; Mon, 31 Jul 2023 07:15:35 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 1/6] target/arm: Fix MemOp for STGP Date: Mon, 31 Jul 2023 15:15:28 +0100 Message-Id: <20230731141533.3303894-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230731141533.3303894-1-peter.maydell@linaro.org> References: <20230731141533.3303894-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1690812976368100005 Content-Type: text/plain; charset="utf-8" From: Richard Henderson When converting to decodetree, the code to rebuild mop for the pair only made it into trans_STP and not into trans_STGP. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1790 Fixes: 8c212eb6594 ("target/arm: Convert load/store-pair to decodetree") Signed-off-by: Richard Henderson Message-id: 20230726165416.309624-1-richard.henderson@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- target/arm/tcg/translate-a64.c | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index ef0c47407a9..5fa1257d32a 100644 --- a/target/arm/tcg/translate-a64.c +++ b/target/arm/tcg/translate-a64.c @@ -3004,6 +3004,9 @@ static bool trans_STGP(DisasContext *s, arg_ldstpair = *a) MemOp mop; TCGv_i128 tmp; =20 + /* STGP only comes in one size. */ + tcg_debug_assert(a->sz =3D=3D MO_64); + if (!dc_isar_feature(aa64_mte_insn_reg, s)) { return false; } @@ -3029,13 +3032,25 @@ static bool trans_STGP(DisasContext *s, arg_ldstpai= r *a) gen_helper_stg(cpu_env, dirty_addr, dirty_addr); } =20 - mop =3D finalize_memop(s, a->sz); - clean_addr =3D gen_mte_checkN(s, dirty_addr, true, false, 2 << a->sz, = mop); + mop =3D finalize_memop(s, MO_64); + clean_addr =3D gen_mte_checkN(s, dirty_addr, true, false, 2 << MO_64, = mop); =20 tcg_rt =3D cpu_reg(s, a->rt); tcg_rt2 =3D cpu_reg(s, a->rt2); =20 - assert(a->sz =3D=3D 3); + /* + * STGP is defined as two 8-byte memory operations and one tag operati= on. + * We implement it as one single 16-byte memory operation for convenie= nce. + * Rebuild mop as for STP. + * TODO: The atomicity with LSE2 is stronger than required. + * Need a form of MO_ATOM_WITHIN16_PAIR that never requires + * 16-byte atomicity. + */ + mop =3D MO_128; + if (s->align_mem) { + mop |=3D MO_ALIGN_8; + } + mop =3D finalize_memop_pair(s, mop); =20 tmp =3D tcg_temp_new_i128(); if (s->be_data =3D=3D MO_LE) { --=20 2.34.1 From nobody Tue May 21 18:18:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1690812986; cv=none; d=zohomail.com; s=zohoarc; b=ivtBb/dhytIOeLN71gU1YAd9rHmmypJH7ZFyrXy2GFLEDToIDVMHoju9rU4E08p3cJhH6M1q5jgJ0l5Z4nC5lifa7UGhKKa9SaXVQIzw0TEbdEFFYo+eq4DJkTMVZdvbd/bRxIVWgPUsMAHbLQnLBZMy8CDuyxM5ZgZWjbzO9Hk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690812986; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IRJJsXiQGVscOzwBrvnsqBjJfHH56GzCgg2J9O7gwx0=; b=h3axI8Sb7DlYTYUTkOU0xEXwR4XYuaKScKeQvM1pMQRM2aUuxMWdlqDL5XQg3yCYRrxM3cCv7PbhxC31IIigtoximrObfTtwSyZzPmY2xRfp8wrqFdEvEwbC3m2XH2oW+CWbYN5gHESDkbONqhAwaBSl3RvXdMSxaZeqdpAjaVY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16908129864901003.0811455718283; Mon, 31 Jul 2023 07:16:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQTgY-0005a3-7V; Mon, 31 Jul 2023 10:15:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQTgS-0005WX-Go for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:40 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQTgP-0007eT-Pi for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:40 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3fbc5d5746cso49716645e9.2 for ; Mon, 31 Jul 2023 07:15:37 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id z15-20020a05600c114f00b003fbb5506e54sm11450675wmz.29.2023.07.31.07.15.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 07:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690812936; x=1691417736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=IRJJsXiQGVscOzwBrvnsqBjJfHH56GzCgg2J9O7gwx0=; b=uxeB1ZzkopKK73UMeuz+c3AxaygULbEBZEGT7Pyfuwmdu+TqS/mtrbPzKjBJKpuBHG IUI9y6oQw3z08sgSqf1tfMJ3QPNq+yagO18HhLWSWcdprtedSLqTm4oy2WCiAEUSsPEv FHa+gGBRR1c08SqV6WdqnMXoY3X84x4OIQx9ijKMJV3hDs3cizqOAptu0BpMU8vsuIaU ZoxWX0VUMFkCkwXGk6b+X2YqlT8eQTR5RnuNhb7FXGZmtVEq1chCyKWYgmqJC6F4d6Dy 8oiZ4KV3tBrMkAikbidCcbkB7GZ8iLI6cDmjB6xBVv3tgzeoPsu6kEmTH10YXJFKHvTZ 5B1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690812936; x=1691417736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IRJJsXiQGVscOzwBrvnsqBjJfHH56GzCgg2J9O7gwx0=; b=MhR//X9ntfC2YuvnbC5zxadsua7qNJAXYPHmhxm3/6uVTRgCkjBxiJg4s2/fPQQgpc OEexS4I9Zo5BOzjIwffcAl+KZEwBXv4DSRz0EP6chPVAFeoSSRu1Wz8bc1rInZnvvin+ ekdEj8xcD3uXSypPEa+lG/CfvX3HsXY985c/18JA7g5CnSUsXsH3+7JBp3VK4uAWN2KV NrAH6FjGhBLhxtNdKw4p805dnrCYeIdbZd/Kox+/R3ZeIMsoU1LS4INW7CkEvKlZfDjx fjc7ShlUldN/LzwkveqyD4CIkdbomc583KRFiNaKpdHCd1kK8Q3WQj7YltdT8sc3whLD Hh5w== X-Gm-Message-State: ABy/qLb2fXz6dUNb5IaF2wLcsXa8ubDKtFsf3Q/xe3mTijl6FfxYuJ3c wsfLB6AEWmkTHCvYTzaNjxGlqllqTLgG+UmwKto= X-Google-Smtp-Source: APBJJlE9lXKlYmNfKeuZuUET56z4AGdSedb/jWaxtytphZSzNnaTQEBJ9pbI1Q+Ivq4B1c3/kvVeMw== X-Received: by 2002:a7b:cb86:0:b0:3fa:9538:963e with SMTP id m6-20020a7bcb86000000b003fa9538963emr37649wmi.36.1690812936227; Mon, 31 Jul 2023 07:15:36 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 2/6] elf2dmp: Don't abandon when Prcb is set to 0 Date: Mon, 31 Jul 2023 15:15:29 +0100 Message-Id: <20230731141533.3303894-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230731141533.3303894-1-peter.maydell@linaro.org> References: <20230731141533.3303894-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1690812988561100003 Content-Type: text/plain; charset="utf-8" From: Akihiko Odaki Prcb may be set to 0 for some CPUs if the dump was taken before they start. The dump may still contain valuable information for started CPUs so don't abandon conversion in such a case. Signed-off-by: Akihiko Odaki Reviewed-by: Viktor Prutyanov Message-id: 20230611033434.14659-1-akihiko.odaki@daynix.com Signed-off-by: Peter Maydell --- contrib/elf2dmp/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/contrib/elf2dmp/main.c b/contrib/elf2dmp/main.c index 89f0c69ab0f..6d4d18501a3 100644 --- a/contrib/elf2dmp/main.c +++ b/contrib/elf2dmp/main.c @@ -316,6 +316,11 @@ static int fill_context(KDDEBUGGER_DATA64 *kdbg, return 1; } =20 + if (!Prcb) { + eprintf("Context for CPU #%d is missing\n", i); + continue; + } + if (va_space_rw(vs, Prcb + kdbg->OffsetPrcbContext, &Context, sizeof(Context), 0)) { eprintf("Failed to read CPU #%d ContextFrame location\n", i); --=20 2.34.1 From nobody Tue May 21 18:18:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1690812974; cv=none; d=zohomail.com; s=zohoarc; b=cW0jeq64LXm4l/qFvWTwz5yJ3dld16nCrjsS6kjD/texS70KagAukBna1ScYK7w0CZagIzKaVmq7GV1+dE05GxKx8awGVH6LaChIDNu9W5Dr3HypyO2z+7E6X77oDVbaT7nEP9+YwhYu2hPODOlWByOlBsRxpQNX3PVsK8wrAos= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690812974; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=STtOVksr63dEkZ6wAYpplxRzfdJwT/NJYMmDJPe/tsc=; b=YnQ7msxErD2Ged0K5V/Htmeukf45ooudmDV50z2JF28uFXfcN1Pvzd//Rts7JPmyEJoyToOZS8xifb6mLzNrseuL0MsxQ5Zw+IamwhZSzh1Dm03c6+i666o+iA+IG0QB93JINu6PKnmby+XN1Sx8dK6Yfc4x0bdNjJZVgiHdB4Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1690812974461811.595109919581; Mon, 31 Jul 2023 07:16:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQTgW-0005a1-0o; Mon, 31 Jul 2023 10:15:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQTgS-0005WZ-KE for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:40 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQTgQ-0007eb-CQ for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:40 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-3fe2048c910so9789015e9.1 for ; Mon, 31 Jul 2023 07:15:37 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id z15-20020a05600c114f00b003fbb5506e54sm11450675wmz.29.2023.07.31.07.15.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 07:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690812936; x=1691417736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=STtOVksr63dEkZ6wAYpplxRzfdJwT/NJYMmDJPe/tsc=; b=RJcIdCamjcgBEAeVlxYWD5La8/Z/AbzTtdhYk+pkGqMUv0uURpf3huWY/cBt0RXN7p 2EKT0ClB4sWqzqwji4pluVQFEk8qmPbGyWl8oz9QDijka+vowSzIuKPFTGTd8AjEFbjN zNsAnjVbFc9fRY7hI+mkQFbNoF/vBZbpU7ogrv0tHaQ8b9M5xN/s8fNvV0VWOizi605L Qf0ucEO1WK5Xow24bDOaaX+wooSnQ4rtVtg/7VsgVGMA7ygTjrqCegL02nB7hn0N31XY XUjNRpN4p0xt7qgZ1U5ruOGvVduLJtnSTzbmBdLU2RM17L4UN82jpmosJjTKw5v+tWOZ SU/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690812936; x=1691417736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=STtOVksr63dEkZ6wAYpplxRzfdJwT/NJYMmDJPe/tsc=; b=SG/inmGSQWxwfaYiyzjcLHh6PiINhSRcly5/hSBZSpuTyAEkRizUWbJ8/m+HsB/X3w 8CFqxJPmpVvHa8PHe3T6y1bOHlm8ih1ZC43Q3JIAojPjNLYAmW+RTYQ0WGf3gV3JVChS Uo5qIPW4EbHxYzLFL2Y584Y01TohcLSs6KTgNJL68hkEYpSUlRgP5GWJ+2xkraW3lFnp YlZLLG7ctBcFm1PQYF2f0lHKp3i6NJzfZOPrm54oVicRpOeO8Z4dOiwgk/K/gJI3QQzJ BEbH8AliNJKqAyZQf2JD5FgZyn04Ou8AOP28CPrnF6Mhc+pkPCtpmyDnbyJLnM7uXzbz rPpw== X-Gm-Message-State: ABy/qLYcjaqiFdN+018IGBOUnBx6HfVx+QjwE8A1bovKNYZRyeAzQZQ1 jYq+aV+xaQYmv/k6eGwwW4XqN1hFckrZp0mJsx0= X-Google-Smtp-Source: APBJJlFevLDU0L3XKmo7F/9Pe9greEQMqor5idJpCT3BxSvaNtUCX/ciENURBaKYG/AphBl+3JpeYQ== X-Received: by 2002:a05:600c:2a4e:b0:3f9:b30f:a013 with SMTP id x14-20020a05600c2a4e00b003f9b30fa013mr76243wme.6.1690812936651; Mon, 31 Jul 2023 07:15:36 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 3/6] target/arm: Avoid writing to constant TCGv in trans_CSEL() Date: Mon, 31 Jul 2023 15:15:30 +0100 Message-Id: <20230731141533.3303894-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230731141533.3303894-1-peter.maydell@linaro.org> References: <20230731141533.3303894-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1690812976272100002 Content-Type: text/plain; charset="utf-8" In commit 0b188ea05acb5 we changed the implementation of trans_CSEL() to use tcg_constant_i32(). However, this change was incorrect, because the implementation of the function sets up the TCGv_i32 rn and rm to be either zero or else a TCG temp created in load_reg(), and these TCG temps are then in both cases written to by the emitted TCG ops. The result is that we hit a TCG assertion: qemu-system-arm: ../../tcg/tcg.c:4455: tcg_reg_alloc_mov: Assertion `!temp_= readonly(ots)' failed. (or on a non-debug build, just produce a garbage result) Adjust the code so that rn and rm are always writeable temporaries whether the instruction is using the special case "0" or a normal register as input. Cc: qemu-stable@nongnu.org Fixes: 0b188ea05acb5 ("target/arm: Use tcg_constant in trans_CSEL") Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Message-id: 20230727103906.2641264-1-peter.maydell@linaro.org --- target/arm/tcg/translate.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c index 13c88ba1b9f..b71ac2d0d53 100644 --- a/target/arm/tcg/translate.c +++ b/target/arm/tcg/translate.c @@ -8799,7 +8799,7 @@ static bool trans_IT(DisasContext *s, arg_IT *a) /* v8.1M CSEL/CSINC/CSNEG/CSINV */ static bool trans_CSEL(DisasContext *s, arg_CSEL *a) { - TCGv_i32 rn, rm, zero; + TCGv_i32 rn, rm; DisasCompare c; =20 if (!arm_dc_feature(s, ARM_FEATURE_V8_1M)) { @@ -8817,16 +8817,17 @@ static bool trans_CSEL(DisasContext *s, arg_CSEL *a) } =20 /* In this insn input reg fields of 0b1111 mean "zero", not "PC" */ - zero =3D tcg_constant_i32(0); + rn =3D tcg_temp_new_i32(); + rm =3D tcg_temp_new_i32(); if (a->rn =3D=3D 15) { - rn =3D zero; + tcg_gen_movi_i32(rn, 0); } else { - rn =3D load_reg(s, a->rn); + load_reg_var(s, rn, a->rn); } if (a->rm =3D=3D 15) { - rm =3D zero; + tcg_gen_movi_i32(rm, 0); } else { - rm =3D load_reg(s, a->rm); + load_reg_var(s, rm, a->rm); } =20 switch (a->op) { @@ -8846,7 +8847,7 @@ static bool trans_CSEL(DisasContext *s, arg_CSEL *a) } =20 arm_test_cc(&c, a->fcond); - tcg_gen_movcond_i32(c.cond, rn, c.value, zero, rn, rm); + tcg_gen_movcond_i32(c.cond, rn, c.value, tcg_constant_i32(0), rn, rm); =20 store_reg(s, a->rd, rn); return true; --=20 2.34.1 From nobody Tue May 21 18:18:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1690812987; cv=none; d=zohomail.com; s=zohoarc; b=bDNR3qq51HmRsvetCCuJ3PVxYXncJoYpEgrli11gL5aNAvcH97R8HJlUlmZBL7IA2mxi+tprJX9lDG9ocJnTgNnDVzFi5Uo5nWH5I055IgI6jfGO+fO61w+hoj5AX8sHc5Zd4DIM2r60A1K38194spEHHj4t8Z6RhGJ8btOZwxQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690812987; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=itpHEVbLfs3D8/erGt8kWjQtJGFDTxDKtjwIc6dYdN8=; b=Qb1Ko5oYh5G3KO0wirvflJO6up/d5cW1l/21BmhNas2SKibpFSxgn/oZWhBjZZYobHcvdxYMVCX/vTuy+zTljc6vEBe9DxZL5r3XESbHDj6e7s/bXpSkdJTZ9kvSK+jDp1ZfUKSQvwAn6kaCUb1tLLT9Y6WBaZi7gy39t9AjEPc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1690812986958293.28026117121453; Mon, 31 Jul 2023 07:16:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQTgY-0005aA-Ad; Mon, 31 Jul 2023 10:15:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQTgS-0005Wa-L8 for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:40 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQTgQ-0007ei-ON for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:40 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fb4146e8fcso31569445e9.0 for ; Mon, 31 Jul 2023 07:15:38 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id z15-20020a05600c114f00b003fbb5506e54sm11450675wmz.29.2023.07.31.07.15.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 07:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690812937; x=1691417737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=itpHEVbLfs3D8/erGt8kWjQtJGFDTxDKtjwIc6dYdN8=; b=e5+4En45SlVWfKIsyAyz7S0ZUVgFHYMsM+E+yPGBgy+tnKUF/VfSNKbp2JSi68nZv6 AEGVg+pc21h5s1nhNYTDUQD9Ve003ADYmqNRXvbjd58hJgLLIfCiBv1kffNODXG2O5Vi P14BoUUZEbPwOFTllStI91VZF7BVCUQMEwHZipaXgMVWn4OiBOTF53WcXe1T+KS5JXl6 DHyXZJH0u2iu2rNV1qO/lqA/cyDC3hJLwN+iAeKtq9xMRuxk5kjLoeGtlyNvNVFeGV3c nS/DWejQngouDrfRmwbkRFUUeqiB4cbyWLOD7PbgWpD52W4znvEERh0izytx5IboL6En wL2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690812937; x=1691417737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=itpHEVbLfs3D8/erGt8kWjQtJGFDTxDKtjwIc6dYdN8=; b=RpS9i4jiYAmOwOSDntEH0ljgdA8Ywj47S8t4TJFnirxtdD4FosxKtZTlZjamyHCbRj Lr69jm1vM94fZNg7IBwk74+iEMV0cRxgXYecNtPNHNpbvRP16PPcXnO2QvXqm2hxNYwp firnFnqw1lSK/cxDjxEWeoq5iV6sMkhy2HTAgim+GA1dkTm+TZG9fMP3cK6e8gEmSBBJ Jf0fJedIN+hjwxETSSX+YQI+I9ov76/NPE5K9qNgdMob5Nu1pQrJX3Ic5Mu/z2kypTIY n3j9LhChXVa5Lcz1BYV/Rglm0MIndiEa20VBVmYjothr94khSkoamOo775Itbhvjyele v8/A== X-Gm-Message-State: ABy/qLZWYpazJBCCwolYoiF2081V7+R4g1ucmRiqSwt9rxiZPOi76H2a Ls/NVfCyLKgGcR7OhmZVELeC4xmd7DMFYFcjsr8= X-Google-Smtp-Source: APBJJlH3/iXOLSmQVS82aDbh+0PRPg1jOccDSVBBkBx1dNYj1ASBIgmoAuYhlKZxMUDSlT2ws10NQg== X-Received: by 2002:a05:600c:3d13:b0:3fb:e1d0:6417 with SMTP id bh19-20020a05600c3d1300b003fbe1d06417mr10584857wmb.19.1690812937057; Mon, 31 Jul 2023 07:15:37 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 4/6] target/arm/tcg: Don't build AArch64 decodetree files for qemu-system-arm Date: Mon, 31 Jul 2023 15:15:31 +0100 Message-Id: <20230731141533.3303894-5-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230731141533.3303894-1-peter.maydell@linaro.org> References: <20230731141533.3303894-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1690812987952100001 Currently we list all the Arm decodetree files together and add them unconditionally to arm_ss. This means we build them for both qemu-system-aarch64 and qemu-system-arm. However, some of them are AArch64-specific, so there is no need to build them for qemu-system-arm. (Meson is smart enough to notice that the generated .c.inc file is not used by any objects that go into qemu-system-arm, so we only unnecessarily run decodetree, not anything more heavyweight like a recompile or relink, but it's still unnecessary work.) Split gen into gen_a32 and gen_a64, and only add gen_a64 for TARGET_AARCH64 compiles. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20230718104628.1137734-1-peter.maydell@linaro.org --- target/arm/tcg/meson.build | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build index bdcab564899..6fca38f2ccb 100644 --- a/target/arm/tcg/meson.build +++ b/target/arm/tcg/meson.build @@ -1,7 +1,11 @@ -gen =3D [ +gen_a64 =3D [ + decodetree.process('a64.decode', extra_args: ['--static-decode=3Ddisas_a= 64']), decodetree.process('sve.decode', extra_args: '--decode=3Ddisas_sve'), decodetree.process('sme.decode', extra_args: '--decode=3Ddisas_sme'), decodetree.process('sme-fa64.decode', extra_args: '--static-decode=3Ddis= as_sme_fa64'), +] + +gen_a32 =3D [ decodetree.process('neon-shared.decode', extra_args: '--decode=3Ddisas_n= eon_shared'), decodetree.process('neon-dp.decode', extra_args: '--decode=3Ddisas_neon_= dp'), decodetree.process('neon-ls.decode', extra_args: '--decode=3Ddisas_neon_= ls'), @@ -13,10 +17,10 @@ gen =3D [ decodetree.process('a32-uncond.decode', extra_args: '--static-decode=3Dd= isas_a32_uncond'), decodetree.process('t32.decode', extra_args: '--static-decode=3Ddisas_t3= 2'), decodetree.process('t16.decode', extra_args: ['-w', '16', '--static-deco= de=3Ddisas_t16']), - decodetree.process('a64.decode', extra_args: ['--static-decode=3Ddisas_a= 64']), ] =20 -arm_ss.add(gen) +arm_ss.add(gen_a32) +arm_ss.add(when: 'TARGET_AARCH64', if_true: gen_a64) =20 arm_ss.add(files( 'cpu32.c', --=20 2.34.1 From nobody Tue May 21 18:18:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1690812980; cv=none; d=zohomail.com; s=zohoarc; b=T0ck4uh9xjIE/RSsP+LfVRnPMUIYHpj9+DCgBt9Hi2sk4FRR5MT+FUPP2427WloKWuXnVEis6p6zC7DupLEfSSKP5/sp8MKkdXfDNv38xmzNcEYskEG+tZUOSD9YqJADuS+2V5tuKE9z+bGsrJOL/fPuChrOHTpuVKkwmo1Pd58= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690812980; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nGXXdjxZdAaUuuyvA4vW1eeAGJKvdfA5mFX80NPb9+I=; b=UQRKNlphnencitNr0f1pUi+/8mTQMzh6yI+e4KUGPPaRuWcz0Z/gEIUsB27EoVKNr+hAOTSl1FTsaXcIgr51fIRezCG0LxS9a6hIFn0aeIoxAKM1oZ7fxreqviJOiP0wtNf1wG3pzMMov1pZWctGPDKjGUi+Q42RVxCdsfMkkZw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1690812980143838.2641881053296; Mon, 31 Jul 2023 07:16:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQTgV-0005Zz-AE; Mon, 31 Jul 2023 10:15:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQTgT-0005XJ-5D for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:41 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQTgR-0007et-07 for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:40 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3fe2048c910so9789195e9.1 for ; Mon, 31 Jul 2023 07:15:38 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id z15-20020a05600c114f00b003fbb5506e54sm11450675wmz.29.2023.07.31.07.15.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 07:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690812937; x=1691417737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=nGXXdjxZdAaUuuyvA4vW1eeAGJKvdfA5mFX80NPb9+I=; b=t0vvZVRQbYm4SQlk+vv03R+1hzQ6xwOI/R4QeLRgj9pnOImRQsDwiNR+nRCxon7yUg lbnkGojE7rMLRd7IMiQzrd4PkkXWFOQxf/bo+F/l98PdbVpbbtb1GRV6N8/n4/w45a1F lMbCW9Z+LRaVtcfTm6XKMtHed2RjCMDiOSXDvEjUAl4+ATDlzCwqoRcaZ7+7rnWDfZn3 Wb47otAHEAcO+vr/45bWuOaY1J2rloaKTB8ZmtGEwSsWdzM7dMd3LHrc7BsOgL97bqOg M7pdTdNT/DErhokuoSQoMW2WKmABYByx/fabN9frA13/qhSUUR7pNhz7yDXha3W5epup /gqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690812937; x=1691417737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nGXXdjxZdAaUuuyvA4vW1eeAGJKvdfA5mFX80NPb9+I=; b=b7dhNTkLdKTFAKElBfvh8eQXBZwBKQOgBO1P5n6Y0506NfnySO+udOrRpCj9OSduWu ai5vDvQjRPM0LMVpHzmvmzPh5EDg+QUgR1DL0L/NerfjIZZzB3wXkvhwGQPP+91kueLA /trYZE9gVT1u+rAgY9uZ1mf4l4gwFVpS9RILKjFUA4ZvnxhUn/NW3AVVWjUQEfAXY07V 5ryQnJNew/UJpvP05neNf4p5KGbbOYaU2XSqMpjcQgVcjNnH2TxEKGTY+jl8yp7NrK8S ITZSivwgG1+Wkrjy50eHZI9eqcahNmB2eRuUamVH89CTxVEKc1qKRtD/fJ5EIzqocPXl D+uQ== X-Gm-Message-State: ABy/qLYl54KxkEacCMotWZV9k4h4sVcz51h/Os9+iz5+fL0g/2V1HxSL IjXAAggmkQOp8l8xHZ/UL5EGf2NLWOkgloIyYO0= X-Google-Smtp-Source: APBJJlGweNEEVM1MIhxDK0mw0tmyG1h4p4atbtBdwUEelkKr+u4RnMzBJz3zaSHiBGdgOHTAeuwbAw== X-Received: by 2002:a05:600c:2482:b0:3fe:2167:97d4 with SMTP id 2-20020a05600c248200b003fe216797d4mr61136wms.29.1690812937549; Mon, 31 Jul 2023 07:15:37 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 5/6] kvm: Fix crash due to access uninitialized kvm_state Date: Mon, 31 Jul 2023 15:15:32 +0100 Message-Id: <20230731141533.3303894-6-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230731141533.3303894-1-peter.maydell@linaro.org> References: <20230731141533.3303894-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1690812981934100001 From: Gavin Shan Runs into core dump on arm64 and the backtrace extracted from the core dump is shown as below. It's caused by accessing uninitialized @kvm_state in kvm_flush_coalesced_mmio_buffer() due to commit 176d073029 ("hw/arm/virt: Use machine_memory_devices_init()"), where the machine's memory region is added earlier than before. main qemu_init configure_accelerators qemu_opts_foreach do_configure_accelerator accel_init_machine kvm_init virt_kvm_type virt_set_memmap machine_memory_devices_init memory_region_add_subregion memory_region_add_subregion_common memory_region_update_container_subregions memory_region_transaction_begin qemu_flush_coalesced_mmio_buffer kvm_flush_coalesced_mmio_buffer Fix it by bailing early in kvm_flush_coalesced_mmio_buffer() on the uninitialized @kvm_state. With this applied, no crash is observed on arm64. Fixes: 176d073029 ("hw/arm/virt: Use machine_memory_devices_init()") Signed-off-by: Gavin Shan Reviewed-by: David Hildenbrand Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20230731125946.2038742-1-gshan@redhat.com Signed-off-by: Peter Maydell --- accel/kvm/kvm-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 373d876c058..7b3da8dc3ab 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2812,7 +2812,7 @@ void kvm_flush_coalesced_mmio_buffer(void) { KVMState *s =3D kvm_state; =20 - if (s->coalesced_flush_in_progress) { + if (!s || s->coalesced_flush_in_progress) { return; } =20 --=20 2.34.1 From nobody Tue May 21 18:18:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1690813009; cv=none; d=zohomail.com; s=zohoarc; b=c/c9VNhPZ8NMWNOO2POfLk9TiKBJZtfT0FCLrcgzxHfd/doUwsbx+BJWgndi/KghxyyZK6Z6z+ymyVh8oyTg4NyCNcbUefsKE5dVEVfPrquBqYeNjtvmv/0948tGvfYHbclxr0+39Tk2AtUaoO0jfqc/BZndY2AsJ8Iaxdad+Q8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1690813009; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=umPuKK0TP/i1glV8Qojb6FP6t/DJTY4yK7JJ/sINZ5E=; b=PsvEbHx3O9SxncebTlLo53lnkxMTxufHLmb20yXCbMna4IADwDgu2QU/BEPK+2xffAm7NA7hcgXXXuYU3awulqRh0nXW/ODbQC7nWjBwH17iWtMqKjYaRCYFo7d7dP8OyS0T7zprNt3X0WWgN7pPcS3uVKCGo510gO38afresHM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1690813009855296.747839082424; Mon, 31 Jul 2023 07:16:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQTgb-0005al-2s; Mon, 31 Jul 2023 10:15:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQTgT-0005Xy-Tm for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:41 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qQTgR-0007ex-QP for qemu-devel@nongnu.org; Mon, 31 Jul 2023 10:15:41 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fe2048c910so9789235e9.1 for ; Mon, 31 Jul 2023 07:15:39 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id z15-20020a05600c114f00b003fbb5506e54sm11450675wmz.29.2023.07.31.07.15.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 07:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690812938; x=1691417738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=umPuKK0TP/i1glV8Qojb6FP6t/DJTY4yK7JJ/sINZ5E=; b=MFrKBW+iLqvFD3CUTIt8nain8KfYljuJkzxSmKOVH2WaY2eHKUQ/bZBX9g2NqO4BtS vfqZJnerM9oyDYR0uGaMweOhuHoRE9KETpezJxS9yOEDgz6XlJUHGpDS/SNxID04pXfp +R5+CMe1nnV1IHHjeQnuPMjV2NALGZB0wmSdgMpkgu1mBszVXXOE4Yjr2A7dj4qNHQht vPpyzBquqZUn9l86j8j4ugjY/K3ng3KMy6wh6nfKp4O1Hj+TZHuccFzpHG5IxPnIyKU+ TBT6wVsP3q5PrlpS1J8RXPk8VuWJ5ElB6JQCKcSNi/tYKKjGMvww5e0BTNKnoEyffzg7 KUdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690812938; x=1691417738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=umPuKK0TP/i1glV8Qojb6FP6t/DJTY4yK7JJ/sINZ5E=; b=KARH+nFz7diFro5g8565NrS4N2fpo+vUpxxaUZ/P7ZSRSgjtVfrrZxveNGxTjGnxZf HIjn3N7Y5qrpPtSPz+yadldoGRViITg9Hwfxm7iEDLxtE8GNnl/TeMPy+rIPfJypafUF an5Bm9rnjZ9O64ClqIe0MWemM63lNztugqKNV+kv55DrFF2toeVbINX+uZ4OOM1u6Q2n BgbXBo12nGMiW/rdgyCjc8al9ches66/RXmnxCSClqTdYMGFCGPHhK9dWwRFs3tV6NpA Y51ajH46eiUCSJBeOmgS64Kp0fej9H0N1ENRPB6oarTjDc4RGL68LY2UfaC4DL883BC8 NgSQ== X-Gm-Message-State: ABy/qLY+vSr3QraxG9TKC+IneB4cMd/7ucMA9w+Yrj7Qi6zYpLeptcDs ZSFBU3SaKR7j52K7wpEBta8TMWcyedg7ZpWsCwE= X-Google-Smtp-Source: APBJJlGOSesnwnG5ZiYGHKNIwSI6goZcnKQnF/tNx/wE9gsyxL61i+We79zbJocQVsSPs16fKHSt7A== X-Received: by 2002:a05:600c:215:b0:3fe:25b3:951d with SMTP id 21-20020a05600c021500b003fe25b3951dmr77568wmi.5.1690812938053; Mon, 31 Jul 2023 07:15:38 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 6/6] gdbstub: Fix client Ctrl-C handling Date: Mon, 31 Jul 2023 15:15:33 +0100 Message-Id: <20230731141533.3303894-7-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230731141533.3303894-1-peter.maydell@linaro.org> References: <20230731141533.3303894-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1690813011288100003 Content-Type: text/plain; charset="utf-8" From: Nicholas Piggin The gdb remote protocol has a special interrupt character (0x03) that is transmitted outside the regular packet processing, and represents a Ctrl-C pressed in the client. Despite not being a regular packet, it does expect a regular stop response if the stub successfully stops the running program. See: https://sourceware.org/gdb/onlinedocs/gdb/Interrupts.html Inhibiting the stop reply packet can lead to gdb client hang. So permit a stop response when receiving a character from gdb that stops the vm. Additionally, add a warning if that was not a 0x03 character, because the gdb session is likely to end up getting confused if this happens. Cc: qemu-stable@nongnu.org Fixes: 758370052fb ("gdbstub: only send stop-reply packets when allowed to") Reported-by: Frederic Barrat Signed-off-by: Nicholas Piggin Tested-by: Joel Stanley Message-id: 20230711085903.304496-1-npiggin@gmail.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- gdbstub/gdbstub.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 6911b73c079..ce8b42eb159 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -2051,8 +2051,17 @@ void gdb_read_byte(uint8_t ch) return; } if (runstate_is_running()) { - /* when the CPU is running, we cannot do anything except stop - it when receiving a char */ + /* + * When the CPU is running, we cannot do anything except stop + * it when receiving a char. This is expected on a Ctrl-C in the + * gdb client. Because we are in all-stop mode, gdb sends a + * 0x03 byte which is not a usual packet, so we handle it specially + * here, but it does expect a stop reply. + */ + if (ch !=3D 0x03) { + warn_report("gdbstub: client sent packet while target running\= n"); + } + gdbserver_state.allow_stop_reply =3D true; vm_stop(RUN_STATE_PAUSED); } else #endif --=20 2.34.1