[v2] Accompany -nostdlib with -fno-stack-protector

[PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector

Akihiko Odaki posted 2 patches 9 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230731091042.139159-1-akihiko.odaki@daynix.com

Maintainers: Thomas Huth <thuth@redhat.com>, Juan Quintela <quintela@redhat.com>, Peter Xu <peterx@redhat.com>, Leonardo Bras <leobras@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Peter Maydell <peter.maydell@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Brian Cain <bcain@quicinc.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eduardo Habkost <eduardo@habkost.net>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>

tests/tcg/mips/hello-mips.c       | 4 ++--
tests/migration/s390x/Makefile    | 4 ++--
tests/tcg/Makefile.target         | 2 +-
tests/tcg/aarch64/Makefile.target | 2 +-
tests/tcg/arm/Makefile.target     | 2 +-
tests/tcg/cris/Makefile.target    | 2 +-
tests/tcg/hexagon/Makefile.target | 2 +-
tests/tcg/i386/Makefile.target    | 2 +-
tests/tcg/minilib/Makefile.target | 2 +-
tests/tcg/mips/Makefile.target    | 2 +-
10 files changed, 12 insertions(+), 12 deletions(-)

Expand all Fold all

[PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector

Posted by Akihiko Odaki 9 months ago

A build of GCC 13.2 will have stack protector enabled by default if it was
configured with --enable-default-ssp option. For such a compiler, it is
necessary to explicitly disable stack protector when linking without
standard libraries.

This is a tree-wide change to add -fno-stack-protector where -nostdlib is
present.

V1 -> V2:
  Dropped changes for pc-bios as they already had the option. (Thomas Huth)
  Make the change for softmmu tests in a central place. (Thomas Huth)

Akihiko Odaki (2):
  tests/migration: Add -fno-stack-protector
  tests/tcg: Add -fno-stack-protector

 tests/tcg/mips/hello-mips.c       | 4 ++--
 tests/migration/s390x/Makefile    | 4 ++--
 tests/tcg/Makefile.target         | 2 +-
 tests/tcg/aarch64/Makefile.target | 2 +-
 tests/tcg/arm/Makefile.target     | 2 +-
 tests/tcg/cris/Makefile.target    | 2 +-
 tests/tcg/hexagon/Makefile.target | 2 +-
 tests/tcg/i386/Makefile.target    | 2 +-
 tests/tcg/minilib/Makefile.target | 2 +-
 tests/tcg/mips/Makefile.target    | 2 +-
 10 files changed, 12 insertions(+), 12 deletions(-)

-- 
2.41.0

Re: [PATCH v2 0/2] Accompany -nostdlib with -fno-stack-protector

Posted by Michael Tokarev 6 months ago

31.07.2023 12:10, Akihiko Odaki:
> A build of GCC 13.2 will have stack protector enabled by default if it was
> configured with --enable-default-ssp option. For such a compiler, it is
> necessary to explicitly disable stack protector when linking without
> standard libraries.
> 
> This is a tree-wide change to add -fno-stack-protector where -nostdlib is
> present.

Should we perhaps pick this up for -stable too?
The changes seems to be harmless for older compiler and lets to test
qemu with more recent compiler.

/mjt