ui/dbus: fix clang compilation issue

[PATCH] ui/dbus: fix clang compilation issue

Posted by marcandre.lureau@redhat.com 2 years, 6 months ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

../ui/dbus-listener.c:236:9: error: expected expression
        Error *err = NULL;

See:
https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 ui/dbus-listener.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c
index 02fc6ae239..30917271ab 100644
--- a/ui/dbus-listener.c
+++ b/ui/dbus-listener.c
@@ -232,7 +232,7 @@ static void dbus_call_update_gl(DisplayChangeListener *dcl,
         egl_fb_read_rect(ddl->ds, &ddl->fb, x, y, w, h);
         dbus_gfx_update(dcl, x, y, w, h);
         break;
-    case SHARE_KIND_D3DTEX:
+    case SHARE_KIND_D3DTEX: {
         Error *err = NULL;
         assert(ddl->d3d_texture);
 
@@ -249,6 +249,7 @@ static void dbus_call_update_gl(DisplayChangeListener *dcl,
             dbus_update_gl_cb,
             g_object_ref(ddl));
         break;
+    }
     default:
         g_warn_if_reached();
     }
-- 
2.41.0

Re: [PATCH] ui/dbus: fix clang compilation issue

Posted by Philippe Mathieu-Daudé 2 years, 6 months ago

On 26/7/23 17:12, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> ../ui/dbus-listener.c:236:9: error: expected expression
>          Error *err = NULL;
> 
> See:
> https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   ui/dbus-listener.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, queued via misc-fixes.

Re: [PATCH] ui/dbus: fix clang compilation issue

Posted by Philippe Mathieu-Daudé 2 years, 6 months ago

On 26/7/23 17:12, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> ../ui/dbus-listener.c:236:9: error: expected expression
>          Error *err = NULL;
> 
> See:
> https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   ui/dbus-listener.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] ui/dbus: fix clang compilation issue

Posted by Thomas Huth 2 years, 6 months ago

On 26/07/2023 17.12, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> ../ui/dbus-listener.c:236:9: error: expected expression
>          Error *err = NULL;
> 
> See:
> https://gitlab.com/qemu-project/qemu/-/issues/1782#note_1488517427
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   ui/dbus-listener.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c
> index 02fc6ae239..30917271ab 100644
> --- a/ui/dbus-listener.c
> +++ b/ui/dbus-listener.c
> @@ -232,7 +232,7 @@ static void dbus_call_update_gl(DisplayChangeListener *dcl,
>           egl_fb_read_rect(ddl->ds, &ddl->fb, x, y, w, h);
>           dbus_gfx_update(dcl, x, y, w, h);
>           break;
> -    case SHARE_KIND_D3DTEX:
> +    case SHARE_KIND_D3DTEX: {
>           Error *err = NULL;
>           assert(ddl->d3d_texture);
>   
> @@ -249,6 +249,7 @@ static void dbus_call_update_gl(DisplayChangeListener *dcl,
>               dbus_update_gl_cb,
>               g_object_ref(ddl));
>           break;
> +    }
>       default:
>           g_warn_if_reached();
>       }

Reviewed-by: Thomas Huth <thuth@redhat.com>