[v2] target/mips: Avoid shift by negative number in page_table_walk_refill()

[PATCH for-8.1 v2 0/2] target/mips: Avoid shift by negative number in page_table_walk_refill()

Philippe Mathieu-Daudé posted 2 patches 9 months, 2 weeks ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230717213504.24777-1-philmd@linaro.org

Maintainers: "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>

target/mips/tcg/sysemu/tlb_helper.c | 48 ++++++++++++++---------------
1 file changed, 24 insertions(+), 24 deletions(-)

Expand all Fold all

[PATCH for-8.1 v2 0/2] target/mips: Avoid shift by negative number in page_table_walk_refill()

Posted by Philippe Mathieu-Daudé 9 months, 2 weeks ago

This is a respin of Peter's patch, but
- pass already-evaluated values to walk_directory() instead
  of an assert(),
- check 'ptew > 1' instead of directory/leaf_shift == -1,
- use unsigned type

Since v1: walk_directory() doesn't have to rely on the to sanitize
          the input values.

Peter, if you don't see this as an improvement I'll take your original
patch.

Regards,

Phil.

Supersedes: <20230717162940.814078-1-peter.maydell@linaro.org>

Philippe Mathieu-Daudé (2):
  target/mips: Pass directory/leaf shift values to walk_directory()
  target/mips: Avoid shift by negative number in
    page_table_walk_refill()

 target/mips/tcg/sysemu/tlb_helper.c | 48 ++++++++++++++---------------
 1 file changed, 24 insertions(+), 24 deletions(-)

-- 
2.38.1