[v2] Fix PSIHB interrupts init PQ state

[PATCH v2 0/2] Fix PSIHB interrupts init PQ state

Frederic Barrat posted 2 patches 10 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230703081215.55252-1-fbarrat@linux.ibm.com

Maintainers: "Cédric Le Goater" <clg@kaod.org>, "Frédéric Barrat" <fbarrat@linux.ibm.com>, Nicholas Piggin <npiggin@gmail.com>

hw/intc/xive.c        | 8 ++++++--
hw/ppc/pnv_psi.c      | 2 ++
include/hw/ppc/xive.h | 1 +
3 files changed, 9 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH v2 0/2] Fix PSIHB interrupts init PQ state

Posted by Frederic Barrat 10 months ago

On P9 and 10, the real hardware defines the PQ state of the PSIHB
interrupts to be 0b00. Qemu defaults to 0b01.

It doesn't matter to skiboot, which doesn't rely on it and explicitly
masks the interrupts during intialization. But this patch fixes it,
just in case some other hypervisor checks it.

Changelog:
v2: rename property/struct member
    rebase to Daniel's ppc-next branch


Frederic Barrat (2):
  pnv/xive: Add property on xive sources to define PQ state on reset
  pnv/psi: Initialize the PSIHB interrupts to match hardware

 hw/intc/xive.c        | 8 ++++++--
 hw/ppc/pnv_psi.c      | 2 ++
 include/hw/ppc/xive.h | 1 +
 3 files changed, 9 insertions(+), 2 deletions(-)

-- 
2.41.0

Re: [PATCH v2 0/2] Fix PSIHB interrupts init PQ state

Posted by Philippe Mathieu-Daudé 10 months ago

On 3/7/23 10:12, Frederic Barrat wrote:

> Frederic Barrat (2):
>    pnv/xive: Add property on xive sources to define PQ state on reset
>    pnv/psi: Initialize the PSIHB interrupts to match hardware

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH v2 0/2] Fix PSIHB interrupts init PQ state

Posted by Daniel Henrique Barboza 10 months ago

Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,


Daniel

On 7/3/23 05:12, Frederic Barrat wrote:
> On P9 and 10, the real hardware defines the PQ state of the PSIHB
> interrupts to be 0b00. Qemu defaults to 0b01.
> 
> It doesn't matter to skiboot, which doesn't rely on it and explicitly
> masks the interrupts during intialization. But this patch fixes it,
> just in case some other hypervisor checks it.
> 
> Changelog:
> v2: rename property/struct member
>      rebase to Daniel's ppc-next branch
> 
> 
> Frederic Barrat (2):
>    pnv/xive: Add property on xive sources to define PQ state on reset
>    pnv/psi: Initialize the PSIHB interrupts to match hardware
> 
>   hw/intc/xive.c        | 8 ++++++--
>   hw/ppc/pnv_psi.c      | 2 ++
>   include/hw/ppc/xive.h | 1 +
>   3 files changed, 9 insertions(+), 2 deletions(-)
>