[PATCH v3 0/2] pcie: Fix ARI next function numbers

Akihiko Odaki posted 2 patches 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230702120229.66978-1-akihiko.odaki@daynix.com
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Eduardo Habkost <eduardo@habkost.net>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, Akihiko Odaki <akihiko.odaki@daynix.com>, Sriram Yagnaraman <sriram.yagnaraman@est.tech>, Jason Wang <jasowang@redhat.com>, Keith Busch <kbusch@kernel.org>, Klaus Jensen <its@irrelevant.dk>
There is a newer version of this series
docs/pcie_sriov.txt   | 4 ++--
include/hw/pci/pci.h  | 2 ++
include/hw/pci/pcie.h | 2 +-
hw/core/machine.c     | 1 +
hw/net/igb.c          | 2 +-
hw/net/igbvf.c        | 2 +-
hw/nvme/ctrl.c        | 2 +-
hw/pci/pci.c          | 2 ++
hw/pci/pcie.c         | 4 +++-
9 files changed, 14 insertions(+), 7 deletions(-)
[PATCH v3 0/2] pcie: Fix ARI next function numbers
Posted by Akihiko Odaki 10 months ago
The ARI next function number field is undefined for VF. The PF should
end the linked list formed with the field by specifying 0.

Supersedes: <20230701070133.24877-1-akihiko.odaki@daynix.com>
("[PATCH 0/4] pci: Compare function number and ARI next function number")

V2 -> V3:
  Moved the logic to PCI common infrastucture (Michael S. Tsirkin)

V1 -> V2:
  Fixed migration. (Michael S. Tsirkin)
  Added a caveat comment. (Michael S. Tsirkin)

Akihiko Odaki (2):
  pcie: Use common ARI next function number
  pcie: Specify 0 for ARI next function numbers

 docs/pcie_sriov.txt   | 4 ++--
 include/hw/pci/pci.h  | 2 ++
 include/hw/pci/pcie.h | 2 +-
 hw/core/machine.c     | 1 +
 hw/net/igb.c          | 2 +-
 hw/net/igbvf.c        | 2 +-
 hw/nvme/ctrl.c        | 2 +-
 hw/pci/pci.c          | 2 ++
 hw/pci/pcie.c         | 4 +++-
 9 files changed, 14 insertions(+), 7 deletions(-)

-- 
2.41.0
Re: [PATCH v3 0/2] pcie: Fix ARI next function numbers
Posted by Michael S. Tsirkin 10 months ago
On Sun, Jul 02, 2023 at 09:02:25PM +0900, Akihiko Odaki wrote:
> The ARI next function number field is undefined for VF. The PF should
> end the linked list formed with the field by specifying 0.
> 
> Supersedes: <20230701070133.24877-1-akihiko.odaki@daynix.com>
> ("[PATCH 0/4] pci: Compare function number and ARI next function number")

Thanks! How was this patch tested?


> V2 -> V3:
>   Moved the logic to PCI common infrastucture (Michael S. Tsirkin)
> 
> V1 -> V2:
>   Fixed migration. (Michael S. Tsirkin)
>   Added a caveat comment. (Michael S. Tsirkin)
> 
> Akihiko Odaki (2):
>   pcie: Use common ARI next function number
>   pcie: Specify 0 for ARI next function numbers
> 
>  docs/pcie_sriov.txt   | 4 ++--
>  include/hw/pci/pci.h  | 2 ++
>  include/hw/pci/pcie.h | 2 +-
>  hw/core/machine.c     | 1 +
>  hw/net/igb.c          | 2 +-
>  hw/net/igbvf.c        | 2 +-
>  hw/nvme/ctrl.c        | 2 +-
>  hw/pci/pci.c          | 2 ++
>  hw/pci/pcie.c         | 4 +++-
>  9 files changed, 14 insertions(+), 7 deletions(-)
> 
> -- 
> 2.41.0
Re: [PATCH v3 0/2] pcie: Fix ARI next function numbers
Posted by Akihiko Odaki 10 months ago
On 2023/07/02 21:43, Michael S. Tsirkin wrote:
> On Sun, Jul 02, 2023 at 09:02:25PM +0900, Akihiko Odaki wrote:
>> The ARI next function number field is undefined for VF. The PF should
>> end the linked list formed with the field by specifying 0.
>>
>> Supersedes: <20230701070133.24877-1-akihiko.odaki@daynix.com>
>> ("[PATCH 0/4] pci: Compare function number and ARI next function number")
> 
> Thanks! How was this patch tested?

I brought VFs up with igb and performed link up for a fresh VM and a VM 
migrated from 8.0.2.

> 
> 
>> V2 -> V3:
>>    Moved the logic to PCI common infrastucture (Michael S. Tsirkin)
>>
>> V1 -> V2:
>>    Fixed migration. (Michael S. Tsirkin)
>>    Added a caveat comment. (Michael S. Tsirkin)
>>
>> Akihiko Odaki (2):
>>    pcie: Use common ARI next function number
>>    pcie: Specify 0 for ARI next function numbers
>>
>>   docs/pcie_sriov.txt   | 4 ++--
>>   include/hw/pci/pci.h  | 2 ++
>>   include/hw/pci/pcie.h | 2 +-
>>   hw/core/machine.c     | 1 +
>>   hw/net/igb.c          | 2 +-
>>   hw/net/igbvf.c        | 2 +-
>>   hw/nvme/ctrl.c        | 2 +-
>>   hw/pci/pci.c          | 2 ++
>>   hw/pci/pcie.c         | 4 +++-
>>   9 files changed, 14 insertions(+), 7 deletions(-)
>>
>> -- 
>> 2.41.0
>
Re: [PATCH v3 0/2] pcie: Fix ARI next function numbers
Posted by Michael S. Tsirkin 10 months ago
On Mon, Jul 03, 2023 at 12:17:16PM +0900, Akihiko Odaki wrote:
> On 2023/07/02 21:43, Michael S. Tsirkin wrote:
> > On Sun, Jul 02, 2023 at 09:02:25PM +0900, Akihiko Odaki wrote:
> > > The ARI next function number field is undefined for VF. The PF should
> > > end the linked list formed with the field by specifying 0.
> > > 
> > > Supersedes: <20230701070133.24877-1-akihiko.odaki@daynix.com>
> > > ("[PATCH 0/4] pci: Compare function number and ARI next function number")
> > 
> > Thanks! How was this patch tested?
> 
> I brought VFs up with igb and performed link up for a fresh VM and a VM
> migrated from 8.0.2.

Which guest?

> > 
> > 
> > > V2 -> V3:
> > >    Moved the logic to PCI common infrastucture (Michael S. Tsirkin)
> > > 
> > > V1 -> V2:
> > >    Fixed migration. (Michael S. Tsirkin)
> > >    Added a caveat comment. (Michael S. Tsirkin)
> > > 
> > > Akihiko Odaki (2):
> > >    pcie: Use common ARI next function number
> > >    pcie: Specify 0 for ARI next function numbers
> > > 
> > >   docs/pcie_sriov.txt   | 4 ++--
> > >   include/hw/pci/pci.h  | 2 ++
> > >   include/hw/pci/pcie.h | 2 +-
> > >   hw/core/machine.c     | 1 +
> > >   hw/net/igb.c          | 2 +-
> > >   hw/net/igbvf.c        | 2 +-
> > >   hw/nvme/ctrl.c        | 2 +-
> > >   hw/pci/pci.c          | 2 ++
> > >   hw/pci/pcie.c         | 4 +++-
> > >   9 files changed, 14 insertions(+), 7 deletions(-)
> > > 
> > > -- 
> > > 2.41.0
> >
Re: [PATCH v3 0/2] pcie: Fix ARI next function numbers
Posted by Akihiko Odaki 10 months ago
On 2023/07/03 13:52, Michael S. Tsirkin wrote:
> On Mon, Jul 03, 2023 at 12:17:16PM +0900, Akihiko Odaki wrote:
>> On 2023/07/02 21:43, Michael S. Tsirkin wrote:
>>> On Sun, Jul 02, 2023 at 09:02:25PM +0900, Akihiko Odaki wrote:
>>>> The ARI next function number field is undefined for VF. The PF should
>>>> end the linked list formed with the field by specifying 0.
>>>>
>>>> Supersedes: <20230701070133.24877-1-akihiko.odaki@daynix.com>
>>>> ("[PATCH 0/4] pci: Compare function number and ARI next function number")
>>>
>>> Thanks! How was this patch tested?
>>
>> I brought VFs up with igb and performed link up for a fresh VM and a VM
>> migrated from 8.0.2.
> 
> Which guest?

I use Fedora 38.

> 
>>>
>>>
>>>> V2 -> V3:
>>>>     Moved the logic to PCI common infrastucture (Michael S. Tsirkin)
>>>>
>>>> V1 -> V2:
>>>>     Fixed migration. (Michael S. Tsirkin)
>>>>     Added a caveat comment. (Michael S. Tsirkin)
>>>>
>>>> Akihiko Odaki (2):
>>>>     pcie: Use common ARI next function number
>>>>     pcie: Specify 0 for ARI next function numbers
>>>>
>>>>    docs/pcie_sriov.txt   | 4 ++--
>>>>    include/hw/pci/pci.h  | 2 ++
>>>>    include/hw/pci/pcie.h | 2 +-
>>>>    hw/core/machine.c     | 1 +
>>>>    hw/net/igb.c          | 2 +-
>>>>    hw/net/igbvf.c        | 2 +-
>>>>    hw/nvme/ctrl.c        | 2 +-
>>>>    hw/pci/pci.c          | 2 ++
>>>>    hw/pci/pcie.c         | 4 +++-
>>>>    9 files changed, 14 insertions(+), 7 deletions(-)
>>>>
>>>> -- 
>>>> 2.41.0
>>>
>