From nobody Tue May 14 08:09:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1688286925; cv=none; d=zohomail.com; s=zohoarc; b=TQgABf1i9s9irNkG3Dy0v/ZJnHGFxEzV9+jrphjMFD/TO4i7WntHptvbOer89qK8KP1LB5aMv+VhQO6hMoVNeUR1ANrVmmrF1WeLs/SSDq8FIwwjeXLlRpqSl6+2LXNysYPmVXHgaUf90HSuY0GU4408x0RFE1IfG1vUXjdl8Sg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688286925; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=IJPRtuvbHAsqaGR1Ln6VUbGyabvHfWSFqdv+KVApqEU=; b=FMZb8TWg0Z6dPIbBhyow/8eoBRf+z8jkL/A1D46GaFk7KXxAf5rsoxj0iptE618jyF2RzqSdnS8utnK1LJYXS4wTSUVg+0W5TkALR9sSsVkXZ/4ZxDQIODZ9PH/4d39YDk2Mwgzm2XAPnarvR0/ci1kpGMFt729585DDHefDYjA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1688286925556342.35890554032335; Sun, 2 Jul 2023 01:35:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFsXJ-00088Y-Go; Sun, 02 Jul 2023 04:34:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFsXG-00087B-UU for qemu-devel@nongnu.org; Sun, 02 Jul 2023 04:34:22 -0400 Received: from mail-pg1-x52e.google.com ([2607:f8b0:4864:20::52e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFsXF-0003Cq-Hs for qemu-devel@nongnu.org; Sun, 02 Jul 2023 04:34:22 -0400 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-55b66ce047cso832308a12.0 for ; Sun, 02 Jul 2023 01:34:20 -0700 (PDT) Received: from alarm.. ([157.82.204.253]) by smtp.gmail.com with ESMTPSA id 18-20020a17090a199200b0024df6bbf5d8sm7563069pji.30.2023.07.02.01.34.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jul 2023 01:34:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20221208.gappssmtp.com; s=20221208; t=1688286859; x=1690878859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IJPRtuvbHAsqaGR1Ln6VUbGyabvHfWSFqdv+KVApqEU=; b=kwGb58lJyVFoIe+PC3fQV85nt/5xaJD+hS7MVGPS5jYzqu/bXWSsXc9tzShwpIMK7J DxWQqyCUUw6HiAxVR6BxgrksTp1ogMqYuhPbpd2b9tytBO3e7eFnjDDh2N0Mm8uiyqRo JIS3L1MjaAgjFd2QhpNyiBvo0iXXhj1Z3WWOiRqMJgMdFeR1U44iOLgwtUuzf+5NB0Pr qDI/6Jx/UuobTJEeMDw3ETivZZoDlXKvttd22BwPssWooV5CLicDlDyhaxypwCgDK4j3 verYM6HKIPj5ePFd+cgu+WC6gg1a6odNy4yqUuklzLTkUqsE67l+2YWOpS0b4/cMBnE7 Iwpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688286859; x=1690878859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IJPRtuvbHAsqaGR1Ln6VUbGyabvHfWSFqdv+KVApqEU=; b=DGw8q4m3IID8hgeLgq1xdLxKdclfHbx7srWowDBxVV/IgGTX7vUpe+RDDPZrzlX2t/ hhSR5Ggh+um2Dsx0P7aSwwatMVI1kdUvyTCxl1an+Em8F6p+xPRq2XX3Pz1McGQHpLeF +BhBgw6SBquFPg34Hc/0kuzP8w1zFB/973M7wv+kNzbfvsEOgyJnoEYrqBtFZ/1E47Zg okw4GVUudpAWz5nf42QCbPh/mAl/0UiIAKV5KTdhb1NNkxSZTa29q6YIGgyLd81LiOgH 8UqCUQ3jA7yDDCIRX04dj+XUX45wiWYqZIjoPFzCPJgEvRmc1r0B1zOnpHmTjLzs8kSz hB8Q== X-Gm-Message-State: ABy/qLaysS6ufw3e7QGFKoJ64z+hUrRrwd0qbgRmtDrdQ4ovbu1iDBVa Y5qeGnVNB64PnMBLx0j6ox6SJUAbcvhHf/IiQFM= X-Google-Smtp-Source: APBJJlEaiDosFIWzDPlQsZcO/eVn6YZJpdWp96r3cojnhf/LdRGZDhmYjqitE9mzB6l/zQImoYh86A== X-Received: by 2002:a17:90a:35b:b0:263:7d4a:4d43 with SMTP id 27-20020a17090a035b00b002637d4a4d43mr5171005pjf.1.1688286859631; Sun, 02 Jul 2023 01:34:19 -0700 (PDT) From: Akihiko Odaki To: Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Ani Sinha , "Michael S . Tsirkin" , Marcel Apfelbaum , Sriram Yagnaraman , Jason Wang , Keith Busch , Klaus Jensen , Akihiko Odaki Subject: [PATCH 1/3] docs: Fix next function numbers in SR/IOV documentation Date: Sun, 2 Jul 2023 17:33:54 +0900 Message-ID: <20230702083357.13517-2-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230702083357.13517-1-akihiko.odaki@daynix.com> References: <20230702083357.13517-1-akihiko.odaki@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::52e; envelope-from=akihiko.odaki@daynix.com; helo=mail-pg1-x52e.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20221208.gappssmtp.com) X-ZM-MESSAGEID: 1688286928070100003 Content-Type: text/plain; charset="utf-8" The ARI next function number field is undefined for VF so the PF should end the linked list formed with the field by specifying 0. This also changes the value of the field for VF; it seems to imply the value has some meaning if it differs from one of the PF, but it doesn't. Fixes: 2503461691 ("pcie: Add some SR/IOV API documentation in docs/pcie_sr= iov.txt") Signed-off-by: Akihiko Odaki --- docs/pcie_sriov.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/pcie_sriov.txt b/docs/pcie_sriov.txt index 7eff7f2703..2b7094dc47 100644 --- a/docs/pcie_sriov.txt +++ b/docs/pcie_sriov.txt @@ -48,7 +48,7 @@ setting up a BAR for a VF. ... int ret =3D pcie_endpoint_cap_init(d, 0x70); ... - pcie_ari_init(d, 0x100, 1); + pcie_ari_init(d, 0x100, 0); ... =20 /* Add and initialize the SR/IOV capability */ @@ -78,7 +78,7 @@ setting up a BAR for a VF. ... int ret =3D pcie_endpoint_cap_init(d, 0x60); ... - pcie_ari_init(d, 0x100, 1); + pcie_ari_init(d, 0x100, 0); ... memory_region_init(mr, ... ) pcie_sriov_vf_register_bar(d, bar_nr, mr); --=20 2.41.0 From nobody Tue May 14 08:09:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1688286936; cv=none; d=zohomail.com; s=zohoarc; b=GcFlNcrjJbQW4z8GXbL9tbwdw5+vr3qCscoCygiIs5vj031qxoXtXJGHmEvgEXD7wOyxcFGfZumuoucjYfKYiWeXzlsvIKBv8bLzYVnTIUt3nEVjOhipB0Ce+bgltrNuAsxthIk4S0AM+tIgziDevjU8lCcfkmEpPiBXfuJsL74= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688286936; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=Gwdt3uLuET3nmTG8rKh0TOme/CSaHT7BuAOTDi2xTjU=; b=L0P6Ym2gobzq665nznWPCpSif6sv96a94YPR3dotXn8ljcO3j7yYN/Wmila4QsgDnSLBm1E5lLwS7Z/5y71ldtIIGLBNqGbVXzt3ncl9LNNb5D3+9BlZZzy6Aj6Beu/HJG5wpGBQbuwvzF7JhYmjPYdM7wkJ5zgGXShLiuxwAwo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1688286936572412.8553853516612; Sun, 2 Jul 2023 01:35:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFsXL-000896-9V; Sun, 02 Jul 2023 04:34:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFsXJ-00088V-Bs for qemu-devel@nongnu.org; Sun, 02 Jul 2023 04:34:25 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFsXH-0003DJ-Rz for qemu-devel@nongnu.org; Sun, 02 Jul 2023 04:34:25 -0400 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1b82bf265b2so15112935ad.0 for ; Sun, 02 Jul 2023 01:34:23 -0700 (PDT) Received: from alarm.. ([157.82.204.253]) by smtp.gmail.com with ESMTPSA id 18-20020a17090a199200b0024df6bbf5d8sm7563069pji.30.2023.07.02.01.34.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jul 2023 01:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20221208.gappssmtp.com; s=20221208; t=1688286862; x=1690878862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gwdt3uLuET3nmTG8rKh0TOme/CSaHT7BuAOTDi2xTjU=; b=4HfhOTFwo4ZQgObFVXb4DcQKtcYSW2ZP64gsVPFdgK+h6h3KNrxKgica+cEJbZ3hXw LrILMWBNYnIK3i7ga3H66ne50QsgA7jMTmfFnfz7j3e/SknhQ68shADA90i/pd+uG883 oM+WJxKd4P1VWvxsk7v2PYZmRthe0TTCuqQrlCg4A8zQz4xzaGKNNME8gb16Wv/0wftF zY1rko79fzPqMUz5A1kdX/6uNYBZ/mmKp0IZePN+E/uGCeRiqzhvdcEdeRXA9CpTesE7 UTd5BKclic8vYpx3xqj+qZtlC4u5RCYzOAkFLmMXIiEycRncSjcqlrSw/iRxe1yD9w/E mtMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688286862; x=1690878862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gwdt3uLuET3nmTG8rKh0TOme/CSaHT7BuAOTDi2xTjU=; b=aJoekhdvzls1qtXreB8xyG25nYKOa8GcwiEkJjsy2/R/JgC0jqdOtdpxTUR1EW6L6B Wxae7eIwbDSKDGgZo17Kb/KSllvn7IAN6GYqzvOE1anYbSpIbkMoNT6rtlFbnFfA4OSg PDL6e3JzHAc453AVN6n/1El9oZwW8YbZK4s0I8BAu5HrWFa8ucSjcdwHboTrGRdMLI9I nGn7VodkXXp3t4WAfhCIoXC3le0iwwcG+v4qgJZexnLzNdKLBNXd2uMqLYJr/G0Bi/7i GVewm1N7xMxjQBLloKGCMEpb726Vw/rXXfM9d5IlICn3Sm4X3HT6hz+AAykWUhW6dVWc FTQA== X-Gm-Message-State: ABy/qLYpJJldc05AZZBGJD001bb6tLNhRf+IFizU3yWLur5G2ndrDMLs C4/32+t33cfl+1t6gMGgi1Lakha8hS2QVI2p/D4= X-Google-Smtp-Source: APBJJlG2da6S6HV896Ykkfh8xV524Sgf6JAYxpJLQThDAOvKC2WuvMv5udGJ46cKEOFjCm0t+XmA6Q== X-Received: by 2002:a17:90a:1a13:b0:263:53be:5120 with SMTP id 19-20020a17090a1a1300b0026353be5120mr5804162pjk.36.1688286862352; Sun, 02 Jul 2023 01:34:22 -0700 (PDT) From: Akihiko Odaki To: Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Ani Sinha , "Michael S . Tsirkin" , Marcel Apfelbaum , Sriram Yagnaraman , Jason Wang , Keith Busch , Klaus Jensen , Akihiko Odaki Subject: [PATCH 2/3] hw/nvme: Fix ARI next function numbers Date: Sun, 2 Jul 2023 17:33:55 +0900 Message-ID: <20230702083357.13517-3-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230702083357.13517-1-akihiko.odaki@daynix.com> References: <20230702083357.13517-1-akihiko.odaki@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::631; envelope-from=akihiko.odaki@daynix.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20221208.gappssmtp.com) X-ZM-MESSAGEID: 1688286938744100001 Content-Type: text/plain; charset="utf-8" The ARI next function number field is undefined for VF. The PF should end the linked list formed with the field by specifying 0. Fixes: 44c2c09488 ("hw/nvme: Add support for SR-IOV") Signed-off-by: Akihiko Odaki --- hw/nvme/ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index fd917fcda1..6c4809b4f6 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -8088,7 +8088,7 @@ static bool nvme_init_pci(NvmeCtrl *n, PCIDevice *pci= _dev, Error **errp) pcie_endpoint_cap_init(pci_dev, 0x80); pcie_cap_flr_init(pci_dev); if (n->params.sriov_max_vfs) { - pcie_ari_init(pci_dev, 0x100, 1); + pcie_ari_init(pci_dev, 0x100, 0); } =20 /* add one to max_ioqpairs to account for the admin queue pair */ --=20 2.41.0 From nobody Tue May 14 08:09:38 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1688286938; cv=none; d=zohomail.com; s=zohoarc; b=UNeu9MMSzhPDUMDCpndOlDwAEntbbIT+Mb3h4OLRzHSd7nrUoswYp1+vrkhEOGS3pJnM9JQDAJCM/ao2nKHKF5Gc5dqQthA10Q2dZfiW9lnjBh/rOODrZb1Y7ex5KhXhb+hfVz7iXOdf2c8I6fkx4kb9jQJFhp67P9B2KBywAUU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688286938; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=y2Kmn54G8CgD57l6cpTCJUxI9DmtqSXfkmBYJ/UOAX8=; b=gNPB8tTFpX6k6HvDMx96ttqyB/aZKSDGfYH5YxXOTAW8Fc5OwA73P3A8d3LLrE8VLPivb2zllgzzrvy+A4MePQjNPjhYByNJaFts9UNGAazNfLrEQweYeumMGF2lC0uwuv6G05QcvepdrcXgy2WVVy8pkZ7bQTKsHIs/YyK7XuA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1688286938924534.5101091925818; Sun, 2 Jul 2023 01:35:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qFsXQ-00089l-Rr; Sun, 02 Jul 2023 04:34:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFsXM-00089U-44 for qemu-devel@nongnu.org; Sun, 02 Jul 2023 04:34:28 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFsXK-0003Dl-I5 for qemu-devel@nongnu.org; Sun, 02 Jul 2023 04:34:27 -0400 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-263121cd04eso1565363a91.2 for ; Sun, 02 Jul 2023 01:34:26 -0700 (PDT) Received: from alarm.. ([157.82.204.253]) by smtp.gmail.com with ESMTPSA id 18-20020a17090a199200b0024df6bbf5d8sm7563069pji.30.2023.07.02.01.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jul 2023 01:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20221208.gappssmtp.com; s=20221208; t=1688286865; x=1690878865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y2Kmn54G8CgD57l6cpTCJUxI9DmtqSXfkmBYJ/UOAX8=; b=YUZesAEJ08QJjT6nQzrATbGdOK6TCRz+UDIPvWwTpvs7jmHYi+/YRpnJ9GY96NbfEk o+wYIdvVFtmkCDS7oOuNSbmL9rYJ/y1bfjXk6C6chVcelKImSfssKMuln66Zwk9Jmwcq xGkYjpB8ArjRREXTEWf78QxZqQjDKgHxtpU3gN8sJVKZhhXVtJVh2Z0STXOKK3th2bCa Svzs7gU5FykGr+wyPwz1678iz/OpoZ0O60hUuV+kamgol1xKDrw4zft0evgXfJSKnWfh ZzPaE6jCp3pb0JYQJWv/EYghoug7eY2lgU1Yz8v0rAFSz17LEn/6KHNvcJHzl3Z1j1hQ EVMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688286865; x=1690878865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y2Kmn54G8CgD57l6cpTCJUxI9DmtqSXfkmBYJ/UOAX8=; b=iGUefOR3MdAZvWoaaLmXXqH7BHsUCA/V6bDey2v+E58qOesa4IYxFtpvsZFiwDcc9x Y95gVQMZg4Qn2PrGk/DPXtRcCiOiqfySiMMd/CjYFOKKxYGPbwwKOi14siDUyQ1ffHI5 6hgBHar0sbAiQxSFi/0pxipfge0rOU5Zq8Cq6W+gqkS85Q5Mxjlzk5ZPYjovkgAJk8LS 6HVh2pkFr2bRoHQzOIosF/V3uMOFEPy/bu9zKTh0hUGoqjlHSqPFjUJ1Q1lxqP+40ad1 Tkw60aIqC7//2eyJiKK6OdKko9KtTD9V5WbrTk5sIOlEEmlsVkFe83X+JNkj26b2OH8k 8AwQ== X-Gm-Message-State: ABy/qLYJp25nHy3jNu+HsNKZ4zoDks50KVShlc7A+qUjIYoHITsWiC9A VvTf8NiEtxdVQP6iGAywekrOaPbk1Cd9UExcif4= X-Google-Smtp-Source: APBJJlHws5qK73MRnuIYCngC34IjnfJDAEcp6l7SSRiuP654rCnMt77ExtzpKgyyNgVkEGExYAaE4A== X-Received: by 2002:a17:90a:c696:b0:263:33a9:9aed with SMTP id n22-20020a17090ac69600b0026333a99aedmr5518879pjt.24.1688286865013; Sun, 02 Jul 2023 01:34:25 -0700 (PDT) From: Akihiko Odaki To: Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Ani Sinha , "Michael S . Tsirkin" , Marcel Apfelbaum , Sriram Yagnaraman , Jason Wang , Keith Busch , Klaus Jensen , Akihiko Odaki Subject: [PATCH 3/3] igb: Fix ARI next function numbers Date: Sun, 2 Jul 2023 17:33:56 +0900 Message-ID: <20230702083357.13517-4-akihiko.odaki@daynix.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230702083357.13517-1-akihiko.odaki@daynix.com> References: <20230702083357.13517-1-akihiko.odaki@daynix.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=2607:f8b0:4864:20::1032; envelope-from=akihiko.odaki@daynix.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @daynix-com.20221208.gappssmtp.com) X-ZM-MESSAGEID: 1688286939440100005 Content-Type: text/plain; charset="utf-8" The ARI next function number field is undefined for VF so the PF should end the linked list formed with the field by specifying 0. Fixes: 3a977deebe ("Intrdocue igb device emulation") Signed-off-by: Akihiko Odaki --- hw/net/igb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/igb.c b/hw/net/igb.c index 1c989d7677..897386fc09 100644 --- a/hw/net/igb.c +++ b/hw/net/igb.c @@ -431,7 +431,7 @@ static void igb_pci_realize(PCIDevice *pci_dev, Error *= *errp) hw_error("Failed to initialize AER capability"); } =20 - pcie_ari_init(pci_dev, 0x150, 1); + pcie_ari_init(pci_dev, 0x150, 0); =20 pcie_sriov_pf_init(pci_dev, IGB_CAP_SRIOV_OFFSET, TYPE_IGBVF, IGB_82576_VF_DEV_ID, IGB_MAX_VF_FUNCTIONS, IGB_MAX_VF_FUNCTIONS, --=20 2.41.0