[PATCH v16 0/9] TCG code quality tracking

Fei Wu posted 9 patches 10 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230628120430.73777-1-fei2.wu@intel.com
Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Dr. David Alan Gilbert" <dave@treblig.org>, Laurent Vivier <laurent@vivier.eu>
There is a newer version of this series
MAINTAINERS                      |   1 +
accel/tcg/cpu-exec.c             |   6 +
accel/tcg/meson.build            |   1 +
accel/tcg/monitor.c              | 216 ++++++++++++++++++
accel/tcg/tb-context.h           |   1 +
accel/tcg/tb-hash.h              |   7 +
accel/tcg/tb-maint.c             |  20 ++
accel/tcg/tb-stats.c             | 366 +++++++++++++++++++++++++++++++
accel/tcg/tcg-runtime.c          |   1 +
accel/tcg/translate-all.c        |  77 ++++++-
accel/tcg/translator.c           |  31 +++
disas/disas-mon.c                |  15 +-
disas/disas.c                    |   2 +
docs/devel/index-tcg.rst         |   1 +
docs/devel/tcg-tbstats.rst       | 126 +++++++++++
hmp-commands-info.hx             |  16 ++
hmp-commands.hx                  |  16 ++
include/disas/disas.h            |   8 +-
include/exec/tb-stats-dump.h     |  21 ++
include/exec/tb-stats-flags.h    |  29 +++
include/exec/tb-stats.h          | 130 +++++++++++
include/exec/translation-block.h |   3 +
include/monitor/hmp.h            |   3 +
include/qemu/log.h               |   1 +
include/tcg/tcg-temp-internal.h  |   2 +
include/tcg/tcg.h                |  10 +
linux-user/exit.c                |   2 +
monitor/hmp-cmds-target.c        |   3 +-
softmmu/runstate.c               |   2 +
stubs/meson.build                |   1 +
stubs/tb-stats.c                 |  36 +++
tcg/tcg.c                        |  47 +++-
util/log.c                       |  26 +++
33 files changed, 1217 insertions(+), 10 deletions(-)
create mode 100644 accel/tcg/tb-stats.c
create mode 100644 docs/devel/tcg-tbstats.rst
create mode 100644 include/exec/tb-stats-dump.h
create mode 100644 include/exec/tb-stats-flags.h
create mode 100644 include/exec/tb-stats.h
create mode 100644 stubs/tb-stats.c
[PATCH v16 0/9] TCG code quality tracking
Posted by Fei Wu 10 months, 3 weeks ago
v16
--
* rebase to latest commit 4329d049d (Jun 26)
* original patch 1 (remove CONFIG_PROFILER) has already upstreamed so is
  removed from here
* add async_safe_run_on_cpu back for info tb-list/tb
* add ram_addr support to monitor_disas and use it to disassemble guest code
* update the commit logs and documents
* small change to do_hmp_tbstats_safe() to avoid memory leaking


Alex Bennée (1):
  tb-stats: reset the tracked TBs on a tb_flush

Fei Wu (4):
  accel/tcg: add jit stats to TBStatistics
  debug: add -d tb_stats to control TBStatistics
  tb-stats: dump hot TBs at the end of the execution
  docs: add tb-stats how to

Vanderson M. do Rosario (4):
  accel/tcg: introduce TBStatistics structure
  accel: collecting TB execution count
  monitor: adding tb_stats hmp command
  tb-stats: Adding info [tb-list|tb] commands to HMP

 MAINTAINERS                      |   1 +
 accel/tcg/cpu-exec.c             |   6 +
 accel/tcg/meson.build            |   1 +
 accel/tcg/monitor.c              | 216 ++++++++++++++++++
 accel/tcg/tb-context.h           |   1 +
 accel/tcg/tb-hash.h              |   7 +
 accel/tcg/tb-maint.c             |  20 ++
 accel/tcg/tb-stats.c             | 366 +++++++++++++++++++++++++++++++
 accel/tcg/tcg-runtime.c          |   1 +
 accel/tcg/translate-all.c        |  77 ++++++-
 accel/tcg/translator.c           |  31 +++
 disas/disas-mon.c                |  15 +-
 disas/disas.c                    |   2 +
 docs/devel/index-tcg.rst         |   1 +
 docs/devel/tcg-tbstats.rst       | 126 +++++++++++
 hmp-commands-info.hx             |  16 ++
 hmp-commands.hx                  |  16 ++
 include/disas/disas.h            |   8 +-
 include/exec/tb-stats-dump.h     |  21 ++
 include/exec/tb-stats-flags.h    |  29 +++
 include/exec/tb-stats.h          | 130 +++++++++++
 include/exec/translation-block.h |   3 +
 include/monitor/hmp.h            |   3 +
 include/qemu/log.h               |   1 +
 include/tcg/tcg-temp-internal.h  |   2 +
 include/tcg/tcg.h                |  10 +
 linux-user/exit.c                |   2 +
 monitor/hmp-cmds-target.c        |   3 +-
 softmmu/runstate.c               |   2 +
 stubs/meson.build                |   1 +
 stubs/tb-stats.c                 |  36 +++
 tcg/tcg.c                        |  47 +++-
 util/log.c                       |  26 +++
 33 files changed, 1217 insertions(+), 10 deletions(-)
 create mode 100644 accel/tcg/tb-stats.c
 create mode 100644 docs/devel/tcg-tbstats.rst
 create mode 100644 include/exec/tb-stats-dump.h
 create mode 100644 include/exec/tb-stats-flags.h
 create mode 100644 include/exec/tb-stats.h
 create mode 100644 stubs/tb-stats.c

-- 
2.25.1


Re: [PATCH v16 0/9] TCG code quality tracking
Posted by Wu, Fei 10 months, 2 weeks ago
On 6/28/2023 8:04 PM, Fei Wu wrote:
> v16
> --
> * rebase to latest commit 4329d049d (Jun 26)
> * original patch 1 (remove CONFIG_PROFILER) has already upstreamed so is
>   removed from here

Hi Richard,

As CONFIG_PROFILER has been removed in upstream, could you please take a
look again at this revision?

Thanks,
Fei.

> * add async_safe_run_on_cpu back for info tb-list/tb
> * add ram_addr support to monitor_disas and use it to disassemble guest code
> * update the commit logs and documents
> * small change to do_hmp_tbstats_safe() to avoid memory leaking
> 
> 
> Alex Bennée (1):
>   tb-stats: reset the tracked TBs on a tb_flush
> 
> Fei Wu (4):
>   accel/tcg: add jit stats to TBStatistics
>   debug: add -d tb_stats to control TBStatistics
>   tb-stats: dump hot TBs at the end of the execution
>   docs: add tb-stats how to
> 
> Vanderson M. do Rosario (4):
>   accel/tcg: introduce TBStatistics structure
>   accel: collecting TB execution count
>   monitor: adding tb_stats hmp command
>   tb-stats: Adding info [tb-list|tb] commands to HMP
> 
>  MAINTAINERS                      |   1 +
>  accel/tcg/cpu-exec.c             |   6 +
>  accel/tcg/meson.build            |   1 +
>  accel/tcg/monitor.c              | 216 ++++++++++++++++++
>  accel/tcg/tb-context.h           |   1 +
>  accel/tcg/tb-hash.h              |   7 +
>  accel/tcg/tb-maint.c             |  20 ++
>  accel/tcg/tb-stats.c             | 366 +++++++++++++++++++++++++++++++
>  accel/tcg/tcg-runtime.c          |   1 +
>  accel/tcg/translate-all.c        |  77 ++++++-
>  accel/tcg/translator.c           |  31 +++
>  disas/disas-mon.c                |  15 +-
>  disas/disas.c                    |   2 +
>  docs/devel/index-tcg.rst         |   1 +
>  docs/devel/tcg-tbstats.rst       | 126 +++++++++++
>  hmp-commands-info.hx             |  16 ++
>  hmp-commands.hx                  |  16 ++
>  include/disas/disas.h            |   8 +-
>  include/exec/tb-stats-dump.h     |  21 ++
>  include/exec/tb-stats-flags.h    |  29 +++
>  include/exec/tb-stats.h          | 130 +++++++++++
>  include/exec/translation-block.h |   3 +
>  include/monitor/hmp.h            |   3 +
>  include/qemu/log.h               |   1 +
>  include/tcg/tcg-temp-internal.h  |   2 +
>  include/tcg/tcg.h                |  10 +
>  linux-user/exit.c                |   2 +
>  monitor/hmp-cmds-target.c        |   3 +-
>  softmmu/runstate.c               |   2 +
>  stubs/meson.build                |   1 +
>  stubs/tb-stats.c                 |  36 +++
>  tcg/tcg.c                        |  47 +++-
>  util/log.c                       |  26 +++
>  33 files changed, 1217 insertions(+), 10 deletions(-)
>  create mode 100644 accel/tcg/tb-stats.c
>  create mode 100644 docs/devel/tcg-tbstats.rst
>  create mode 100644 include/exec/tb-stats-dump.h
>  create mode 100644 include/exec/tb-stats-flags.h
>  create mode 100644 include/exec/tb-stats.h
>  create mode 100644 stubs/tb-stats.c
>