[v2] hw: Fix format for comments

[PATCH v2] hw: Fix format for comments

Shaoqin Huang posted 1 patch 10 months, 2 weeks ago

Diff against v1 v1
Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230619123404.831803-1-shahuang@redhat.com

Maintainers: Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>

include/hw/boards.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH v2] hw: Fix format for comments

Posted by Shaoqin Huang 10 months, 2 weeks ago

Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments. Whlie
at it, reorder the parameters in comments to match the sequence of
parameters which defined in the CPUArchId.

Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Shaoqin Huang <shahuang@redhat.com>
---
 include/hw/boards.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/hw/boards.h b/include/hw/boards.h
index a385010909..e0497c2314 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -101,10 +101,10 @@ MemoryRegion *machine_consume_memdev(MachineState *machine,
 /**
  * CPUArchId:
  * @arch_id - architecture-dependent CPU ID of present or possible CPU
+ * @vcpus_count - number of threads provided by @cpu object
+ * @props - CPU object properties, initialized by board
  * @cpu - pointer to corresponding CPU object if it's present on NULL otherwise
  * @type - QOM class name of possible @cpu object
- * @props - CPU object properties, initialized by board
- * #vcpus_count - number of threads provided by @cpu object
  */
 typedef struct CPUArchId {
     uint64_t arch_id;
-- 
2.39.1

Re: [PATCH v2] hw: Fix format for comments

Posted by Peter Xu 10 months, 2 weeks ago

On Mon, Jun 19, 2023 at 08:34:04AM -0400, Shaoqin Huang wrote:
> Simply fix the #vcpus_count to @vcpus_count in CPUArchId comments. Whlie
> at it, reorder the parameters in comments to match the sequence of
> parameters which defined in the CPUArchId.
> 
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Shaoqin Huang <shahuang@redhat.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu