From nobody Sat May 18 12:04:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1686070390; cv=none; d=zohomail.com; s=zohoarc; b=PXvTsSwRA4jU9QoxQVrFuoW8+z7n9pdIyoSkkUWn/6rl1SAslKIdllCNkzO3g4OekrxoROlVFds2Af+U6GQkEcTSOrKezJswPeMDZYr+0ZdYA0gzQJrl5d3kkGhsguxcfQ/CZcefVUf5jzGc+o48dhz4uPeAIokmf8EmjutlbhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686070390; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ia9WSWxL7HYpbhT9gohYFvkr9lgNHzFRWmp7QMw4g8I=; b=idoISJTUeKzl1PGo9UAs5peL8etFSo8bREkqyROrR1h7tBIbcvSpRSl9r/ISwmFN0i4gjXScN6yLXGxEsXgLKl7F24GbNOT2Fn7ssSe85up9mQ58blq2+f0Pn75vFTyK2txr8OIuzb4el2nZPY5ba5Fk8H67M8APfhDZXiyrAdo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1686070390206625.2393101144012; Tue, 6 Jun 2023 09:53:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6ZvN-0003UI-K3; Tue, 06 Jun 2023 12:52:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6ZvF-0003Ps-Gr for qemu-devel@nongnu.org; Tue, 06 Jun 2023 12:52:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6ZvC-0001iC-Ri for qemu-devel@nongnu.org; Tue, 06 Jun 2023 12:52:41 -0400 Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-BAadTd0OOF-oGF1v5ueNdA-1; Tue, 06 Jun 2023 12:52:35 -0400 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-62849c5e9f0so7672586d6.1 for ; Tue, 06 Jun 2023 09:52:35 -0700 (PDT) Received: from x1n.redhat.com (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id u26-20020ae9c01a000000b0075d4d5617cdsm3498168qkk.66.2023.06.06.09.52.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 09:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686070356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ia9WSWxL7HYpbhT9gohYFvkr9lgNHzFRWmp7QMw4g8I=; b=hNzoDSkjEHkSXYdQonhGcB97+3AmXEfZMgm5ba/AFXN366h5Mi1lw0y7f/gJJ9oY87el+0 /IL2GrrgpYEXO5bh13K6U8Pu7vKdEhg0Blk2ciSMaS/u7EoOqfCke0+9dEq4XvVmzpjZSi TF3fuCWnJIoA0NyzxsgIsUJbO3rvGXY= X-MC-Unique: BAadTd0OOF-oGF1v5ueNdA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686070354; x=1688662354; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ia9WSWxL7HYpbhT9gohYFvkr9lgNHzFRWmp7QMw4g8I=; b=G6OmarpvTpRp8J3wu/f/HZO3YAnl4a3ZLHd1ztoGgYr1zLYoVJHTDotdRo5kC0I0Rb F3mdOR8wY67DxikblHaTIqImUnlRGmrbMdD1PtQ3r4FvUgtq1NHdl64GFXpdDAYA33Sl 0GEIlRCMZDj97nBYiPot8BG4N7JI49niCNkVg5Q6xGMr63gbFxy2pvGoZvpKy4wQDkdb 0hjWfhA9peqsVakMeg+xHn9xfbBe6I4kyKQ5qpwM/URVWmaw7vJKqaKcMZVYywqJiDKl vpd9CtVLdT/SRtKYL4zf4SQ8+DAk0l7Ph00GD4j/JRj/20sQ+OHK/vuY5L3Rw0mfW02h iZvw== X-Gm-Message-State: AC+VfDysy3jwJ3ZsvvFBY+9Rgh7SFxkAJRY4vfmYDrvbRQpu92Ec5uHQ /pHFEbYSUDtzDfv/eoS/eD6n6DCcnuFsQ9yTZqtbnadCqVF8UcfH9QuJCrpcmrcB6H6xb80bRbZ qpWHTpcU+0Zvxuv9QsuhOUbc0iMgHlydUDfGsK2JDSo027bQ8JJ7jkbJIQGXUccrQI96mMh4v X-Received: by 2002:a05:6214:1243:b0:622:265e:3473 with SMTP id r3-20020a056214124300b00622265e3473mr3093821qvv.1.1686070354113; Tue, 06 Jun 2023 09:52:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7rFGU7eMGa1q9lupBvJY5ZFtQkPg/H8J5S2zQ/7dC34iVXIZ436mmuLmqHKpPmfFU8vpfc4g== X-Received: by 2002:a05:6214:1243:b0:622:265e:3473 with SMTP id r3-20020a056214124300b00622265e3473mr3093785qvv.1.1686070353537; Tue, 06 Jun 2023 09:52:33 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier , Leonardo Bras Soares Passos , Avihai Horon , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , peterx@redhat.com, Eric Blake , Juan Quintela , Thomas Huth , Markus Armbruster Subject: [PATCH v2 1/2] migration: switchover-hold parameter Date: Tue, 6 Jun 2023 12:52:27 -0400 Message-Id: <20230606165228.491878-2-peterx@redhat.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230606165228.491878-1-peterx@redhat.com> References: <20230606165228.491878-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1686070391569100003 Content-Type: text/plain; charset="utf-8" Add a new migration parameter switchover-hold which can block src qemu migration from switching over to dest from running. One can set this flag to true so src qemu will keep iterating the VM data, not switching over to dest even if it can. It means now live migration works somehow like COLO; we keep syncing data from src to dst without stopping. When the user is ready for the switchover, one can set the parameter from true->false. That'll contain a implicit kick to migration thread to be alive and re-evaluate the switchover decision. This can be used in two cases so far in my mind: (1) One can use this parameter to start pre-heating migration (but not really migrating, so a migrate-cancel will cancel the preheat). When the user wants to really migrate, just clear the flag. It'll in most cases migrate immediately because most pages are already synced. (2) Can also be used as a clean way to do qtest, in many of the precopy tests we have requirement to run after 1 iteration without completing the precopy migration. Before that we have either set bandwidth to ridiculous low value, or tricks on detecting guest memory change over some adhoc guest memory position. Now we can simply set this flag then we know precopy won't complete and will just keep going. Here we leveraged a sem to make sure migration thread won't busy spin on a physical cpu, meanwhile provide a timedwait() of 10ms so it can still try its best to sync with dest QEMU from time to time. Note that the sem is prone to outdated counts but it's benign, please refer to the comment above the semaphore definition for more information. Signed-off-by: Peter Xu --- qapi/migration.json | 25 +++++++++++++-- migration/migration.h | 16 ++++++++++ migration/migration-hmp-cmds.c | 3 ++ migration/migration.c | 56 ++++++++++++++++++++++++++++++++-- migration/options.c | 17 +++++++++++ 5 files changed, 111 insertions(+), 6 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index 179af0c4d8..fb8751841a 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -779,6 +779,15 @@ # Nodes are mapped to their block device name if there is one, and # to their node name otherwise. (Since 5.2) # +# @switchover-hold: Whether we should hold-off precopy switchover from +# src to dest QEMU, even if we can finish migration in the +# downtime specified. By default off, so precopy migration will +# complete as soon as possible. One can set it to explicitly keep +# iterating during precopy migration until set the flag to false +# again to kick off the final switchover. Note, this does not +# affect postcopy switchover, because the user can control that +# using "migrate-start-postcopy" command explicitly. (Since 8.1) +# # Features: # # @unstable: Member @x-checkpoint-delay is experimental. @@ -800,7 +809,7 @@ 'xbzrle-cache-size', 'max-postcopy-bandwidth', 'max-cpu-throttle', 'multifd-compression', 'multifd-zlib-level' ,'multifd-zstd-level', - 'block-bitmap-mapping' ] } + 'block-bitmap-mapping', 'switchover-hold' ] } =20 ## # @MigrateSetParameters: @@ -935,6 +944,10 @@ # Nodes are mapped to their block device name if there is one, and # to their node name otherwise. (Since 5.2) # +# @switchover-hold: Whether we should hold-off precopy switchover from +# src to dest QEMU. For more details, please refer to +# MigrationParameter entry of the same field. (Since 8.1) +# # Features: # # @unstable: Member @x-checkpoint-delay is experimental. @@ -972,7 +985,8 @@ '*multifd-compression': 'MultiFDCompression', '*multifd-zlib-level': 'uint8', '*multifd-zstd-level': 'uint8', - '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ] } } + '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ], + '*switchover-hold': 'bool' } } =20 ## # @migrate-set-parameters: @@ -1127,6 +1141,10 @@ # Nodes are mapped to their block device name if there is one, and # to their node name otherwise. (Since 5.2) # +# @switchover-hold: Whether we should hold-off precopy switchover from +# src to dest QEMU. For more details, please refer to +# MigrationParameter entry of the same field. (Since 8.1) +# # Features: # # @unstable: Member @x-checkpoint-delay is experimental. @@ -1161,7 +1179,8 @@ '*multifd-compression': 'MultiFDCompression', '*multifd-zlib-level': 'uint8', '*multifd-zstd-level': 'uint8', - '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ] } } + '*block-bitmap-mapping': [ 'BitmapMigrationNodeAlias' ], + '*switchover-hold': 'bool' } } =20 ## # @query-migrate-parameters: diff --git a/migration/migration.h b/migration/migration.h index 30c3e97635..721b1c9473 100644 --- a/migration/migration.h +++ b/migration/migration.h @@ -440,6 +440,22 @@ struct MigrationState { =20 /* QEMU_VM_VMDESCRIPTION content filled for all non-iterable devices. = */ JSONWriter *vmdesc; + /* + * Only migration thread will wait on it when switchover_hold=3D=3Dtru= e. + * + * Only qmp set param will kick it when switching switchover_hold from + * true->false. + * + * NOTE: outdated sem count here is benign. E.g., when this is posted, + * the 1st migration got cancelled, then start the 2nd migration, or + * when someone sets the flag from true->false->true->false.. because + * any outdated sem count will only let the migration thread to run one + * more loop (timedwait() will eat the outdated count) when reaching + * the completion phase, then in the next loop it'll sleep again. The + * important thing here OTOH is when the migration thread is sleeping + * we can always kick it out of the sleep, which we will always do. + */ + QemuSemaphore switchover_hold_sem; }; =20 void migrate_set_state(int *state, int old_state, int new_state); diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c index 9885d7c9f7..63a2c8a4a3 100644 --- a/migration/migration-hmp-cmds.c +++ b/migration/migration-hmp-cmds.c @@ -338,6 +338,9 @@ void hmp_info_migrate_parameters(Monitor *mon, const QD= ict *qdict) monitor_printf(mon, "%s: '%s'\n", MigrationParameter_str(MIGRATION_PARAMETER_TLS_AUTHZ), params->tls_authz); + monitor_printf(mon, "%s: %s\n", + MigrationParameter_str(MIGRATION_PARAMETER_SWITCHOVER_HOLD), + params->switchover_hold ? "on" : "off"); =20 if (params->has_block_bitmap_mapping) { const BitmapMigrationNodeAliasList *bmnal; diff --git a/migration/migration.c b/migration/migration.c index dc05c6f6ea..203d40d4c9 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2693,6 +2693,55 @@ static void migration_update_counters(MigrationState= *s, bandwidth, s->threshold_size); } =20 +static bool +migration_should_complete(MigrationState *s, uint64_t pending_size) +{ + /* We still have large pending data to send? */ + if (pending_size && (pending_size >=3D s->threshold_size)) { + return false; + } + + /* The user doesn't want us to switchover yet for precopy */ + if (!migration_in_postcopy() && s->parameters.switchover_hold) { + /* + * Note: when reaching here it probably means we've migrated almost + * everything and ready to switchover. If user asked not to switch + * wait for a short period and respond to kicks immediately. + * + * If we wait too long, there can be a lot of dirty data generated, + * while we could have done something to sync data between src/dst. + * + * If we wait too short, migration thread can eat most/all cpu + * resource looping over switchover_hold. + * + * Make it 10ms which seems to be a good intermediate value. + */ + qemu_sem_timedwait(&s->switchover_hold_sem, 10); + + /* + * Return false here always even if user changed it, because we'd + * like to re-evaluate everything (e.g. pending_size). + */ + return false; + } + + return true; +} + +static bool +migration_should_start_postcopy(MigrationState *s, uint64_t must_precopy) +{ + /* If we're already in postcopy phase, don't bother */ + if (migration_in_postcopy()) { + return false; + } + /* We still have lots of thing that must be migrated in precopy */ + if (must_precopy > s->threshold_size) { + return false; + } + return qatomic_read(&s->start_postcopy); +} + /* Migration thread iteration status */ typedef enum { MIG_ITERATE_RESUME, /* Resume current iteration */ @@ -2720,15 +2769,14 @@ static MigIterateState migration_iteration_run(Migr= ationState *s) trace_migrate_pending_exact(pending_size, must_precopy, can_postco= py); } =20 - if (!pending_size || pending_size < s->threshold_size) { + if (migration_should_complete(s, pending_size)) { trace_migration_thread_low_pending(pending_size); migration_completion(s); return MIG_ITERATE_BREAK; } =20 /* Still a significant amount to transfer */ - if (!in_postcopy && must_precopy <=3D s->threshold_size && - qatomic_read(&s->start_postcopy)) { + if (migration_should_start_postcopy(s, must_precopy)) { if (postcopy_start(s)) { error_report("%s: postcopy failed to start", __func__); } @@ -3285,6 +3333,7 @@ static void migration_instance_finalize(Object *obj) qemu_sem_destroy(&ms->rp_state.rp_sem); qemu_sem_destroy(&ms->rp_state.rp_pong_acks); qemu_sem_destroy(&ms->postcopy_qemufile_src_sem); + qemu_sem_destroy(&ms->switchover_hold_sem); error_free(ms->error); } =20 @@ -3307,6 +3356,7 @@ static void migration_instance_init(Object *obj) qemu_sem_init(&ms->rate_limit_sem, 0); qemu_sem_init(&ms->wait_unplug_sem, 0); qemu_sem_init(&ms->postcopy_qemufile_src_sem, 0); + qemu_sem_init(&ms->switchover_hold_sem, 0); qemu_mutex_init(&ms->qemu_file_lock); } =20 diff --git a/migration/options.c b/migration/options.c index b62ab30cd5..2d6b138352 100644 --- a/migration/options.c +++ b/migration/options.c @@ -163,6 +163,8 @@ Property migration_properties[] =3D { DEFINE_PROP_STRING("tls-creds", MigrationState, parameters.tls_creds), DEFINE_PROP_STRING("tls-hostname", MigrationState, parameters.tls_host= name), DEFINE_PROP_STRING("tls-authz", MigrationState, parameters.tls_authz), + DEFINE_PROP_BOOL("switchover-hold", MigrationState, + parameters.switchover_hold, false), =20 /* Migration capabilities */ DEFINE_PROP_MIG_CAP("x-xbzrle", MIGRATION_CAPABILITY_XBZRLE), @@ -883,6 +885,8 @@ MigrationParameters *qmp_query_migrate_parameters(Error= **errp) params->announce_rounds =3D s->parameters.announce_rounds; params->has_announce_step =3D true; params->announce_step =3D s->parameters.announce_step; + params->has_switchover_hold =3D true; + params->switchover_hold =3D s->parameters.switchover_hold; =20 if (s->parameters.has_block_bitmap_mapping) { params->has_block_bitmap_mapping =3D true; @@ -923,6 +927,7 @@ void migrate_params_init(MigrationParameters *params) params->has_announce_max =3D true; params->has_announce_rounds =3D true; params->has_announce_step =3D true; + params->has_switchover_hold =3D true; } =20 /* @@ -1177,6 +1182,9 @@ static void migrate_params_test_apply(MigrateSetParam= eters *params, if (params->has_announce_step) { dest->announce_step =3D params->announce_step; } + if (params->has_switchover_hold) { + dest->switchover_hold =3D params->switchover_hold; + } =20 if (params->has_block_bitmap_mapping) { dest->has_block_bitmap_mapping =3D true; @@ -1290,6 +1298,15 @@ static void migrate_params_apply(MigrateSetParameter= s *params, Error **errp) if (params->has_announce_step) { s->parameters.announce_step =3D params->announce_step; } + if (params->has_switchover_hold) { + bool old =3D s->parameters.switchover_hold; + bool new =3D params->switchover_hold; + + s->parameters.switchover_hold =3D params->switchover_hold; + if (old && !new) { + qemu_sem_post(&s->switchover_hold_sem); + } + } =20 if (params->has_block_bitmap_mapping) { qapi_free_BitmapMigrationNodeAliasList( --=20 2.40.1 From nobody Sat May 18 12:04:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1686070390; cv=none; d=zohomail.com; s=zohoarc; b=iEqK9HBV/xJNg39HNnCHhXSg3FGM62YF9wvope4dBI3Yrz7dEQ0Zj/ZDzLNHYKMQft0Dm6gOPFybVYCZ5dyjh6nCwjjx8H4JrX6+t9IArc1XVpxkw8zsOQAbaiSwRivJl3bv9YyvCzpxpy1zpxwC4w2mektyItHEPw0hBi5RWIQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686070390; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/Kvc91zkETlfrfhPhmP9scrsxwp0zbBqlSActAzPQgo=; b=RgcSxUtNtnM6C5CdyHKolO6symL9jJn/6QPtlvOuZI89xF6IwDTzXf6Q1TGOmipDnFewhfz4CE5uf1+16/0rvFnVxm4ZK8upOrRj7mdNymFrJ4QQ3SQmYJTFz0K4Wim0RJSKztiHEZ1Ph/5SibMbJ1qeq3qx96YR0tnbsjvtRx4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1686070390239822.3527692458084; Tue, 6 Jun 2023 09:53:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6ZvN-0003VQ-KO; Tue, 06 Jun 2023 12:52:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6ZvG-0003QG-6g for qemu-devel@nongnu.org; Tue, 06 Jun 2023 12:52:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6ZvE-0001iW-6O for qemu-devel@nongnu.org; Tue, 06 Jun 2023 12:52:41 -0400 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-B9S7j-x8OjWqAn9rkuNH1w-1; Tue, 06 Jun 2023 12:52:37 -0400 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-75eb82ada06so58839085a.1 for ; Tue, 06 Jun 2023 09:52:37 -0700 (PDT) Received: from x1n.redhat.com (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id u26-20020ae9c01a000000b0075d4d5617cdsm3498168qkk.66.2023.06.06.09.52.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jun 2023 09:52:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686070359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Kvc91zkETlfrfhPhmP9scrsxwp0zbBqlSActAzPQgo=; b=B3qbk/otWgbKPC6kUp+eqw0bmx8xLqRrqpJuRNGgT8qeaxiOCU38U837t3Dytd8mP07Ks7 WB3IL2btsDpOCGb61R/gZzkXW8xjyDhQm4KeRlllFrjUmghinqehoUEc/2FelAVQvfdFsK E/aVWVBrSd8sVjkU4eL0ccN0k+0Z//M= X-MC-Unique: B9S7j-x8OjWqAn9rkuNH1w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686070356; x=1688662356; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/Kvc91zkETlfrfhPhmP9scrsxwp0zbBqlSActAzPQgo=; b=KDq1rpZSDzPlSBdqrmDRBnfl2zq1Ku1ARBtAwq/eT3jE4QMn6Ld2nHAlXaTwYs1J6C zjbTs14/K8kydj3+4QuDEonRBqwdVdqoq12ZnZEN8hzJd0DEDcsHaR6u9h6Z1RTIzNMH rvA4z0swItL1uZP7eSbvA3s+Px4C3YbavxgIUDAwuMohMXOAfuB6OY/257lQ+mxfJOCj l3dX9DbxFl7JO7x/02xCYvuB1XXXl1XEjgDdgV2Y12nO1ibXAEUR8kZxCwwp2AeLjjHq aDNHjAaYN+mokHf0gwg6cVW9mzgRLrxhsxt4K7TlzjW5NmBTSqolIcZOko4g4kvYvPDa Wd1Q== X-Gm-Message-State: AC+VfDwgMdhiITJa0F8IOntlSWiscxBIm5BB+DoU1sAzZxzPfB/enFfZ w1HW6F3dODxdOikFRPEvbG99qJctuno3/MVYZX645JtFDQ5QHjN7aNcpliuzgNFO2uhKPTb06Ll pfuW6WWT2cxAnAIarR0QoHFSdMwsb7BmnOZ6vAAEoWBcdbzC5Oapoampzjek/484KosdCEXiP X-Received: by 2002:a05:620a:6185:b0:75b:23a1:69e7 with SMTP id or5-20020a05620a618500b0075b23a169e7mr2878464qkn.7.1686070356166; Tue, 06 Jun 2023 09:52:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6akOH7CjqZBMmqXIEc74glqea5Puc9M3b36YdggEuYeYatUHwdx1P6TknjgG0B0ExrzQlpHQ== X-Received: by 2002:a05:620a:6185:b0:75b:23a1:69e7 with SMTP id or5-20020a05620a618500b0075b23a169e7mr2878428qkn.7.1686070355774; Tue, 06 Jun 2023 09:52:35 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier , Leonardo Bras Soares Passos , Avihai Horon , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , peterx@redhat.com, Eric Blake , Juan Quintela , Thomas Huth , Markus Armbruster Subject: [PATCH v2 2/2] qtest/migration: Use switchover-hold to speedup Date: Tue, 6 Jun 2023 12:52:28 -0400 Message-Id: <20230606165228.491878-3-peterx@redhat.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230606165228.491878-1-peterx@redhat.com> References: <20230606165228.491878-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1686070392296100009 Content-Type: text/plain; charset="utf-8" This solution is heavily based on Daniel's original approach here, but hopefully a cleaner way to impl: https://lore.kernel.org/r/20230601161347.1803440-11-berrange@redhat.com The difference is we use the switchover-hold flag rather than tuning bw+downtime to guide test convergence, comparing to use the magic offset. This can achieve similar goal of previous patch "tests/qtest: massively speed up migration-test" but without magic offset to write or monitoring. With this flag, we can safely always run migration tests with full speed (bw=3D0). However for postcopy tests, when with above bw=3D0, it's easy to happen that right after switching to postcopy there're merely no page left, so the postcopy paths are not well tested. To remedy that, don't wait for a full iteration but switch to postcopy in the 1st iteration, adding a precopy bw limit (200MB/s for now, running 100ms) so it should guarantee enough pages left for postcopy. One pity is that normally postcopy switchover happens after 1-2 rounds of precopy, so qtest doesn't follow that anymore (while it was trying to). However it also means previous postcopy tests never tested the case where there're holes in pages (pages that never got migrated during precopy), now we cover that too which is actually also a valid scenario for postcopy. The initial solution can reduce migration-test time from 8min to 1min40s, this patch can further reduce it from 1m40s to <1m per my local test. While at it, add migrate_set_bandwidth_[pre|post]copy() and use them. Signed-off-by: Peter Xu --- tests/qtest/migration-test.c | 39 +++++++++++++++++++++++++++--------- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index b0c355bbd9..53e391989f 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -433,16 +433,23 @@ static void migrate_set_parameter_bool(QTestState *wh= o, const char *parameter, =20 static void migrate_ensure_non_converge(QTestState *who) { - /* Can't converge with 1ms downtime + 3 mbs bandwidth limit */ - migrate_set_parameter_int(who, "max-bandwidth", 3 * 1000 * 1000); - migrate_set_parameter_int(who, "downtime-limit", 1); + /* Hold off switchover for precopy only */ + migrate_set_parameter_bool(who, "switchover-hold", true); } =20 static void migrate_ensure_converge(QTestState *who) { - /* Should converge with 30s downtime + 1 gbs bandwidth limit */ - migrate_set_parameter_int(who, "max-bandwidth", 1 * 1000 * 1000 * 1000= ); - migrate_set_parameter_int(who, "downtime-limit", 30 * 1000); + migrate_set_parameter_bool(who, "switchover-hold", false); +} + +static void migrate_set_bandwidth_precopy(QTestState *who, int bw) +{ + migrate_set_parameter_int(who, "max-bandwidth", bw); +} + +static void migrate_set_bandwidth_postcopy(QTestState *who, int bw) +{ + migrate_set_parameter_int(who, "max-postcopy-bandwidth", bw); } =20 static void migrate_pause(QTestState *who) @@ -736,6 +743,14 @@ static int test_migrate_start(QTestState **from, QTest= State **to, unlink(shmem_path); } =20 + /* + * By default, use full speed for precopy in qtests as that will reduce + * the time of testing. The default bandwidth (128MB/s) may be too slow + * in this case. Specific test can overwrite this value after the + * function returns but before starting migration. + */ + migrate_set_bandwidth_precopy(*from, 0); + return 0; } =20 @@ -1168,9 +1183,13 @@ static int migrate_postcopy_prepare(QTestState **fro= m_ptr, /* Wait for the first serial output from the source */ wait_for_serial("src_serial"); =20 + /* + * Limit precopy to 200MB/s for 0.1 sec, so we guarantee to leave + * enough pages (total-20MB) for remote page fault processes later. + */ + migrate_set_bandwidth_precopy(from, 200 * 1024 * 1024); migrate_qmp(from, uri, "{}"); - - wait_for_migration_pass(from); + usleep(100000); =20 *from_ptr =3D from; *to_ptr =3D to; @@ -1270,7 +1289,7 @@ static void test_postcopy_recovery_common(MigrateComm= on *args) } =20 /* Turn postcopy speed down, 4K/s is slow enough on any machines */ - migrate_set_parameter_int(from, "max-postcopy-bandwidth", 4096); + migrate_set_bandwidth_postcopy(from, 4096); =20 /* Now we start the postcopy */ migrate_postcopy_start(from, to); @@ -1314,7 +1333,7 @@ static void test_postcopy_recovery_common(MigrateComm= on *args) migrate_qmp(from, uri, "{'resume': true}"); =20 /* Restore the postcopy bandwidth to unlimited */ - migrate_set_parameter_int(from, "max-postcopy-bandwidth", 0); + migrate_set_bandwidth_postcopy(from, 0); =20 migrate_postcopy_complete(from, to, args); } --=20 2.40.1