From nobody Sat May 18 06:50:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1686062784; cv=none; d=zohomail.com; s=zohoarc; b=UsjMEoOE0AMc2Xzi1aqGUxvmacU5GvPgVK293MMwD0lhcBsexwHp2SArMhFRImFHhITaQz/AJ2wTCqQUelm4S42IGAUFu56etk56wGUM0ehbNWY1DhQznUyno2pXNXKrxfRSTF9dYKYjqG63iXjg/yK9SFbnyTnu4ygIlMFz20U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686062784; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hIRpTkn+q/xWzKR1cEEDLTMEBE0D2WGQJOTHjKeR4x0=; b=LGoa0i9zMNpQ6UddB4O9RRn7pWyCPaKk0FuSYeaog/bzbJd+CIL+8STvYZxn9e3yxt6rABHmyPT750FwTisn9jFmqaRpvL1vroQQBiIe9y8z149/N8kJQQfArOxQnZHiJKiEH7rgRiEnuWdOW4UQ4LVsuDkpEGwZZtp9v/cxMHQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1686062784224305.2749016872965; Tue, 6 Jun 2023 07:46:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6Xwh-0007np-Am; Tue, 06 Jun 2023 10:46:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6Xwf-0007mk-LN for qemu-devel@nongnu.org; Tue, 06 Jun 2023 10:46:01 -0400 Received: from smtp-out2.suse.de ([2001:67c:2178:6::1d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6Xwd-0004Qb-Kc for qemu-devel@nongnu.org; Tue, 06 Jun 2023 10:46:01 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4D9EF1FD75; Tue, 6 Jun 2023 14:45:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 650C913519; Tue, 6 Jun 2023 14:45:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eF6rCqRGf2SRCAAAMHmgww (envelope-from ); Tue, 06 Jun 2023 14:45:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686062758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hIRpTkn+q/xWzKR1cEEDLTMEBE0D2WGQJOTHjKeR4x0=; b=PH2LR4k0YWEX9Xb5gd1roHjVm1/JYW/i8B4qe17vkyCHcJrmoF9Z9iUS4gjB18VUy/ye0S YJ47ZhpzETXnu1wG76opP+t/qRE34Osoh384+h39ddVYtleL1ptwQ8hSG/mrUT+SNNFLn9 r5j7EcLj08smCMQ0aATVob1DcXfUjyY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686062758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hIRpTkn+q/xWzKR1cEEDLTMEBE0D2WGQJOTHjKeR4x0=; b=Els+Nm+2zM+SqfuBikmDv6cl6tEkhyb8pHk5eOz0uquK0veNMhogCB2buuzq12ugQKriXU YhqPYZmE5op/l0Cg== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Maydell , Juan Quintela , Jiang Jiacheng , Peter Xu , Leonardo Bras Subject: [PATCH 1/3] migration/multifd: Rename threadinfo.c functions Date: Tue, 6 Jun 2023 11:45:49 -0300 Message-Id: <20230606144551.24367-2-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230606144551.24367-1-farosas@suse.de> References: <20230606144551.24367-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:67c:2178:6::1d; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1686062786055100003 Content-Type: text/plain; charset="utf-8" The code in threadinfo.c is only used for the QMP command query-migrationthreads. Make it explicit that this is something related to QMP. The current names are also too generic for a piece of code that doesn't affect the migration directly in any way. Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- migration/migration.c | 4 ++-- migration/multifd.c | 4 ++-- migration/threadinfo.c | 4 ++-- migration/threadinfo.h | 5 ++--- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index dc05c6f6ea..e731fc98a1 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2922,7 +2922,7 @@ static void *migration_thread(void *opaque) MigThrError thr_error; bool urgent =3D false; =20 - thread =3D MigrationThreadAdd("live_migration", qemu_get_thread_id()); + thread =3D qmp_migration_threads_add("live_migration", qemu_get_thread= _id()); =20 rcu_register_thread(); =20 @@ -3000,7 +3000,7 @@ static void *migration_thread(void *opaque) migration_iteration_finish(s); object_unref(OBJECT(s)); rcu_unregister_thread(); - MigrationThreadDel(thread); + qmp_migration_threads_remove(thread); return NULL; } =20 diff --git a/migration/multifd.c b/migration/multifd.c index 0bf5958a9c..5ec1ac5c64 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -651,7 +651,7 @@ static void *multifd_send_thread(void *opaque) int ret =3D 0; bool use_zero_copy_send =3D migrate_zero_copy_send(); =20 - thread =3D MigrationThreadAdd(p->name, qemu_get_thread_id()); + thread =3D qmp_migration_threads_add(p->name, qemu_get_thread_id()); =20 trace_multifd_send_thread_start(p->id); rcu_register_thread(); @@ -767,7 +767,7 @@ out: qemu_mutex_unlock(&p->mutex); =20 rcu_unregister_thread(); - MigrationThreadDel(thread); + qmp_migration_threads_remove(thread); trace_multifd_send_thread_end(p->id, p->num_packets, p->total_normal_p= ages); =20 return NULL; diff --git a/migration/threadinfo.c b/migration/threadinfo.c index 1de8b31855..c3e85c33e8 100644 --- a/migration/threadinfo.c +++ b/migration/threadinfo.c @@ -14,7 +14,7 @@ =20 static QLIST_HEAD(, MigrationThread) migration_threads; =20 -MigrationThread *MigrationThreadAdd(const char *name, int thread_id) +MigrationThread *qmp_migration_threads_add(const char *name, int thread_id) { MigrationThread *thread =3D g_new0(MigrationThread, 1); thread->name =3D name; @@ -25,7 +25,7 @@ MigrationThread *MigrationThreadAdd(const char *name, int= thread_id) return thread; } =20 -void MigrationThreadDel(MigrationThread *thread) +void qmp_migration_threads_remove(MigrationThread *thread) { if (thread) { QLIST_REMOVE(thread, node); diff --git a/migration/threadinfo.h b/migration/threadinfo.h index 4d69423c0a..61b990f5e3 100644 --- a/migration/threadinfo.h +++ b/migration/threadinfo.h @@ -23,6 +23,5 @@ struct MigrationThread { QLIST_ENTRY(MigrationThread) node; }; =20 -MigrationThread *MigrationThreadAdd(const char *name, int thread_id); - -void MigrationThreadDel(MigrationThread *info); +MigrationThread *qmp_migration_threads_add(const char *name, int thread_id= ); +void qmp_migration_threads_remove(MigrationThread *info); --=20 2.35.3 From nobody Sat May 18 06:50:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1686062771; cv=none; d=zohomail.com; s=zohoarc; b=ARcx25lVwFLGR3pCTjos+ywV5L9j1vmAFJMlAeSS5M/6B8ByyE6b9dzwzlvs9Plm4LTf25a+HayB5GRXn1l/FA0ghKwNsXFOhaV3DEQqDXgAJeC1GXQa0owe/Q8VoMU7V5Wg34r05MpqThOJy3UAPf2HZjmQr5EpXJnZCLK/JSU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686062771; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GlN22RhbQhJB6/5iBlVX5sHJkyTJGwjkb6VY0xTHKTg=; b=iiV/9Ai++Yqf0XskEA24ZoCOX9xLjzyVHHM3nnfG5PqFkfEYplnT5qUHylkRPVLWA+v7HXbpTnKpwj6/souutwOYhJJox846qHVFDlpnbwUU6VEBrj1RUH2YcyOQVqnGOuJxojDoKUEIyQoAmjqRbZjYz5nGXc88zYDzZHNdrSs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1686062771698311.39640469408914; Tue, 6 Jun 2023 07:46:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6Xwj-0007w1-Hy; Tue, 06 Jun 2023 10:46:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6Xwi-0007q4-5v for qemu-devel@nongnu.org; Tue, 06 Jun 2023 10:46:04 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6Xwg-0004R0-EC for qemu-devel@nongnu.org; Tue, 06 Jun 2023 10:46:03 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AE5731FD76; Tue, 6 Jun 2023 14:46:00 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C627913519; Tue, 6 Jun 2023 14:45:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wIRmIqZGf2SRCAAAMHmgww (envelope-from ); Tue, 06 Jun 2023 14:45:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686062760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GlN22RhbQhJB6/5iBlVX5sHJkyTJGwjkb6VY0xTHKTg=; b=y642QhejnUzVZyFBgCpIONVcgL1T+e99lXi6OTHgvj0Ni3R/5KTcvP45546M1i3xCYVEU+ UnYFJrluDI6F+QRsyCabSYCMJm59gLhPd7E0kVHmMf+GD8aYkCR+ErLpN2x5wDbHb/Af9S Zh+hivUWyc2nX1pP7zTBpmMIy/deYoA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686062760; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GlN22RhbQhJB6/5iBlVX5sHJkyTJGwjkb6VY0xTHKTg=; b=jcOinv/cH7HLpJ4jqjEpN52JN5J9EQ1tNJGPO9FvcBJkCDtMJxs0eo4wM72TpGkf6+uBFc NsdaKusGIIdC2BCA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Maydell , Juan Quintela , Jiang Jiacheng , Peter Xu , Leonardo Bras Subject: [PATCH 2/3] migration/multifd: Protect accesses to migration_threads Date: Tue, 6 Jun 2023 11:45:50 -0300 Message-Id: <20230606144551.24367-3-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230606144551.24367-1-farosas@suse.de> References: <20230606144551.24367-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1686062772466100005 Content-Type: text/plain; charset="utf-8" This doubly linked list is common for all the multifd and migration threads so we need to avoid concurrent access. Add a mutex to protect the data from concurrent access. This fixes a crash when removing two MigrationThread objects from the list at the same time during cleanup of multifd threads. To avoid destroying the mutex before the last element has been removed, move calls to qmp_migration_thread_remove so they run before multifd_save_cleanup joins the threads. Fixes: 671326201d ("migration: Introduce interface query-migrationthreads") Signed-off-by: Fabiano Rosas --- migration/migration.c | 5 ++++- migration/multifd.c | 3 ++- migration/threadinfo.c | 19 ++++++++++++++++++- migration/threadinfo.h | 5 +++-- 4 files changed, 27 insertions(+), 5 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index e731fc98a1..b3b8345eb2 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1146,6 +1146,7 @@ static void migrate_fd_cleanup(MigrationState *s) qemu_mutex_lock_iothread(); =20 multifd_save_cleanup(); + qmp_migration_threads_cleanup(); qemu_mutex_lock(&s->qemu_file_lock); tmp =3D s->to_dst_file; s->to_dst_file =3D NULL; @@ -1405,6 +1406,8 @@ void migrate_init(MigrationState *s) s->vm_old_state =3D -1; s->iteration_initial_bytes =3D 0; s->threshold_size =3D 0; + + qmp_migration_threads_init(); } =20 int migrate_add_blocker_internal(Error *reason, Error **errp) @@ -2997,10 +3000,10 @@ static void *migration_thread(void *opaque) } =20 trace_migration_thread_after_loop(); + qmp_migration_threads_remove(thread); migration_iteration_finish(s); object_unref(OBJECT(s)); rcu_unregister_thread(); - qmp_migration_threads_remove(thread); return NULL; } =20 diff --git a/migration/multifd.c b/migration/multifd.c index 5ec1ac5c64..ee7944560a 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -762,12 +762,13 @@ out: qemu_sem_post(&multifd_send_state->channels_ready); } =20 + qmp_migration_threads_remove(thread); + qemu_mutex_lock(&p->mutex); p->running =3D false; qemu_mutex_unlock(&p->mutex); =20 rcu_unregister_thread(); - qmp_migration_threads_remove(thread); trace_multifd_send_thread_end(p->id, p->num_packets, p->total_normal_p= ages); =20 return NULL; diff --git a/migration/threadinfo.c b/migration/threadinfo.c index c3e85c33e8..1fe64a02dd 100644 --- a/migration/threadinfo.c +++ b/migration/threadinfo.c @@ -10,23 +10,40 @@ * See the COPYING file in the top-level directory. */ =20 +#include "qemu/osdep.h" +#include "qemu/queue.h" +#include "qemu/lockable.h" #include "threadinfo.h" =20 +QemuMutex migration_threads_lock; static QLIST_HEAD(, MigrationThread) migration_threads; =20 +void qmp_migration_threads_init(void) +{ + qemu_mutex_init(&migration_threads_lock); +} + +void qmp_migration_threads_cleanup(void) +{ + qemu_mutex_destroy(&migration_threads_lock); +} + MigrationThread *qmp_migration_threads_add(const char *name, int thread_id) { MigrationThread *thread =3D g_new0(MigrationThread, 1); thread->name =3D name; thread->thread_id =3D thread_id; =20 - QLIST_INSERT_HEAD(&migration_threads, thread, node); + WITH_QEMU_LOCK_GUARD(&migration_threads_lock) { + QLIST_INSERT_HEAD(&migration_threads, thread, node); + } =20 return thread; } =20 void qmp_migration_threads_remove(MigrationThread *thread) { + QEMU_LOCK_GUARD(&migration_threads_lock); if (thread) { QLIST_REMOVE(thread, node); g_free(thread); diff --git a/migration/threadinfo.h b/migration/threadinfo.h index 61b990f5e3..eb7f8e5bb2 100644 --- a/migration/threadinfo.h +++ b/migration/threadinfo.h @@ -10,8 +10,6 @@ * See the COPYING file in the top-level directory. */ =20 -#include "qemu/queue.h" -#include "qemu/osdep.h" #include "qapi/error.h" #include "qapi/qapi-commands-migration.h" =20 @@ -23,5 +21,8 @@ struct MigrationThread { QLIST_ENTRY(MigrationThread) node; }; =20 +void qmp_migration_threads_init(void); +void qmp_migration_threads_cleanup(void); + MigrationThread *qmp_migration_threads_add(const char *name, int thread_id= ); void qmp_migration_threads_remove(MigrationThread *info); --=20 2.35.3 From nobody Sat May 18 06:50:46 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1686062798; cv=none; d=zohomail.com; s=zohoarc; b=B/i4oEJnnBZSgGjSoP9TLZCsAqBU5VmInJ1dL9j5rk5JaO/P7qUZ6lkDz67AQTWUS7WMyR5gh78HZxlJNZ1D2zPiL9O252ZZA5ZhFzw0c76IfYmvQnSkPMi7pxW8y135ey4UELYzyArrMnNSAwkuROPsBN0dsZi3avcYVhoAvko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1686062798; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EqSJUiPJ3diyQ5Qjk3MR0/t7OAkSvn9VVVCIkeEHCxg=; b=C/fk0tz/u/usq4s9JoIp6qhcti8n7l8QjIMzdzSnKMsjqk+L8x42KSztbcHJB+YI9XDIWx2JEs77iTMPfcXSpPwyRo1uBFIS3jlOoNLqQqzXgUAvdzVcInhwb4xPsBKGETCYx0CiiytWllh9a+8PqBl8451AD8VXUzDKtCAtB6o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1686062798439183.90283200714384; Tue, 6 Jun 2023 07:46:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6Xwm-0008EW-7L; Tue, 06 Jun 2023 10:46:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6Xwk-00080J-CW for qemu-devel@nongnu.org; Tue, 06 Jun 2023 10:46:06 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q6Xwi-0004S4-SV for qemu-devel@nongnu.org; Tue, 06 Jun 2023 10:46:06 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BC83B1F8A8; Tue, 6 Jun 2023 14:46:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2CBC213519; Tue, 6 Jun 2023 14:46:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WCa3OKhGf2SRCAAAMHmgww (envelope-from ); Tue, 06 Jun 2023 14:46:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686062763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EqSJUiPJ3diyQ5Qjk3MR0/t7OAkSvn9VVVCIkeEHCxg=; b=PAz+GzegJ7TKTBNNpv6/sPVm7dlOMiC+xx/iQzhNrsgqB74KQHX14E/eC+sURI/vmsVkTW GmK6aSwhtWqNItl26uxlabp4t7kxKXXaFdjhJsVtZdzUd+sHaBOA6Ui8hJM/wgQ//wJvIW N62DqKHvFIbDyHGZrFYxrf/UERW77oc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686062763; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EqSJUiPJ3diyQ5Qjk3MR0/t7OAkSvn9VVVCIkeEHCxg=; b=gPPHjDcFOl+GCYZb01mPoGFP51ecAZnYxvUnjxZIS9GRtBcFTRhCjGmePv0eQMjTMdFhwu CR7CorT1czS78EAw== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: Peter Maydell , Juan Quintela , Jiang Jiacheng , Peter Xu , Leonardo Bras , Thomas Huth , Laurent Vivier , Paolo Bonzini Subject: [PATCH 3/3] tests/qtest: Re-enable multifd cancel test Date: Tue, 6 Jun 2023 11:45:51 -0300 Message-Id: <20230606144551.24367-4-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230606144551.24367-1-farosas@suse.de> References: <20230606144551.24367-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.29; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1686062800071100003 Content-Type: text/plain; charset="utf-8" We've found the source of flakiness in this test, so re-enable it. Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela --- tests/qtest/migration-test.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index b0c355bbd9..800ad23b75 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -2778,14 +2778,8 @@ int main(int argc, char **argv) } qtest_add_func("/migration/multifd/tcp/plain/none", test_multifd_tcp_none); - /* - * This test is flaky and sometimes fails in CI and otherwise: - * don't run unless user opts in via environment variable. - */ - if (getenv("QEMU_TEST_FLAKY_TESTS")) { - qtest_add_func("/migration/multifd/tcp/plain/cancel", - test_multifd_tcp_cancel); - } + qtest_add_func("/migration/multifd/tcp/plain/cancel", + test_multifd_tcp_cancel); qtest_add_func("/migration/multifd/tcp/plain/zlib", test_multifd_tcp_zlib); #ifdef CONFIG_ZSTD --=20 2.35.3