From nobody Fri May 17 11:05:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1685964855747212.42527413934272; Mon, 5 Jun 2023 04:34:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q68SZ-0004QH-1d; Mon, 05 Jun 2023 07:33:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q68SS-0004LE-6Y for qemu-devel@nongnu.org; Mon, 05 Jun 2023 07:33:09 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q68SQ-0008Nh-JO for qemu-devel@nongnu.org; Mon, 05 Jun 2023 07:33:07 -0400 Received: from host86-130-37-216.range86-130.btcentralplus.com ([86.130.37.216] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q68SJ-0005fJ-AJ; Mon, 05 Jun 2023 12:33:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To: Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dv2FTKxmkfHw2Qtwg4lbhGixm1rdRd+MteBWL4Oc5nc=; b=efeTOVGU2AgH88hfHFgEolKubg 7pM7E/++r4PytB5Pa13FWeyqySuK3d5DrYx2pVW4b6l9gYQtgR2W8H4Rsyq0VYh23L0zczkFCYldq aL7AeS+ywaVmGB1xJYnyrGqfdYm5ldkNE2TKcxvOwmpkT7BKtn9xNqkY1WA3wRHkeljJp56JRHxtW m53PheymgI3BAGqdzo4MnKE9qMeaEoKX9VjvTZ8QwM0UUAUAe34BJv8Pqv070VwJHIsaJX4+wLO1E +ZgRyLA07JcJeGTO+HL90naZPIgmo+Mlu695CwGizyJ9SUD5iguO4+i0zFakMoZEZzLyDHRblxyTR 0jjo3KowrPfhGs7VNupm4Qj+mPz5AUJveBb2uX5PhFJAR0NPS24PghS6yd/ftf3SUI+08wAS4Lop5 +5itFT4h1BIVAiwXy4k2tX0PbxR1m/z6Gznc4yb2Z259KYAcOdWmrypO5WWieobYS1zdz8jxZgG55 wyEtUp2cDbZ0yNxuX2+/GoD47r/TNYhJ/NTtzFsph+7o+IizZph20sz5RAxUo5HJilw2bFE58Ry+g r7i4Y1px+Wt/zZq/LkqyuvKdtlgfwnZnxoiG1+fX4tbSgNpPD49djyObcRr6ihnrIvqOU4eh7JGxx cPP8Y/PyjRW9SH8VcJKRWUkS86GdbQvLOhVovDJig=; From: Mark Cave-Ayland To: richard.henderson@linaro.org, qemu-devel@nongnu.org Date: Mon, 5 Jun 2023 12:32:51 +0100 Message-Id: <20230605113253.455937-2-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230605113253.455937-1-mark.cave-ayland@ilande.co.uk> References: <20230605113253.455937-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.130.37.216 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PULL 1/3] hw/timer/i8254_common: Share "iobase" property via base class X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1685964857476100001 From: Bernhard Beschow Both TYPE_KVM_I8254 and TYPE_I8254 have their own but same implementation of the "iobase" property. The storage for the property already resides in PITCommonState, so also move the property definition there. Signed-off-by: Bernhard Beschow Acked-by: Michael S. Tsirkin Reviewed-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20230523195608.125820-2-shentey@gmail.com> Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- hw/i386/kvm/i8254.c | 1 - hw/timer/i8254.c | 6 ------ hw/timer/i8254_common.c | 6 ++++++ 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/i386/kvm/i8254.c b/hw/i386/kvm/i8254.c index 191a26fa57..6a7383d877 100644 --- a/hw/i386/kvm/i8254.c +++ b/hw/i386/kvm/i8254.c @@ -301,7 +301,6 @@ static void kvm_pit_realizefn(DeviceState *dev, Error *= *errp) } =20 static Property kvm_pit_properties[] =3D { - DEFINE_PROP_UINT32("iobase", PITCommonState, iobase, -1), DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", KVMPITState, lost_tick_policy, LOST_TICK_POLICY_DELAY), DEFINE_PROP_END_OF_LIST(), diff --git a/hw/timer/i8254.c b/hw/timer/i8254.c index c8388ea432..c235496fc9 100644 --- a/hw/timer/i8254.c +++ b/hw/timer/i8254.c @@ -350,11 +350,6 @@ static void pit_realizefn(DeviceState *dev, Error **er= rp) pc->parent_realize(dev, errp); } =20 -static Property pit_properties[] =3D { - DEFINE_PROP_UINT32("iobase", PITCommonState, iobase, -1), - DEFINE_PROP_END_OF_LIST(), -}; - static void pit_class_initfn(ObjectClass *klass, void *data) { PITClass *pc =3D PIT_CLASS(klass); @@ -366,7 +361,6 @@ static void pit_class_initfn(ObjectClass *klass, void *= data) k->get_channel_info =3D pit_get_channel_info_common; k->post_load =3D pit_post_load; dc->reset =3D pit_reset; - device_class_set_props(dc, pit_properties); } =20 static const TypeInfo pit_info =3D { diff --git a/hw/timer/i8254_common.c b/hw/timer/i8254_common.c index 050875b497..e4093e2904 100644 --- a/hw/timer/i8254_common.c +++ b/hw/timer/i8254_common.c @@ -240,6 +240,11 @@ static const VMStateDescription vmstate_pit_common =3D= { } }; =20 +static Property pit_common_properties[] =3D { + DEFINE_PROP_UINT32("iobase", PITCommonState, iobase, -1), + DEFINE_PROP_END_OF_LIST(), +}; + static void pit_common_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -252,6 +257,7 @@ static void pit_common_class_init(ObjectClass *klass, v= oid *data) * done by board code. */ dc->user_creatable =3D false; + device_class_set_props(dc, pit_common_properties); } =20 static const TypeInfo pit_common_type =3D { --=20 2.30.2 From nobody Fri May 17 11:05:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1685964847818692.0803523527532; Mon, 5 Jun 2023 04:34:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q68Sa-0004Td-L0; Mon, 05 Jun 2023 07:33:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q68SV-0004Mo-VI for qemu-devel@nongnu.org; Mon, 05 Jun 2023 07:33:12 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q68ST-0008OW-WC for qemu-devel@nongnu.org; Mon, 05 Jun 2023 07:33:11 -0400 Received: from host86-130-37-216.range86-130.btcentralplus.com ([86.130.37.216] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q68SN-0005fJ-Fr; Mon, 05 Jun 2023 12:33:07 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To: Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZyZWWitKoyoH4cXwjHb4tS9t9BQik7b1JSC4Z3L2oXs=; b=mL4qarjfo4WGHGz3IxsXoVlZbR E2BIA/eY2JnOngIjOOEey6pQu2ddoh6NF6omfsfORf6SR8LjAR6xVuSb6eKCZtMLUTl3guYGTGJAm LcCZM+JZUJMtN/EtUo3/qPgn32ss/n+hVFMowaDNAi2Ieo6+bP6tclLCRvm8olV0e0gM0eD1/YPdl 3CT3sqchdM4GbgzoBTLmMrb6f+vAkyir0jI+hvCSH7RZ0tkxvKKEl6+p3iWC55wwGrYFYfuYe1j8p 3We0FQo0AD8NmBd5jI2pGN5UvmCl5M39jnCY4F1QiXDTSXTOe2vv9+TMdME0oaYFXdmUVwzCkBm6Q VmgEWuX2nsP/XnDBgmJm0zMtUjYtcyvPO0xUT2ciCRRA8RG2YmfsNW9xhLxgWrYa+X7kKIUSVsfEK l+OxS1S8xvzgl29dyd3cjPD2Qq76Y+g4UHdFUyaQxpUq+Pk0D/15PsVPQ3Zb1hD/4Im0KnT0da7e3 Ew3RL8d3F2S3CYswZrxEBD1VKdhEHnBnDXU+9lej7sMMwsKfOlQGw/t7nSL0xIfKt/njGQBTxxIkx hbK3BbadMVAfZZRWKRZkLp1l06kM6AyU9HgW/EgGBUT7Cf5qi6LQxSFvktSMU6Khq/+/VxefSxd5c i1eF/0ckTZBDc2cUTagICucNGmDJsR2q3xbw1eZXg=; From: Mark Cave-Ayland To: richard.henderson@linaro.org, qemu-devel@nongnu.org Date: Mon, 5 Jun 2023 12:32:52 +0100 Message-Id: <20230605113253.455937-3-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230605113253.455937-1-mark.cave-ayland@ilande.co.uk> References: <20230605113253.455937-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.130.37.216 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PULL 2/3] hw/arm/omap: Remove unused omap_uart_attach() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1685964849882100003 From: Bernhard Beschow The function is unused since commit bdad3654d3c55f478e538037d9eccd204e5fc8ee ('hw/arm/nseries: Remove invalid/unnecessary n8x0_uart_setup()'). Signed-off-by: Bernhard Beschow Acked-by: Michael S. Tsirkin Reviewed-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20230523195608.125820-3-shentey@gmail.com> Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- hw/char/omap_uart.c | 9 --------- include/hw/arm/omap.h | 1 - 2 files changed, 10 deletions(-) diff --git a/hw/char/omap_uart.c b/hw/char/omap_uart.c index 1c890b9201..6848bddb4e 100644 --- a/hw/char/omap_uart.c +++ b/hw/char/omap_uart.c @@ -175,12 +175,3 @@ struct omap_uart_s *omap2_uart_init(MemoryRegion *sysm= em, =20 return s; } - -void omap_uart_attach(struct omap_uart_s *s, Chardev *chr) -{ - /* TODO: Should reuse or destroy current s->serial */ - s->serial =3D serial_mm_init(get_system_memory(), s->base, 2, s->irq, - omap_clk_getrate(s->fclk) / 16, - chr ?: qemu_chr_new("null", "null", NULL), - DEVICE_NATIVE_ENDIAN); -} diff --git a/include/hw/arm/omap.h b/include/hw/arm/omap.h index c275d9b681..067e9419f7 100644 --- a/include/hw/arm/omap.h +++ b/include/hw/arm/omap.h @@ -724,7 +724,6 @@ struct omap_uart_s *omap2_uart_init(MemoryRegion *sysme= m, qemu_irq txdma, qemu_irq rxdma, const char *label, Chardev *chr); void omap_uart_reset(struct omap_uart_s *s); -void omap_uart_attach(struct omap_uart_s *s, Chardev *chr); =20 struct omap_mpuio_s; qemu_irq *omap_mpuio_in_get(struct omap_mpuio_s *s); --=20 2.30.2 From nobody Fri May 17 11:05:19 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1685964851928757.972403966328; Mon, 5 Jun 2023 04:34:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q68Sa-0004Tu-Vn; Mon, 05 Jun 2023 07:33:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q68SV-0004Mn-V1 for qemu-devel@nongnu.org; Mon, 05 Jun 2023 07:33:12 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q68SU-0008OY-56 for qemu-devel@nongnu.org; Mon, 05 Jun 2023 07:33:11 -0400 Received: from host86-130-37-216.range86-130.btcentralplus.com ([86.130.37.216] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q68SR-0005fJ-M6; Mon, 05 Jun 2023 12:33:07 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DAcSpmjwvpkF2flzrSx5p4R/sOCKrgCPpszY3QtnuMM=; b=rPmZhCOHPKvBT5pLXgH7u55lrg AFO8ZVRAPDoE3Wk11GNXKxl+M45ruUPFfS7EgIjnHLnUPl2W50+erwnj47G/9q/zEIwcZzF7SV59B Fl5R8Wwg3yw/xJQVEUQinFqIHpliGTfFq9ipmvNpAJdzvQ1z6EsUfnawFMwXnIHCHzl5aY+ryeK80 2ZbKLD41KTeGRj+tLW/USxEJRRvyyMA/0hKIRfQMYOnABh5Crgb+gaY8K478LrlsJm2WrjFTaB5wt y75zDenZ6d8D4DzdbxIiJUwRHtkTcfYBaQOV9ouzRgtDZlG+nhu+zNXqUUXEOBZNkTw6LinvlAqZa nrqKiW25x3ST9QWUaTYClR+YPR19qyUJ6iHshQHNtpwOpl89NCNoznwZYdrkySrr/t3paQ5suN/SE k00NnqINjxeceogJT6pfpn3Ps+4CmYgOj7BnOccNBKDkmK3eDSVp8VxW+6WP7Go1S2hAbiulzARk7 e+DZi+js6+HOhV9FIN6u6jnJhi//HwpSpMroSf9LZTCuGCtjqAC0VvwofZ49hZIL0ahdizy2KbYpp +O+pkoITcMBzh7jEE9+lLTuAOAB+svHwA+2Fx+wHOcp6AVPf64qn0MRvuMCOpWtAeSme8ykRXXC1Q zKK9y2ry+f/zFbi1Ss/tf96xZg/PqpTZRNkisYpt8=; From: Mark Cave-Ayland To: richard.henderson@linaro.org, qemu-devel@nongnu.org Date: Mon, 5 Jun 2023 12:32:53 +0100 Message-Id: <20230605113253.455937-4-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230605113253.455937-1-mark.cave-ayland@ilande.co.uk> References: <20230605113253.455937-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.130.37.216 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PULL 3/3] hw/isa/i82378: Remove unused "io" attribute X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1685964853421100001 Content-Type: text/plain; charset="utf-8" From: Bernhard Beschow The attribute isn't used since commit 5c9736789b79ea49cd236ac326f0a414f63b1= 015 "i82378: Cleanup implementation". Signed-off-by: Bernhard Beschow Acked-by: Michael S. Tsirkin Reviewed-by: Mark Cave-Ayland Message-Id: <20230523195608.125820-4-shentey@gmail.com> Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson --- hw/isa/i82378.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/isa/i82378.c b/hw/isa/i82378.c index 5432ab5065..63e0857208 100644 --- a/hw/isa/i82378.c +++ b/hw/isa/i82378.c @@ -34,7 +34,6 @@ struct I82378State { =20 qemu_irq cpu_intr; qemu_irq *isa_irqs_in; - MemoryRegion io; }; =20 static const VMStateDescription vmstate_i82378 =3D { --=20 2.30.2