target/ppc: Fix msgclrp interrupt type

[PATCH v1] target/ppc: Fix msgclrp interrupt type

Nicholas Piggin posted 1 patch 11 months, 2 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230530130714.373215-1-npiggin@gmail.com

Maintainers: Daniel Henrique Barboza <danielhb413@gmail.com>, "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>, Greg Kurz <groug@kaod.org>

target/ppc/excp_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH v1] target/ppc: Fix msgclrp interrupt type

Posted by Nicholas Piggin 11 months, 2 weeks ago

msgclrp matches msgsndp and should clear PPC_INTERRUPT_DOORBELL.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 target/ppc/excp_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index add2bc6bfe..c13f2afa04 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -3068,7 +3068,7 @@ void helper_book3s_msgclrp(CPUPPCState *env, target_ulong rb)
         return;
     }
 
-    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_HDOORBELL, 0);
+    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_DOORBELL, 0);
 }
 
 /*
-- 
2.40.1

Re: [PATCH v1] target/ppc: Fix msgclrp interrupt type

Posted by Daniel Henrique Barboza 11 months, 1 week ago


On 5/30/23 10:07, Nicholas Piggin wrote:
> msgclrp matches msgsndp and should clear PPC_INTERRUPT_DOORBELL.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---

Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,


Daniel

>   target/ppc/excp_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index add2bc6bfe..c13f2afa04 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -3068,7 +3068,7 @@ void helper_book3s_msgclrp(CPUPPCState *env, target_ulong rb)
>           return;
>       }
>   
> -    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_HDOORBELL, 0);
> +    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_DOORBELL, 0);
>   }
>   
>   /*

Re: [PATCH v1] target/ppc: Fix msgclrp interrupt type

Posted by Cédric Le Goater 11 months, 2 weeks ago

On 5/30/23 15:07, Nicholas Piggin wrote:
> msgclrp matches msgsndp and should clear PPC_INTERRUPT_DOORBELL.
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>



Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.

> ---
>   target/ppc/excp_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index add2bc6bfe..c13f2afa04 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -3068,7 +3068,7 @@ void helper_book3s_msgclrp(CPUPPCState *env, target_ulong rb)
>           return;
>       }
>   
> -    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_HDOORBELL, 0);
> +    ppc_set_irq(env_archcpu(env), PPC_INTERRUPT_DOORBELL, 0);
>   }
>   
>   /*