[v1] hw/smbios: Cleanup topology related variables

[PATCH 0/3] hw/smbios: Cleanup topology related variables

Zhao Liu posted 3 patches 11 months, 2 weeks ago

Diff against v2 v3 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230529164343.467793-1-zhao1.liu@linux.intel.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <anisinha@redhat.com>

There is a newer version of this series

hw/smbios/smbios.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)

Expand all Fold all

[PATCH 0/3] hw/smbios: Cleanup topology related variables

Posted by Zhao Liu 11 months, 2 weeks ago

From: Zhao Liu <zhao1.liu@intel.com>

Hi all,

This patchset is split from my previous hybrid topology RFC [1] for
easier review.

There are three places for topology-related cleanup:

1. Fix the use of smp.cores.

   The meaning of CPU topology members in MachineState.smp has changed
   since 003f230e37d7 ("machine: Tweak the order of topology members in
   struct CpuTopology"), but the use of smp.cores based on the original
   semantics (the number of cores in one package) has not been updated,
   so here is a cleanup.

2. Consolidate the use of MachineState.smp.

   The socket calculation can be simplified by directly using the
   MachineState.smp.sockets.

3. Fix thread count in type4.

   I also found that the definition of thread count in type4 doesn't
   match the spec (smbios 3.0.0) and cleaned it up as well.

[1]: https://mail.gnu.org/archive/html/qemu-devel/2023-02/msg03205.html


Regards,
Zhao

---
Zhao Liu (3):
  hw/smbios: Fix smbios_smp_sockets caculation
  hw/smbios: Fix thread count in type4
  hw/smbios: Fix core count in type4

 hw/smbios/smbios.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

-- 
2.34.1