[v1] Ui patches

[PULL 00/19] Ui patches

Posted by marcandre.lureau@redhat.com 11 months, 2 weeks ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

The following changes since commit ac84b57b4d74606f7f83667a0606deef32b2049d:

  Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-05-26 14:40:55 -0700)

are available in the Git repository at:

  https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request

for you to fetch changes up to 5a4cb61ae1ab0068ab53535ed0ccaf41a5e97d2f:

  ui/gtk: enable backend to send multi-touch events (2023-05-28 16:25:38 +0400)

----------------------------------------------------------------
UI queue

- virtio: add virtio-multitouch device
- sdl: various keyboard grab fixes
- gtk: enable multi-touch events
- misc fixes

----------------------------------------------------------------

Bernhard Beschow (2):
  ui/sdl2: Grab Alt+Tab also in fullscreen mode
  ui/sdl2: Grab Alt+F4 also under Windows

Erico Nunes (3):
  ui/gtk: fix passing y0_top parameter to scanout
  ui/gtk: use widget size for cursor motion event
  ui/gtk-egl: fix scaling for cursor position in scanout mode

Marc-André Lureau (6):
  ui/sdl2: fix surface_gl_update_texture: Assertion 'gls' failed
  ui/dbus: fix compilation when GBM && !OPENGL
  win32: wrap socket close() with an exception handler
  virtio-gpu: add a FIXME for virtio_gpu_load()
  gtk: add gl-area support on win32
  ui/dbus: add a FIXME about texture/dmabuf scanout handling

Mauro Matteo Cascella (1):
  ui/cursor: make width/height unsigned 16-bit integer

Sergio Lopez (6):
  virtio-input: generalize virtio_input_key_config()
  ui: add the infrastructure to support MT events
  virtio-input: add a virtio-mulitouch device
  virtio-input-pci: add virtio-multitouch-pci
  ui: add helpers for virtio-multitouch events
  ui/gtk: enable backend to send multi-touch events

Volker Rümelin (1):
  ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows

 qapi/ui.json                     |  68 ++++++++++++--
 include/hw/virtio/virtio-input.h |   9 +-
 include/sysemu/os-win32.h        |   4 +
 include/ui/console.h             |   4 +-
 include/ui/input.h               |   8 ++
 hw/display/virtio-gpu.c          |   1 +
 hw/input/virtio-input-hid.c      | 156 +++++++++++++++++++++++++++----
 hw/virtio/virtio-input-pci.c     |  25 ++++-
 replay/replay-input.c            |  18 ++++
 ui/cursor.c                      |   3 +-
 ui/dbus-listener.c               |  15 ++-
 ui/gtk-egl.c                     |   6 +-
 ui/gtk-gl-area.c                 |   2 +-
 ui/gtk.c                         | 106 ++++++++++++++++++++-
 ui/input.c                       |  42 +++++++++
 ui/sdl2-gl.c                     |   4 +
 ui/sdl2.c                        |   7 ++
 util/oslib-win32.c               |  23 +++--
 ui/trace-events                  |   1 +
 19 files changed, 442 insertions(+), 60 deletions(-)

-- 
2.40.1

Re: [PULL 00/19] Ui patches

Posted by Michael Tokarev 11 months, 2 weeks ago

28.05.2023 16:19, marcandre.lureau@redhat.com wrote:
> 
>    https://gitlab.com/marcandre.lureau/qemu.git tags/ui-pull-request
> 
> ----------------------------------------------------------------
> UI queue
> 
> - virtio: add virtio-multitouch device
> - sdl: various keyboard grab fixes
> - gtk: enable multi-touch events
> - misc fixes

 From the patch description it looks like quite a few patches should be
applied to -stable:

01/19 ui/gtk: fix passing y0_top parameter to scanout
02/19 ui/gtk: use widget size for cursor motion event
03/19 ui/gtk-egl: fix scaling for cursor position in scanout mode
04/19 ui/sdl2: fix surface_gl_update_texture: Assertion 'gls' failed
05/19 ui/dbus: fix compilation when GBM && !OPENGL
10/19 ui/sdl2: Grab Alt+Tab also in fullscreen mode
11/19 ui/sdl2: Grab Alt+F4 also under Windows
12/19 ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows

This one is questionable because while it (apparently) fixes an issue,
it uses somewhat undocumented way to do that:

06/19 win32: wrap socket close() with an exception handler

Am I right about the -stable thing?

Please add "Cc: qemu-stable@nongnu.org" tag for subsequent patches
which you think are worth to backport to previous/stable qemu release(s).

Thanks!

/mjt

> ----------------------------------------------------------------
> 
> Bernhard Beschow (2):
>    ui/sdl2: Grab Alt+Tab also in fullscreen mode
>    ui/sdl2: Grab Alt+F4 also under Windows
> 
> Erico Nunes (3):
>    ui/gtk: fix passing y0_top parameter to scanout
>    ui/gtk: use widget size for cursor motion event
>    ui/gtk-egl: fix scaling for cursor position in scanout mode
> 
> Marc-André Lureau (6):
>    ui/sdl2: fix surface_gl_update_texture: Assertion 'gls' failed
>    ui/dbus: fix compilation when GBM && !OPENGL
>    win32: wrap socket close() with an exception handler
>    virtio-gpu: add a FIXME for virtio_gpu_load()
>    gtk: add gl-area support on win32
>    ui/dbus: add a FIXME about texture/dmabuf scanout handling
> 
> Mauro Matteo Cascella (1):
>    ui/cursor: make width/height unsigned 16-bit integer
> 
> Sergio Lopez (6):
>    virtio-input: generalize virtio_input_key_config()
>    ui: add the infrastructure to support MT events
>    virtio-input: add a virtio-mulitouch device
>    virtio-input-pci: add virtio-multitouch-pci
>    ui: add helpers for virtio-multitouch events
>    ui/gtk: enable backend to send multi-touch events
> 
> Volker Rümelin (1):
>    ui/sdl2: disable SDL_HINT_GRAB_KEYBOARD on Windows
>

Re: [PULL 00/19] Ui patches

Posted by Richard Henderson 11 months, 2 weeks ago

On 5/28/23 06:19, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau<marcandre.lureau@redhat.com>
> 
> The following changes since commit ac84b57b4d74606f7f83667a0606deef32b2049d:
> 
>    Merge tag 'for-upstream' ofhttps://gitlab.com/bonzini/qemu  into staging (2023-05-26 14:40:55 -0700)
> 
> are available in the Git repository at:
> 
>    https://gitlab.com/marcandre.lureau/qemu.git  tags/ui-pull-request
> 
> for you to fetch changes up to 5a4cb61ae1ab0068ab53535ed0ccaf41a5e97d2f:
> 
>    ui/gtk: enable backend to send multi-touch events (2023-05-28 16:25:38 +0400)
> 
> ----------------------------------------------------------------
> UI queue
> 
> - virtio: add virtio-multitouch device
> - sdl: various keyboard grab fixes
> - gtk: enable multi-touch events
> - misc fixes

Applied, thanks.  Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate.


r~