On Wed, May 17, 2023, 12:34 PM John Snow <jsnow@redhat.com> wrote:
> This is a small patchset designed to backport the changes made to the
> qemu.qmp code to utilize pre-existing sockets. This contains some small
> changes to machine.py to match the new API. This is necessary to do
> before dropping qemu.qmp from qemu.git so we can utilize the future
> 0.0.3 version of qemu.qmp.
>
> (This should also fix the bug where the buffering limit was not being
> applied properly
^to
connections utilizing pre-existing sockets.)
>
> John Snow (5):
> python/qmp: allow sockets to be passed to connect()
> python/qmp/legacy: allow using sockets for connect()
> python/machine: use connect-based interface for existing sockets
> python/qmp/legacy: remove open_with_socket() calls
> Revert "python/qmp/protocol: add open_with_socket()"
>
> python/qemu/machine/machine.py | 17 +++++++------
> python/qemu/qmp/legacy.py | 26 +++++++++-----------
> python/qemu/qmp/protocol.py | 45 +++++++++++++++-------------------
> 3 files changed, 41 insertions(+), 47 deletions(-)
>
> --
> 2.40.0
>
ping - I'll send a PR for this on Friday if no objections. It just
synchronizes the two codebases ahead of my plan to finally delete the
duplication once and for all.
(and *that* series will need some good review and attention.)
--js
>