From nobody Wed May 15 19:17:21 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1684157160; cv=none; d=zohomail.com; s=zohoarc; b=KHmckfKG0bnT1Hdkd/wZCdk0Ciyz2Whm4Jo1bWQ+HlYDnI+Vunpv3xQ+kAOhwD0dCE0yTrZ+NmTDY2gFI8XDhT059EznDmWd3O1lwtgtxtg60cnBcjf92W9R1bjryGIs100qes40dJyngpDaaaPCBOnyp5Joby2pA6ghB8DzKaw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1684157160; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=S9o0QNevMqpddJMHQq11zj9p18/ClEXY/7rpkbkNk9w=; b=P4D8O7y4Z5dStEkJm6zN4Q3rwS5PvGvNJlMoYoh7OkmwiVlS6qglkrjHwOHKI0qyzqWi/AC7gzU+O1eh+LqLy3XuRg6veIc1qCLrsx0NF2Bk4AdLuGPfYE50Utjp1VJL5btuCqZ6S0GmxG3OGBEadW1omGfg+tHUtZbHFD2w4Go= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1684157160358577.0077208419056; Mon, 15 May 2023 06:26:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyYD0-0001t0-M8; Mon, 15 May 2023 09:25:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyYCu-0001ke-8L for qemu-devel@nongnu.org; Mon, 15 May 2023 09:25:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyYCs-00064c-R9 for qemu-devel@nongnu.org; Mon, 15 May 2023 09:25:44 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-78-foTUavDfPgaeH9kcUqgFiw-1; Mon, 15 May 2023 09:25:40 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9070E3823A02 for ; Mon, 15 May 2023 13:25:40 +0000 (UTC) Received: from localhost (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id A068140C6EC4; Mon, 15 May 2023 13:25:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684157142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=S9o0QNevMqpddJMHQq11zj9p18/ClEXY/7rpkbkNk9w=; b=JDau+jaBdX14LcL8d98AosJnea8XSRhcTxaQYr6XBH52nutf3Z+21mvg7oSPu4VLD36GMm BjZJMeiTkYm+GSsY+92IH9NZNaAnUbr5wQ2hA6dCTfJDB8Dr48gyOIRVfIOvexYMjAe2nx T8ybhQayYuGqLNkwsTZgTcEj5AVFCoA= X-MC-Unique: foTUavDfPgaeH9kcUqgFiw-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: kraxel@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH] ui/dbus: add a FIXME about texture/dmabuf scanout handling Date: Mon, 15 May 2023 17:25:36 +0400 Message-Id: <20230515132537.1026310-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1684157162148100003 From: Marc-Andr=C3=A9 Lureau Except SDL, display backends seem to fail at handing full scanout geometry correctly. It would need some test/reproducer to actually check it. In the meantime, fill some missing fields, and leave a FIXME. Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/dbus-listener.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index defe2220c0..23034eebf9 100644 --- a/ui/dbus-listener.c +++ b/ui/dbus-listener.c @@ -102,6 +102,7 @@ static void dbus_scanout_dmabuf(DisplayChangeListener *= dcl, return; } =20 + /* FIXME: add missing x/y/w/h support */ qemu_dbus_display1_listener_call_scanout_dmabuf( ddl->proxy, g_variant_new_handle(0), @@ -129,6 +130,10 @@ static void dbus_scanout_texture(DisplayChangeListener= *dcl, .width =3D backing_width, .height =3D backing_height, .y0_top =3D backing_y_0_top, + .x =3D x, + .y =3D y, + .scanout_width =3D w, + .scanout_height =3D h, }; =20 assert(tex_id); --=20 2.40.1