[v3] vhost: register and change IOMMU flag depending on ATS state

[PATCH v3 0/3] vhost: register and change IOMMU flag depending on ATS state

Viktor Prutyanov posted 3 patches 11 months, 3 weeks ago

Diff against v1 v2 v4 v5
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230512135122.70403-1-viktor@daynix.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>

There is a newer version of this series

hw/net/vhost_net.c                | 11 ++++++++++
hw/net/virtio-net.c               |  7 +++++++
hw/virtio/vhost-backend.c         |  6 ++++++
hw/virtio/vhost.c                 | 30 +++++++++++++++-----------
hw/virtio/virtio-pci.c            | 35 +++++++++++++++++++++++++++++++
include/hw/virtio/vhost-backend.h |  3 +++
include/hw/virtio/vhost.h         |  1 +
include/hw/virtio/virtio.h        |  2 ++
include/net/vhost_net.h           |  2 ++
9 files changed, 85 insertions(+), 12 deletions(-)

Expand all Fold all

[PATCH v3 0/3] vhost: register and change IOMMU flag depending on ATS state

Posted by Viktor Prutyanov 11 months, 3 weeks ago

When IOMMU and vhost are enabled together, QEMU tracks IOTLB or
Device-TLB unmap events depending on whether Device-TLB is enabled. But
even if Device-TLB and PCI ATS is enabled, the guest can reject to use
it. For example, this situation appears when Windows Server 2022 is
running with intel-iommu with device-iotlb=on and virtio-net-pci with
vhost=on. The guest implies that no address translation info cached in
device IOTLB and doesn't send device IOTLB invalidation commands. So,
it leads to irrelevant address translations in vhost-net in the host
kernel. Therefore network frames from the guest in host tap interface
contains wrong payload data.

This series adds checking of ATS state for proper unmap flag register
(IOMMU_NOTIFIER_UNMAP or IOMMU_NOTIFIER_DEVIOTLB_UNMAP).

Tested on Windows Server 2022, Windows 11 and Fedora guests with
 -device virtio-net-pci,bus=pci.3,netdev=nd0,iommu_platform=on,ats=on
 -netdev tap,id=nd0,ifname=tap1,script=no,downscript=no,vhost=on
 -device intel-iommu,intremap=on,eim=on,device-iotlb=on/off

Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2001312

v3: call virtio_pci_ats_ctrl_trigger directly, remove
    IOMMU_NOTIFIER_UNMAP fallbacks
v2: remove memory_region_iommu_notify_flags_changed, move trigger to
    VirtioDeviceClass, use vhost_ops, use device_iotlb name

Viktor Prutyanov (3):
  virtio-pci: add handling of PCI ATS and Device-TLB enable/disable
  vhost: register and change IOMMU flag depending on Device-TLB state
  virtio-net: pass Device-TLB enable/disable events to vhost

 hw/net/vhost_net.c                | 11 ++++++++++
 hw/net/virtio-net.c               |  7 +++++++
 hw/virtio/vhost-backend.c         |  6 ++++++
 hw/virtio/vhost.c                 | 30 +++++++++++++++-----------
 hw/virtio/virtio-pci.c            | 35 +++++++++++++++++++++++++++++++
 include/hw/virtio/vhost-backend.h |  3 +++
 include/hw/virtio/vhost.h         |  1 +
 include/hw/virtio/virtio.h        |  2 ++
 include/net/vhost_net.h           |  2 ++
 9 files changed, 85 insertions(+), 12 deletions(-)


-- 
2.35.1