hw/arm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Qemu does not support qxl graphics cards in arm, it is recommended to enable
Signed-off-by: Hao Zeng <zenghao@kylinos.cn>
---
hw/arm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
index 0f42c556d7..0305a4f4f3 100644
--- a/hw/arm/Kconfig
+++ b/hw/arm/Kconfig
@@ -32,7 +32,7 @@ config ARM_VIRT
select VIRTIO_MEM_SUPPORTED
select ACPI_CXL
select ACPI_HMAT
-
+ select QXL
config CHEETAH
bool
default y if TCG && ARM
--
2.37.2
On Fri, 12 May 2023 17:08:03 +0800 Hao Zeng <zenghao@kylinos.cn> wrote: > Qemu does not support qxl graphics cards in arm, it is recommended to enable > > Signed-off-by: Hao Zeng <zenghao@kylinos.cn> Drive by comment. > --- > hw/arm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > index 0f42c556d7..0305a4f4f3 100644 > --- a/hw/arm/Kconfig > +++ b/hw/arm/Kconfig > @@ -32,7 +32,7 @@ config ARM_VIRT > select VIRTIO_MEM_SUPPORTED > select ACPI_CXL > select ACPI_HMAT > - > + select QXL Keep the blank line here. > config CHEETAH > bool > default y if TCG && ARM
On Fri, 12 May 2023 at 10:11, Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote: > > On Fri, 12 May 2023 17:08:03 +0800 > Hao Zeng <zenghao@kylinos.cn> wrote: > > > Qemu does not support qxl graphics cards in arm, it is recommended to enable > > > > Signed-off-by: Hao Zeng <zenghao@kylinos.cn> > > Drive by comment. > > > --- > > hw/arm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > > index 0f42c556d7..0305a4f4f3 100644 > > --- a/hw/arm/Kconfig > > +++ b/hw/arm/Kconfig > > @@ -32,7 +32,7 @@ config ARM_VIRT > > select VIRTIO_MEM_SUPPORTED > > select ACPI_CXL > > select ACPI_HMAT > > - > > + select QXL > Keep the blank line here. I don't understand why QXL is special here -- isn't it just another PCI card? We already "imply PCI_DEVICES" so I would have expected that to work. I notice that the x86 "config PC" has an "imply QXL", though, so presumably it doesn't. Paolo, should this be fixed by making PCI_DEVICES pull in QXL, or by adding an "imply QXL" to the virt board ? As a third option, the mips "config LOONGSON3V" has "imply QXL if SPICE". I don't know what the right answer is here, but I suspect it should be the same thing in all three cases, not three different things :-) thanks -- PMM
On 12/5/23 11:56, Peter Maydell wrote: > On Fri, 12 May 2023 at 10:11, Jonathan Cameron > <Jonathan.Cameron@huawei.com> wrote: >> >> On Fri, 12 May 2023 17:08:03 +0800 >> Hao Zeng <zenghao@kylinos.cn> wrote: >> >>> Qemu does not support qxl graphics cards in arm, it is recommended to enable >>> >>> Signed-off-by: Hao Zeng <zenghao@kylinos.cn> >> >> Drive by comment. >> >>> --- >>> hw/arm/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig >>> index 0f42c556d7..0305a4f4f3 100644 >>> --- a/hw/arm/Kconfig >>> +++ b/hw/arm/Kconfig >>> @@ -32,7 +32,7 @@ config ARM_VIRT >>> select VIRTIO_MEM_SUPPORTED >>> select ACPI_CXL >>> select ACPI_HMAT >>> - >>> + select QXL >> Keep the blank line here. > > I don't understand why QXL is special here -- isn't it > just another PCI card? We already "imply PCI_DEVICES" > so I would have expected that to work. > > I notice that the x86 "config PC" has an "imply QXL", > though, so presumably it doesn't. Paolo, should this > be fixed by making PCI_DEVICES pull in QXL, or by > adding an "imply QXL" to the virt board ? > > As a third option, the mips "config LOONGSON3V" > has "imply QXL if SPICE". > > I don't know what the right answer is here, but I > suspect it should be the same thing in all three > cases, not three different things :-) I'm also confused because we already have in hw/display/Kconfig: config QXL bool depends on SPICE && PCI
© 2016 - 2024 Red Hat, Inc.