Makefile: include gtags in UNCHECKED_GOALS

[RFC PATCH] Makefile: include gtags in UNCHECKED_GOALS

Alex Bennée posted 1 patch 11 months, 4 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230511165640.1862868-1-alex.bennee@linaro.org

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>

Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[RFC PATCH] Makefile: include gtags in UNCHECKED_GOALS

Posted by Alex Bennée 11 months, 4 weeks ago

This is the mechanism we use to avoid defaulting to a build dir when
we don't need to.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index e421f8a1f4..c566aeb418 100644
--- a/Makefile
+++ b/Makefile
@@ -26,7 +26,7 @@ quiet-command-run = $(if $(V),,$(if $2,printf "  %-7s %s\n" $2 $3 && ))$1
 quiet-@ = $(if $(V),,@)
 quiet-command = $(quiet-@)$(call quiet-command-run,$1,$2,$3)
 
-UNCHECKED_GOALS := %clean TAGS cscope ctags dist \
+UNCHECKED_GOALS := %clean TAGS cscope ctags gtags dist \
     help check-help print-% \
     docker docker-% vm-help vm-test vm-build-%
 
-- 
2.39.2

Re: [RFC PATCH] Makefile: include gtags in UNCHECKED_GOALS

Posted by Paolo Bonzini 11 months, 4 weeks ago

Il gio 11 mag 2023, 18:56 Alex Bennée <alex.bennee@linaro.org> ha scritto:

> This is the mechanism we use to avoid defaulting to a build dir when
> we don't need to.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>

I had already squashed this into Steven Sistare's recently posted patch,
which otherwise would have broken the "pages" job in CI.

Paolo

---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index e421f8a1f4..c566aeb418 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -26,7 +26,7 @@ quiet-command-run = $(if $(V),,$(if $2,printf "  %-7s
> %s\n" $2 $3 && ))$1
>  quiet-@ = $(if $(V),,@)
>  quiet-command = $(quiet-@)$(call quiet-command-run,$1,$2,$3)
>
> -UNCHECKED_GOALS := %clean TAGS cscope ctags dist \
> +UNCHECKED_GOALS := %clean TAGS cscope ctags gtags dist \
>      help check-help print-% \
>      docker docker-% vm-help vm-test vm-build-%
>
> --
> 2.39.2
>
>

Re: [RFC PATCH] Makefile: include gtags in UNCHECKED_GOALS

Posted by Alex Bennée 11 months, 4 weeks ago

Paolo Bonzini <pbonzini@redhat.com> writes:

> Il gio 11 mag 2023, 18:56 Alex Bennée <alex.bennee@linaro.org> ha scritto:
>
>  This is the mechanism we use to avoid defaulting to a build dir when
>  we don't need to.
>
>  Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> I had already squashed this into Steven Sistare's recently posted patch, which otherwise would have broken the
> "pages" job in CI.

\o/

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro