From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795503031891.5632672872896; Thu, 11 May 2023 01:58:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px27j-00047K-Ua; Thu, 11 May 2023 04:58:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27h-000477-F7 for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:05 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27e-0003gV-W6 for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:05 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px26d-0008g9-Id; Thu, 11 May 2023 09:57:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fajwXgdO+2h/QETYDefjM+uV1sToydfzaBMv1C+hkT8=; b=OOX/mQcXP4NYdSRLPOHyxAX09L pdirPKtb/aWv8/5WOSFlJj2ymt7L/toO7kcaazV8a3xMyot/bmwaEvdquXF7d7ZB0GKrAJQ9LSYRG NxWwSuy4AO/jL7uTJ6d5L6XrYB/N4y7ZPG3Weouy/Kq0PdMbqLYtf7bRidvpRL7lNj6bT194xVq9k 3BFnskzLcI3kJrP8vwpe5ZuST8jhB0zIsdlEaQsnUBDWqCQQChX/wYYOSXI5xAHmXKMyGMjK2fZ8/ 2veG7OzE7SUlVWodNPrnoPYP/rx+XcTYC79qvSQsoWXNlvLbPvKp2mRD6NNw6v9hq9twFsRUxfdvl aN137B+XJetLvZlGdvrQowHHvaWQxckmGVcyTIaF0lSeDsjxeIYF7jZpzFpXOkqlCLUntXcnw0HNp BvLXKVJYSuUiiFOGMkoCTDfYlxCixxCPVhS0CbBjOPFrAPoy7jx353bXL0IIi6akQ20vBGItlqKV5 VobfFMebvcRNQ0ER9nHiHBw3pbRuQZ38SNvdkTrPgPrL1LuGUMX1jQPtZCt7CIetq7r+jotoCCmgp aZ7Q1XrOT9twb2vFqf5hnsrdWsUQrON2Ue4wfg4YRuCeaOD2AdWQb3VfIdojfEop85Zts/tl77lkS 6WsO2wnHqq/2BAQm6Sj1hyi7MTPCQYHH+PhBRbJ/g=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:14 +0100 Message-Id: <20230511085731.171565-2-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 01/18] hw/pci: add device IRQ to PCIDevice X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795505044100003 Content-Type: text/plain; charset="utf-8" Introduce pci_device_init() and use it to initialise an output IRQ. Signed-off-by: Mark Cave-Ayland --- hw/pci/pci.c | 8 ++++++++ include/hw/pci/pci_device.h | 3 +++ 2 files changed, 11 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 8a87ccc8b0..f29ac20895 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -2161,6 +2161,13 @@ static void pci_qdev_realize(DeviceState *qdev, Erro= r **errp) pci_dev->msi_trigger =3D pci_msi_trigger; } =20 +static void pci_device_init(Object *obj) +{ + PCIDevice *pci_dev =3D PCI_DEVICE(obj); + + qdev_init_gpio_out(DEVICE(obj), &pci_dev->irq, 1); +} + PCIDevice *pci_new_multifunction(int devfn, bool multifunction, const char *name) { @@ -2812,6 +2819,7 @@ void pci_set_power(PCIDevice *d, bool state) static const TypeInfo pci_device_type_info =3D { .name =3D TYPE_PCI_DEVICE, .parent =3D TYPE_DEVICE, + .instance_init =3D pci_device_init, .instance_size =3D sizeof(PCIDevice), .abstract =3D true, .class_size =3D sizeof(PCIDeviceClass), diff --git a/include/hw/pci/pci_device.h b/include/hw/pci/pci_device.h index d3dd0f64b2..2c6dca5d15 100644 --- a/include/hw/pci/pci_device.h +++ b/include/hw/pci/pci_device.h @@ -149,6 +149,9 @@ struct PCIDevice { MemoryRegion rom; uint32_t rom_bar; =20 + /* PCI IRQ */ + qemu_irq irq; + /* INTx routing notifier */ PCIINTxRoutingNotifier intx_routing_notifier; =20 --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795537444989.9943192028547; Thu, 11 May 2023 01:58:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px282-0004aw-05; Thu, 11 May 2023 04:58:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27w-0004G0-41 for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:20 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27j-0003gy-Ff for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:19 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px26h-0008g9-RU; Thu, 11 May 2023 09:57:07 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=efo8aqdQd5QiTEo966f0QgTBbUevcQb0wEYOlvuPvdk=; b=dBKeNS/u2vAVRNq3JiL47othfM 0QCHz7F6L6QEQlUyJEs254jLPsDySG2vFsGbLDpMiyl5t9BzHsdNKuznp5ncdCWAbP1l4KK01ZbNx F1/AKLoOly0WGiSB8C+c17pEBZWxnUqRiUAiuQ20cVhP2IUAmaBRfe6jSeyOdo6Wk6oX/Sv4MpKDd MvPw908IGK8PXMWlL41AZ2yIs8e0jpUHGp7r0lYvR3Z8YMRHDm5rJqfCWeuF+SchfNY+lJaHEm7ot 7/unTn6DvT1M6N/iAUgHHHfpW8m08ZjTPsvISqzlPXEK29LpiR+7lrEkX8MvnWdEojUgf61e9bVjn 76W5TQy4fEBw+MnEobAvRu5g1vRkPanxYrDFIDP3q7e02LawChdBXyQ+YOIkBKrGqxfvMEuY6Ootu YRw94VF1mIl1/NP/pENH36ylO7sLsD5PvmK3Mxd7RvCUPHMdqOQRxEjnWRbncxZ2SDFJmG7agddsl ruPEGD8z/kGOxpTHrVI/NGX5KVvd/ij+TIeXNqH961tsL9dpVEKg2aJrdyvz4jIrKKkCHnNLqWLWk ay78hKZlFLNOBVXVTRF9inSGyPQQjPkL5IfGgECchM5H+8pwW3rvQ0dy0LF66UeDqByvhaFv7pgBX R2YM+scbUiQrSo3pus8E+z3ZcnGCytrO+NLMHF6C4=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:15 +0100 Message-Id: <20230511085731.171565-3-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 02/18] hw/pci: introduce PCI bus input IRQs X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795538744100005 Content-Type: text/plain; charset="utf-8" Introduce a new pci_bus_irq_handler input IRQ handler that can be triggered= by each unique PCI devfn on the bus. Add a new pci_bus_init() instance init function to initialise the IRQ array and a corresponding pci_bus_finalize() instance finalize function to free it. Signed-off-by: Mark Cave-Ayland --- hw/pci/pci.c | 34 ++++++++++++++++++++++++++++++++++ include/hw/pci/pci_bus.h | 3 +++ 2 files changed, 37 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index f29ac20895..9471f996a7 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -179,6 +179,24 @@ static void pci_bus_unrealize(BusState *qbus) vmstate_unregister(NULL, &vmstate_pcibus, bus); } =20 +static void pci_bus_irq_handler(void *opaque, int devfn, int level); + +static void pci_bus_init(Object *obj) +{ + PCIBus *bus =3D PCI_BUS(obj); + + /* IRQs */ + bus->irq_in =3D qemu_allocate_irqs(pci_bus_irq_handler, bus, + PCI_SLOT_MAX * PCI_FUNC_MAX); +} + +static void pci_bus_finalize(Object *obj) +{ + PCIBus *bus =3D PCI_BUS(obj); + + qemu_free_irqs(bus->irq_in, PCI_SLOT_MAX * PCI_FUNC_MAX); +} + static int pcibus_num(PCIBus *bus) { if (pci_bus_is_root(bus)) { @@ -211,7 +229,9 @@ static void pci_bus_class_init(ObjectClass *klass, void= *data) static const TypeInfo pci_bus_info =3D { .name =3D TYPE_PCI_BUS, .parent =3D TYPE_BUS, + .instance_init =3D pci_bus_init, .instance_size =3D sizeof(PCIBus), + .instance_finalize =3D pci_bus_finalize, .class_size =3D sizeof(PCIBusClass), .class_init =3D pci_bus_class_init, }; @@ -1636,6 +1656,20 @@ static void pci_irq_handler(void *opaque, int irq_nu= m, int level) pci_change_irq_level(pci_dev, irq_num, change); } =20 +/* Bus IRQ handler */ +static void pci_bus_irq_handler(void *opaque, int devfn, int level) +{ + PCIBus *bus =3D PCI_BUS(opaque); + PCIDevice *pci_dev; + int intx; + + assert(0 <=3D devfn && devfn < PCI_SLOT_MAX * PCI_FUNC_MAX); + pci_dev =3D bus->devices[devfn]; + intx =3D pci_intx(pci_dev); + + pci_irq_handler(pci_dev, intx, level); +} + qemu_irq pci_allocate_irq(PCIDevice *pci_dev) { int intx =3D pci_intx(pci_dev); diff --git a/include/hw/pci/pci_bus.h b/include/hw/pci/pci_bus.h index 5653175957..8486df283e 100644 --- a/include/hw/pci/pci_bus.h +++ b/include/hw/pci/pci_bus.h @@ -54,6 +54,9 @@ struct PCIBus { int nirq; int *irq_count; =20 + /* Bus IRQ handler */ + qemu_irq *irq_in; + Notifier machine_done; }; =20 --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795592290384.78303607782266; Thu, 11 May 2023 01:59:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px27x-0004Gk-Ee; Thu, 11 May 2023 04:58:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27t-0004Ev-Tm for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:17 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27p-0003hF-Jm for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:17 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px26m-0008g9-6G; Thu, 11 May 2023 09:57:12 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3u/nBDxJoh2ZGhXp1zW5w+IiSILY9g5pFaCFN6IV4/o=; b=gS5FuMvIf3dcpQCmuYN3oQ5bvP dPZYnl11ExC6ZT0IiIHhG1mBkDm3EYeQduz1MWDEhVHvOWyUUga73G5+DWOS9re4gXH01/x5v/1DM OPIqihLyO5HhdgcueASfjWnGrw2XtWm5Ao9RD95sHAk1kwUgHGvQATu6mrEDX0OY0xVuw/PdOJUQL tiwi81XlQ550fv+XAOecn2Av5/bar99gfwjpnYGS1nwv/3/Hxy+5gGVztXLqc+K2CNzTpMjHH/mLg MQyYW/UQLHvbI6av9THdbON+ro1hLDbKiYcsvgUFdkEqmEXikEOaNbwzYNByWL53vlTiUzCwH2LQO DLbzoZmOmcCULQJ+JJuyJsxKx1cQA+8oXfN3kNapaFw0ZSYPe+TOIFKwbKYXILzQGWuTPnrImB8u+ 2lMoyYwf/7ciPe3qWvHx0XUlWFst8LNqC+/D6q3gaKPRz7gfDN0KgLVweHuqeIrSlPTx2aZZHqltf z+C++S0L6PDo9gbzYS7dRG7W7rBCZtsZbBDdyvBLgDAqtEcx56VCA0iYlLXL9631/JpSN/Wc2RaQ0 4V3Nss/5zZT70jOaSayfgEN+FLnD0VJZMPPzjcIbal/SoVr/u7WkmbkjWqUMp+0lvPPB+WLlrTCKs HlS0K+678jh3IABFzAK/yiUXBnfJLXPUndBHJrz4c=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:16 +0100 Message-Id: <20230511085731.171565-4-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 03/18] hw/pci: use PCIDevice gpio for device IRQ X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795593006100003 Content-Type: text/plain; charset="utf-8" Change pci_set_irq() to call qemu_set_irq() on the PCI device IRQ rather th= an calling PCI bus IRQ handler function directly. In order to preserve the existing behaviour update pci_qdev_realize() so that it automatically conne= cts the PCI device IRQ to the PCI bus IRQ handler. Finally add a "QEMU interface" description documenting the new PCI device I= RQ gpio next to the declaration of TYPE_PCI_DEVICE. Signed-off-by: Mark Cave-Ayland --- hw/pci/pci.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 9471f996a7..3da1481eb5 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1680,8 +1680,7 @@ qemu_irq pci_allocate_irq(PCIDevice *pci_dev) =20 void pci_set_irq(PCIDevice *pci_dev, int level) { - int intx =3D pci_intx(pci_dev); - pci_irq_handler(pci_dev, intx, level); + qemu_set_irq(pci_dev->irq, level); } =20 /* Special hooks used by device assignment */ @@ -2193,6 +2192,10 @@ static void pci_qdev_realize(DeviceState *qdev, Erro= r **errp) pci_set_power(pci_dev, true); =20 pci_dev->msi_trigger =3D pci_msi_trigger; + + /* Connect device IRQ to bus */ + qdev_connect_gpio_out(DEVICE(pci_dev), 0, + pci_get_bus(pci_dev)->irq_in[pci_dev->devfn]); } =20 static void pci_device_init(Object *obj) @@ -2850,6 +2853,11 @@ void pci_set_power(PCIDevice *d, bool state) } } =20 +/* + * QEMU interface: + * + Unnamed GPIO output: set to 1 if the PCI Device has asserted its irq + */ + static const TypeInfo pci_device_type_info =3D { .name =3D TYPE_PCI_DEVICE, .parent =3D TYPE_DEVICE, --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795517924251.34259210758273; Thu, 11 May 2023 01:58:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px27w-0004Ff-TW; Thu, 11 May 2023 04:58:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27t-0004Eu-TO for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:17 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27o-0003he-0t for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:17 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px26q-0008g9-Fe; Thu, 11 May 2023 09:57:12 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/JSnfxCc80zfcgdeLDZ2HGsYKX8LoQDWvUZrrO7CcXE=; b=Jp6KxHmE91fryplBW4c4LNKYm5 HabiRfqN8CVOXMKMBJZzGd+Ta6AtAn2WXnXEuhNSQ3zvzDafCfL2kJtMIcgxfr6NkATk/h+J+oOdz NJiFoDG4HN7OdzGKGDp5M6VGkQ98HY/hWR0qTaJyrGIglnsgfnQP7bFBjDu4PgHYlcQOORv7KULLl H1ApPzO+lRzNy7mcAsRSnbx6+zmglakXjWc2UotWbeHkRMPJk4HNSO+lp2CPZ/pLqoORggfAa0GB+ SRlWztgJ/iUp5fZJLzmyM7PMaG4GeJhZgzCnk0JNMSqmyKXfKb4eLzj0a4y1WDd1nohCXbvwadR6r 0gSjsxzNGuW7T1c7DMuUjOAOH2SQIMRKNjnm+hYHiQjeoDtUMSRdr/3qEoowlWBANLCzQ4v2Gc0lD Ph8spAAux2lqHZVORPd2tpk7m0UE1BJhAXSI8SZqMcregdOjMnNkGMy1GxvOSx/iLt/2mKxHObeHs etEuagPyWsBoxhrouKvvnHz+SFSlRPsxdD0TTf3GRvx9D4xaXMdYM6yV66hz8+0Y8OHFOAXzDwvg6 GpKKTeudCQ+ye4DSv6T2Y82p05FHxznyeXWI9IuAr07bqE+10U4lEPwIhBdjGU4cT/ujBeIKTQfbS XC6KDsJbAw7UKMcwDJHY1oLswxe0RXA2XsWE0KhSU=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:17 +0100 Message-Id: <20230511085731.171565-5-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 04/18] hw/pci: introduce PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795518655100001 Content-Type: text/plain; charset="utf-8" This is to allow other devices to drive the PCI device IRQ if required. Signed-off-by: Mark Cave-Ayland --- hw/pci/pci.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 3da1481eb5..0dd3b24b62 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1683,6 +1683,13 @@ void pci_set_irq(PCIDevice *pci_dev, int level) qemu_set_irq(pci_dev->irq, level); } =20 +static void pci_device_input_irq_handler(void *opaque, int n, int level) +{ + PCIDevice *pci_dev =3D PCI_DEVICE(opaque); + + pci_set_irq(pci_dev, level); +} + /* Special hooks used by device assignment */ void pci_bus_set_route_irq_fn(PCIBus *bus, pci_route_irq_fn route_intx_to_= irq) { @@ -2203,6 +2210,8 @@ static void pci_device_init(Object *obj) PCIDevice *pci_dev =3D PCI_DEVICE(obj); =20 qdev_init_gpio_out(DEVICE(obj), &pci_dev->irq, 1); + qdev_init_gpio_in_named(DEVICE(obj), pci_device_input_irq_handler, + "pci-input-irq", 1); } =20 PCIDevice *pci_new_multifunction(int devfn, bool multifunction, @@ -2856,6 +2865,8 @@ void pci_set_power(PCIDevice *d, bool state) /* * QEMU interface: * + Unnamed GPIO output: set to 1 if the PCI Device has asserted its irq + * + Named GPIO input "pci-input-irq": set to 1 if a downstream device + * wishes to assert the PCI Device irq directly itself (optional) */ =20 static const TypeInfo pci_device_type_info =3D { --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795537492463.84041583762144; Thu, 11 May 2023 01:58:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px280-0004UF-6y; Thu, 11 May 2023 04:58:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27v-0004FL-4Y for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:19 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27t-0003kp-Jj for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:18 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px26q-0008g9-ST; Thu, 11 May 2023 09:57:16 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yunaipr1ei5zCdNDkaJkhpf8o3wPnHYfKVAQjazTc0E=; b=sd5PIKek8PITgk5KpZ/9zvxmz+ nw4YZLI1w/KrnwgrxcAj0OsoSYk0gnzvzQfC4QBrva1H25Pi2aPNvNQplCvnMSnYrV2lcj+XcZDH8 95erLplAMfNEf/RbmxGfuyeCfH1vRj5MmffpF5N01s7gderqbeU24NCDzJZyu1dCUtsyJejZHXrtp Anx8Qny/A0IJLwD6GhvHKkh2C8iYkFJMCA7NNGNPFl3aDcFPR3tiPQhXugCioxQrI73DFPDjBOcXT th5L3pp8shsT66T9r3Rj6BgaO4AenLHwIwn+RhxFgKPMbEtJxm2xBzdtAIKCvAYsIHiqlzgfrHiG6 NpQD2iX9nBqFCz0QMvvdvvSl2e3MLkPAVHxScchghSSkLtmobgQ3NOkj8otsFclGSmoWTX51mTkPa 2eeiEJiaccTyhaqBf+orbDJD+8N1bOos4MH3tyWa7W+FN4pFi6N5T3QOqFWSmY6xAwNO/QW0KmabX YwroURJ4h89Ug/j+hsBqSquE7foeulDAuWuJzzxk0bSXW6DIHzb4V9ef1iGlEz9wc5PBd4gW1zFQe eDbnzCvvv9euP3c88gOCqXViC+wkSvLSGX0anI3JVdjpq2namQYgOcXdgMd/QdZYb5sxYxlgBNict /9mFgg1LII8M6fQTS1RgrahHCzrS8hM21SI7+zKwg=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:18 +0100 Message-Id: <20230511085731.171565-6-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 05/18] hw/char/serial-pci.c: switch SerialState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795538759100006 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq() and also allows the correspond= ing qemu_free_irq() to be removed. Signed-off-by: Mark Cave-Ayland --- hw/char/serial-pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/char/serial-pci.c b/hw/char/serial-pci.c index 087da3059a..cd7e8b5b94 100644 --- a/hw/char/serial-pci.c +++ b/hw/char/serial-pci.c @@ -55,7 +55,7 @@ static void serial_pci_realize(PCIDevice *dev, Error **er= rp) =20 pci->dev.config[PCI_CLASS_PROG] =3D pci->prog_if; pci->dev.config[PCI_INTERRUPT_PIN] =3D 0x01; - s->irq =3D pci_allocate_irq(&pci->dev); + s->irq =3D qdev_get_gpio_in_named(DEVICE(dev), "pci-input-irq", 0); =20 memory_region_init_io(&s->io, OBJECT(pci), &serial_io_ops, s, "serial"= , 8); pci_register_bar(&pci->dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &s->io); @@ -67,7 +67,6 @@ static void serial_pci_exit(PCIDevice *dev) SerialState *s =3D &pci->state; =20 qdev_unrealize(DEVICE(s)); - qemu_free_irq(s->irq); } =20 static const VMStateDescription vmstate_pci_serial =3D { --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795743749962.6249285425154; Thu, 11 May 2023 02:02:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px281-0004Zt-FZ; Thu, 11 May 2023 04:58:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27x-0004HA-Qr for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:21 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px27w-0003m3-F9 for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:21 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px26v-0008g9-5c; Thu, 11 May 2023 09:57:21 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1lAZ9h+I0qwLq2701dP0yI0vhzcu5+T1NQfojAKOTH8=; b=jI63Mdq6mNmnGFKt4xcxdcZECQ yRr/I+SSsg8JltPDsEaJ7d8sjscIf9cnXSpnTjTJKZpjeWLTKuE66ZKy0Zd4pjlISeG8nuMCieHS9 gwjKfVoDDuuaCNyR47+HXlrCdZE9wH4NTbVIZ0INKPm98KysZe6TAW0VnqEYnmVf6xKhbsorvTHfG xZ08NpWDDSHI+rL8M75CBHv7360r5x1okgF6ea3tOKA23P2PdQoyKdK/+LLfSseibk2ossjXfCyWm LZqluO6u3+bHzVGRPyqVhIfO0B8V/OmpbBexhi3RjuzkZnOuqUfLZQ7yrQXoTm8YUcZ0IvU4qC2Qm QftVM4wfIhRctI2oRjdANQp8CiBaMD9n5UP1Irw2gmSoWhlIf7dC1ZHci26M9/k95mhFeP6pfYDIh azPc8e5cc3l5CT3CSTb+h3s+5CpQjBQVLAOt6yr22P+EyJsa0C9/tRm0CzHjrVBCLL8IXGtgmvDyT mAFEzqTOsd+KK+enECqrpTonP1xkjTCChL2JwDXPPe/D0KKOXzWCVgqeED6M3vOltHfmn3stRvgIG AWJzImi4eqGvECJOC6Q7ozjqUJTf9cFwr/qSu8GTBMf/WvaNdow4iVBBkBk1fYyUktruafYNCgHya GX8mq3ssojaX43L9cOwxyrsz4WbqaiDUMt3ApA0k4=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:19 +0100 Message-Id: <20230511085731.171565-7-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 06/18] hw/ide/ich.c: switch AHCIState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795745107100003 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq() and also allows the correspond= ing qemu_free_irq() to be removed. Signed-off-by: Mark Cave-Ayland --- hw/ide/ich.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ide/ich.c b/hw/ide/ich.c index d61faab532..646de05663 100644 --- a/hw/ide/ich.c +++ b/hw/ide/ich.c @@ -123,7 +123,7 @@ static void pci_ich9_ahci_realize(PCIDevice *dev, Error= **errp) /* XXX Software should program this register */ dev->config[0x90] =3D 1 << 6; /* Address Map Register - AHCI mode */ =20 - d->ahci.irq =3D pci_allocate_irq(dev); + d->ahci.irq =3D qdev_get_gpio_in_named(DEVICE(dev), "pci-input-irq", 0= ); =20 pci_register_bar(dev, ICH9_IDP_BAR, PCI_BASE_ADDRESS_SPACE_IO, &d->ahci.idp); @@ -159,7 +159,6 @@ static void pci_ich9_uninit(PCIDevice *dev) =20 msi_uninit(dev); ahci_uninit(&d->ahci); - qemu_free_irq(d->ahci.irq); } =20 static void ich_ahci_class_init(ObjectClass *klass, void *data) --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16837955524368.8094577613291; Thu, 11 May 2023 01:59:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px284-0004j9-48; Thu, 11 May 2023 04:58:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px283-0004gL-CP for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:27 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px281-0003mn-Tq for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:27 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px26z-0008g9-Eg; Thu, 11 May 2023 09:57:25 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=VNO2TvgvBsU5nt2OtoMqmmsjFCb1oBC1WTjKaCuv3Kg=; b=PjVygZN69icUiJ/9SL5xJY5msI u62Pyab0XyEDVYIyvvWiGwoOk57qx6Z/6ojrheN2j1HCJL0N1s7QkMut3b16Fe8+L8G3RllxeR6bh DeqYqzmbj9TjisWyKNL3msNPbc5XpWVAuzm9tYIeqERwf+NIZDAO7pDBGXyz+q5Ip0uoF733dWqxc 5IuGIiesJTba9jMImP2zNj38YV+nMSEdBnZAAXtETgLRM0USohqWj9DcMZfSq+UkWAvOqf5IHl+Zh aXOX32AnXoVXjjrf7JqOD1fLQxW6CmuBsrzKOQmIJ1pdVSwqVSl7KNrwf6WGCd3EC3ZLn+la4hWrJ j5jKSXPM6IMSmEY0+HWJ+4Q0bnNtZfe0s2JZWev6CL8ssEH64gaagzevxSjR8g4oJzccsNXUWqbt9 L/5zutNyQvntZB3IHwJ16SNctAyXRl/HKiL+a4ONil+PHX5MgjZGn34S4DQz6PrbuIIvK+D7p7oxr sfFJEmrKYjHve4JPkRgWXsgGq2ZZ5bxGmwgZFA3GaMGtDwpyZprKItBwJGvIAZm1MTr5r0/yqqHLV VwH67awN/HAP8yrPcwfR/RUmBkLEzXmBqF0w4gu5bsP493g/G89eDLA37FSQUhk+uYzl7dT/jYYKN vRW+OLTKqw+e/vN7TQ9D7B2i41CKVdwReP6qZDVo4=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:20 +0100 Message-Id: <20230511085731.171565-8-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 07/18] hw/net/can/can_mioe3680_pci.c: switch Mioe3680PCIState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795553228100005 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq() and also allows the correspond= ing qemu_free_irq() to be removed. Signed-off-by: Mark Cave-Ayland --- hw/net/can/can_mioe3680_pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/net/can/can_mioe3680_pci.c b/hw/net/can/can_mioe3680_pci.c index b9918773b3..686bf16104 100644 --- a/hw/net/can/can_mioe3680_pci.c +++ b/hw/net/can/can_mioe3680_pci.c @@ -163,7 +163,7 @@ static void mioe3680_pci_realize(PCIDevice *pci_dev, Er= ror **errp) pci_conf =3D pci_dev->config; pci_conf[PCI_INTERRUPT_PIN] =3D 0x01; /* interrupt pin A */ =20 - d->irq =3D pci_allocate_irq(&d->dev); + d->irq =3D qdev_get_gpio_in_named(DEVICE(pci_dev), "pci-input-irq", 0); =20 for (i =3D 0 ; i < MIOe3680_PCI_SJA_COUNT; i++) { can_sja_init(&d->sja_state[i], d->irq); @@ -195,8 +195,6 @@ static void mioe3680_pci_exit(PCIDevice *pci_dev) for (i =3D 0 ; i < MIOe3680_PCI_SJA_COUNT; i++) { can_sja_disconnect(&d->sja_state[i]); } - - qemu_free_irq(d->irq); } =20 static const VMStateDescription vmstate_mioe3680_pci =3D { --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795518347579.2455393091977; Thu, 11 May 2023 01:58:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px286-0004o7-MY; Thu, 11 May 2023 04:58:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px284-0004jY-4w for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:28 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px282-0003mo-Ey for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:27 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px273-0008g9-Oi; Thu, 11 May 2023 09:57:25 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mrtzQIt9LK6S+ps56iCzIQu15XyYgsBpPmtrBYQTHnM=; b=XVtiwbGuB//IpMhKkPKjr6wk3S 2PfLIOdIeMqC7O/aiSRbY9/jg1rgcZfMjj8ywwNJoTKqrmSLqwNEDWp+FSllcg+6t18TSgg7e7R9o O2lwL23sDOMAanmOOjXo4RCWQfcPvgmHgKC/4rS7RtQbMUKsyjXfsduJbR4nty3e0/RUhWU5804eg omv+g+EqgbzXrrLF4KCL0UOCIbVm4ArtnG7X34tuSTGUPvqMFb0YWSLYnnoye0+KJDmQ+Sn2BxjtV 3zBoC2eqAyzWDYbUQ06RjkX7DJ6utE9HLaMs2oZM4cFVyssukPjiEuaud4ueCXQXqjAQJaW97TBKi Qa3AhEYaIYwR+yTwEWiuQ43XirXAVw5+Zel81GdTbJ+iWmllaCNLArqxsX+pKPdPQ/lio88CTVcWf 9vnJR58uxbbLVzpmYt5q/w3iSEOUFzvbb7rRm57kMInYhVljtEOFeduyxR2y9SpveqVL1AOKeLl1o rhNYeas2CyRZrStaFSAd4I/48Qmtljy34i1v95/9Wmj/cnzqPg4m/wh7YCUkUdt4PLF3XkS9Rn28b vt0/WR7TeqBOHwhs5B7Kzbv5MaimZywiPoXfTxG2dm2U/lUdomILx++7c++RdfNfMWVU0ow6xp3I9 RwDyrMSO7Mi9bx29Gz6KKQqfFkA37RbW5lnXBdltg=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:21 +0100 Message-Id: <20230511085731.171565-9-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 08/18] hw/net/can/can_pcm3680_pci.c: switch SerialState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795518669100004 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq() and also allows the correspond= ing qemu_free_irq() to be removed. Signed-off-by: Mark Cave-Ayland --- hw/net/can/can_pcm3680_pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/net/can/can_pcm3680_pci.c b/hw/net/can/can_pcm3680_pci.c index 8ef3e4659c..50f01d02bd 100644 --- a/hw/net/can/can_pcm3680_pci.c +++ b/hw/net/can/can_pcm3680_pci.c @@ -163,7 +163,7 @@ static void pcm3680i_pci_realize(PCIDevice *pci_dev, Er= ror **errp) pci_conf =3D pci_dev->config; pci_conf[PCI_INTERRUPT_PIN] =3D 0x01; /* interrupt pin A */ =20 - d->irq =3D pci_allocate_irq(&d->dev); + d->irq =3D qdev_get_gpio_in_named(DEVICE(pci_dev), "pci-input-irq", 0); =20 for (i =3D 0; i < PCM3680i_PCI_SJA_COUNT; i++) { can_sja_init(&d->sja_state[i], d->irq); @@ -196,8 +196,6 @@ static void pcm3680i_pci_exit(PCIDevice *pci_dev) for (i =3D 0; i < PCM3680i_PCI_SJA_COUNT; i++) { can_sja_disconnect(&d->sja_state[i]); } - - qemu_free_irq(d->irq); } =20 static const VMStateDescription vmstate_pcm3680i_pci =3D { --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795763653412.5494220860551; Thu, 11 May 2023 02:02:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px287-0004oB-0g; Thu, 11 May 2023 04:58:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px284-0004jI-3B for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:28 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px282-0003mq-D1 for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:27 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px274-0008g9-4W; Thu, 11 May 2023 09:57:26 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+ZBzmdU37Pg4lw9mXaCP1QfvTBDdzMb0Y7ZxRGWf6Ss=; b=iVYvMoEmBh22EFIo3R37gSTDyf aUmmFI1kAPJcM/imB4vjUeD6ICmun1/ngTl/NN4qI4m5DF5NxgvDASnS6kYEOXp9BMuntQr/6oxlz HAoKhY6eHJSh/DqKK7I3DCQjIuDoqClRsM+DtqVW5uMmh8XHBP7o0xmnlHoltniHvQESrovQwtWji WAGrBMp7MavRV7b8MXfvJk4795g4+VZ6cpOTaL/oIrXkzPdmvlaINibZC1CWJm+HrNQh7T9az/A9L 7eRFJHOsv1G3V5oOqboKqRgzY6FZxERgtajqfHT8pVTZfRkmzd2HEnFSisN+NJmWma34DBaCg1PWh 7gkPbSIGwBYkeviiF6XjCOeCI6AXt7g4r4OIFJv+JWcWLE/bp2zhmnxu4rovwOGDKHqRcGkutSu63 ovCW+uT4y+vO1IId70Re3wPikQG7eCW2w0Zslqj6AugtR/hLV4dq6mBuV13qTXCtkyT4b3ALzgO5+ 2MWaz6jAyGysGSJGGNqxqWxWSGB5QTD47rpOiIOJoeqHFuQoMOYp9a+tf7FvP8EnzkAfqA5Lt1+J9 AiwMTB/QuvnIttX9ahXcdOwVTcBgdbc9IozJpfZD8dayoe8bwIHTIM3qisDdAcHORs5tIuBHbeb/x HUyvxlz/nZjCnp9p6Z4EHo93uO75Q3g7tBlKfFv0E=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:22 +0100 Message-Id: <20230511085731.171565-10-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 09/18] hw/net/can/ctucan_pci.c: switch CtuCanPCIState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795765168100005 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq() and also allows the correspond= ing qemu_free_irq() to be removed. Signed-off-by: Mark Cave-Ayland --- hw/net/can/ctucan_pci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/net/can/ctucan_pci.c b/hw/net/can/ctucan_pci.c index ea079e2af5..94f8f58518 100644 --- a/hw/net/can/ctucan_pci.c +++ b/hw/net/can/ctucan_pci.c @@ -173,7 +173,7 @@ static void ctucan_pci_realize(PCIDevice *pci_dev, Erro= r **errp) pci_conf =3D pci_dev->config; pci_conf[PCI_INTERRUPT_PIN] =3D 0x01; /* interrupt pin A */ =20 - d->irq =3D pci_allocate_irq(&d->dev); + d->irq =3D qdev_get_gpio_in_named(DEVICE(pci_dev), "pci-input-irq", 0); =20 for (i =3D 0 ; i < CTUCAN_PCI_CORE_COUNT; i++) { ctucan_init(&d->ctucan_state[i], d->irq); @@ -207,8 +207,6 @@ static void ctucan_pci_exit(PCIDevice *pci_dev) for (i =3D 0 ; i < CTUCAN_PCI_CORE_COUNT; i++) { ctucan_disconnect(&d->ctucan_state[i]); } - - qemu_free_irq(d->irq); } =20 static const VMStateDescription vmstate_ctucan_pci =3D { --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795744331750.8761479425511; Thu, 11 May 2023 02:02:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px288-0004ot-Hl; Thu, 11 May 2023 04:58:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px287-0004oF-Aq for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:31 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px285-0003nc-OP for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:31 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px274-0008g9-Gf; Thu, 11 May 2023 09:57:30 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=hsA8S8hlLhIkJhY1/pFDHWtPBrUm5tf81kwBdlHXBQM=; b=dOGwltNF+XhUc3AiajzrmBr/Yr uCrQoQ1MHxxEMamC0KeYq4LBkYGHiwAB8QsIzPBJttilVMmBcwEJtIpXOjNSxc4TVkA3TZCsqrR09 /KIOe0f5quhGAHJuGTF1JoxBBczHe5cZ3cDCEpw4EKJhhJJu46x5CR+eY2wEucmT8Qdx3/pCE3HtN 9zdalpMzWRuTn6i1FCcYFaxYgOcpN8KaU2YUuzMNwGC5ZDEZ7eenjACMDe5L8tb0Hp1JiQUBUgu1g K3DVTp+AnHoWP2Pr6XV87mFWwcDV4dybZuCJFxjUlF6bdusarfEolwS01d0Yq9gp1xBG1RKDEVxxs W0wWS5VHRUlGG49bLy6H+xvlRUUtvk0DlrUMzgjj5+2wu0rsy6iMEfyO1EH+g3Zbyjz29fe8iKXfy p+I1te1n0rTPx9zXWtC34lKW7k6YBd5hJCTbmUOzBYVkqWhcHoWAzWWRxuu8WMflzs7ma34mBkHG5 RLL5QFICZbYd8pxQLOtif9dNBeoNkuHh5RrQKknk0xoPV74cApUXctcUSjrsay0OMv8MBLaZFHnCP hI8Yg2LtM/2Tdc0uFT2t/+HV3qK89yDo0CjSlqpKyj2xWIu1/IEdew5qfTDbbT2QRxd3b3W/T4YTH Zxkfm/7PaWwLBy59LuzZq8bPBkfrcdx+juHUFpLvw=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:23 +0100 Message-Id: <20230511085731.171565-11-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 10/18] hw/net/ne2000-pci.c: switch NE2000State to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795746498100005 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq() and also allows the correspond= ing qemu_free_irq() to be removed. Signed-off-by: Mark Cave-Ayland --- hw/net/ne2000-pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/net/ne2000-pci.c b/hw/net/ne2000-pci.c index edc6689d33..27bdb3e11b 100644 --- a/hw/net/ne2000-pci.c +++ b/hw/net/ne2000-pci.c @@ -64,7 +64,7 @@ static void pci_ne2000_realize(PCIDevice *pci_dev, Error = **errp) s =3D &d->ne2000; ne2000_setup_io(s, DEVICE(pci_dev), 0x100); pci_register_bar(&d->dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &s->io); - s->irq =3D pci_allocate_irq(&d->dev); + s->irq =3D qdev_get_gpio_in_named(DEVICE(pci_dev), "pci-input-irq", 0); =20 qemu_macaddr_default_if_unset(&s->c.macaddr); ne2000_reset(s); @@ -81,7 +81,6 @@ static void pci_ne2000_exit(PCIDevice *pci_dev) NE2000State *s =3D &d->ne2000; =20 qemu_del_nic(s->nic); - qemu_free_irq(s->irq); } =20 static void ne2000_instance_init(Object *obj) --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795756342363.4286632668003; Thu, 11 May 2023 02:02:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px28E-0004wO-4v; Thu, 11 May 2023 04:58:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28C-0004qj-PO for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:36 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28A-0003nx-B3 for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:36 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px278-0008g9-QT; Thu, 11 May 2023 09:57:34 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZcHx4pHLCkJas0hSCf31JgVq7T5yCBGcHpekyuNKDrg=; b=CLREdyT9VzH7SYkI3hZq1Jlv44 LmRqSxPpT+i18yVxPT4yPhaBNhO800a0xUr4718yOisu8C1iXb425qRTK1MmHPcN8OWoJJ7fMxTfU 7EudNrajJwLOGHRbX0J21hBlaWfx7/T/k933etloGr6I/1WjLYDRd4VGW5C+EIkq41lzMIdB4RwTm M6AC/dPRhlL5Q+1o6rJtcJCi8l1iiS/x2zaZ6f6q+Y+ljhaI0m/1EAYi2T1TzLXH2cPciIATMgJRV 28Q6hPKlI+5uXWK0xm/3mC2bagY9vUOtS26oLh9IqR0QDL+E/IQ8S5qUQZX6amUyj0FFyEumEKec9 SiGKL2N/lJrl3K6dqJeOa9rgvYO8cCLXjj3SnAdjhRzuPNLZ6pg1QlIGgbvKJIbBigtcwHTwvcNRs 40KH0C9j9bgarAOYc/Okjd5PegsVSndcocsieNpjXoCbe8wxu9ubHUB4xcyG+YKNZ/nXU4/0vErHe uP9grUYcith6YokcKevo4zBK5kLEgNO/O6O9/wUSdZx/LwnjV85jpU6ee91ca/epwc4zYeG05e5ur RUir3h4WTZM9A3YLgjXdhlTz4RieDSAF2HNAU4DOU/Gk8O86a9C/+lbDjxCB8uzG8l5dH78GRx7+m Wh72nHaC30rj67Mqba4QfVuW8fUAUPCTRXDxtjsqE=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:24 +0100 Message-Id: <20230511085731.171565-12-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 11/18] hw/net/pcnet-pci.c: switch PCIPCNetState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795756668100001 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq() and also allows the correspond= ing qemu_free_irq() to be removed. Signed-off-by: Mark Cave-Ayland --- hw/net/pcnet-pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c index 96a302c141..cd2e080b4f 100644 --- a/hw/net/pcnet-pci.c +++ b/hw/net/pcnet-pci.c @@ -182,7 +182,6 @@ static void pci_pcnet_uninit(PCIDevice *dev) { PCIPCNetState *d =3D PCI_PCNET(dev); =20 - qemu_free_irq(d->state.irq); timer_free(d->state.poll_timer); qemu_del_nic(d->state.nic); } @@ -227,7 +226,7 @@ static void pci_pcnet_realize(PCIDevice *pci_dev, Error= **errp) =20 pci_register_bar(pci_dev, 1, 0, &s->mmio); =20 - s->irq =3D pci_allocate_irq(pci_dev); + s->irq =3D qdev_get_gpio_in_named(DEVICE(pci_dev), "pci-input-irq", 0); s->phys_mem_read =3D pci_physical_memory_read; s->phys_mem_write =3D pci_physical_memory_write; s->dma_opaque =3D DEVICE(pci_dev); --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795586582941.3653887581225; Thu, 11 May 2023 01:59:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px28H-00054K-Hj; Thu, 11 May 2023 04:58:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28F-0004yz-Pc for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:39 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28E-0003oc-Dt for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:39 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px27D-0008g9-3J; Thu, 11 May 2023 09:57:39 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=m3sl5AM+pITfcaQ0KhyxSoI9xUqrckMAhNxoBfYz/rY=; b=QZ4D1yRvL2r90jsfetKXr/0Bmu 3GgFRgdrY6McpsF1x2ELVtSK2pKif+gPxaYoDEJVMKXpi1dfp9oSbIxXLntORbIl0OMWL1o8Cuz4r GbFT//36xqe4+q+s8CDuLLHrLxyLWAdS8jcbkCbbrjnq4Q/5sIuuiBYaTEW2aG0b4peCL3PLUWok+ DTWM/tLRPi56ScV3b+KCfWFzfIn82u99BzzyOXOhHvO2voj7OVdYLUJGY7FSHVyc88gH53xlvzhxX ULGRwh4Z3Rx55hvKQZ54e436ZDzGNjrxCrNwTDu/wy/ms5jErfVYAVa/UoUiMe0XIewdCmgkpzrE+ TlNxTfpfg8Zy86NvX49BDQvw50ejznn/tTeA580Q4OaRCOmOC0BfLbO3lkMVc0KvMZ46Z6YcSAOw0 VZ3rOTY4v2ovj0ZuY4EuhmAzLGIJSaiP85uPtx65wMLvzitoyADTK5oP8MFspF3ySXOiTLKDwOHXJ Ye7aZXDFDJPFh8g42Vv2RsJEBv2oPj19X55bwKQ2cgt7iUxsINg7bWDD2gXOdAbum8bqbyEdBl7xI 5um0Jvbce++tdKTthRjbPJRQNsZG72rqZlKGDeHZG5eNSue3XcnsZz/Bh0gT9PSt2ZWZOHk5sJ2EV CfFFkjKpC0oE924N6nUMw9R4KxNz9O30Dws6MvQVc=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:25 +0100 Message-Id: <20230511085731.171565-13-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 12/18] hw/net/tulip.c: switch TULIPState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795587474100001 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq() and also allows the correspond= ing qemu_free_irq() to be removed. Signed-off-by: Mark Cave-Ayland --- hw/net/tulip.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/net/tulip.c b/hw/net/tulip.c index 915e5fb595..0b4bd8af51 100644 --- a/hw/net/tulip.c +++ b/hw/net/tulip.c @@ -979,7 +979,7 @@ static void pci_tulip_realize(PCIDevice *pci_dev, Error= **errp) pci_register_bar(&s->dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &s->io); pci_register_bar(&s->dev, 1, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->memory= ); =20 - s->irq =3D pci_allocate_irq(&s->dev); + s->irq =3D qdev_get_gpio_in_named(DEVICE(pci_dev), "pci-input-irq", 0); =20 s->nic =3D qemu_new_nic(&net_tulip_info, &s->c, object_get_typename(OBJECT(pci_dev)), @@ -992,7 +992,6 @@ static void pci_tulip_exit(PCIDevice *pci_dev) TULIPState *s =3D DO_UPCAST(TULIPState, dev, pci_dev); =20 qemu_del_nic(s->nic); - qemu_free_irq(s->irq); eeprom93xx_free(&pci_dev->qdev, s->eeprom); } =20 --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795553546393.02449742692954; Thu, 11 May 2023 01:59:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px28L-0005Pl-7i; Thu, 11 May 2023 04:58:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28K-0005I7-3w for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:44 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28I-0003pd-KW for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:43 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px27H-0008g9-DD; Thu, 11 May 2023 09:57:43 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=M5ozvzvGY4D3l/zuoaXGIymwjEwB/QIigUuzLamsTe4=; b=eM7zBcPivNSXdlS4UQUTLs01wO omi2XMPidRqlXUwFffCRczhjLLuY42dLQ75rCi/wpXfbpUJCirfv8i+z251COx2qongWkqpJrqgYX jyr2+LwgJGZshZsb7jdYlSHiWIWjv5hytTkD3a4064ExDtXcZy1whnhx+c81Zqli9szNA3hA3woRd fWRQ/7NwDF1/igk8xpQUY4ELSH/za8GwmBkXinEFQ6Wggf0pxe8qj6b7vwi6AZuDBKtNzP+ZhDKtJ mNlTktOoT0eXoDod/LZCE8R2qQ+ON14Np47OX7xVD+656r1zSnW8+C1IOHj+Tv3IZNjr5LeSZ6gJy Nmhttu7FhhuAOnBonAPaSOWuHEtbMoKVaQ+iCkehgSc/QqoeiK/b7VfFdb5mFkM84RIatlvfBpB+b R8C5r6Vf6hY1Odqgzv8rnNvc4bz6TuYPLMr4aJeMJUrJgj2Imhe6ZXY5ctDwfACR3eh8rD5vDr1by Vwa7mNJ27b1GHzb1efemppZ9SCetsJc5JTPKFNnk0A4hr2ySEf19cSEFt+fwrvm5GJ0ul7wgfhNQg 0ImvmUJYcRByUaX4c2O2pMaWukytqHlXHhCBH+yJryD+5f2n6KgSsLcwXnhgModfNEewbltEAUJjh 3n2Yc9aIubC2+A1csFFHN/aODvO7zUgqHWKAvClFY=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:26 +0100 Message-Id: <20230511085731.171565-14-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 13/18] hw/scsi/esp-pci.c: switch ESPState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795555297100010 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq() and also allows the correspond= ing qemu_free_irq() to be removed. Since esp_pci_scsi_exit() is now empty it ca= n also be removed at the same time. Signed-off-by: Mark Cave-Ayland --- hw/scsi/esp-pci.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index 2f7f11e70b..9447e6c429 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -386,19 +386,11 @@ static void esp_pci_scsi_realize(PCIDevice *dev, Erro= r **errp) "esp-io", 0x80); =20 pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &pci->io); - s->irq =3D pci_allocate_irq(dev); + s->irq =3D qdev_get_gpio_in_named(DEVICE(dev), "pci-input-irq", 0); =20 scsi_bus_init(&s->bus, sizeof(s->bus), d, &esp_pci_scsi_info); } =20 -static void esp_pci_scsi_exit(PCIDevice *d) -{ - PCIESPState *pci =3D PCI_ESP(d); - ESPState *s =3D ESP(&pci->esp); - - qemu_free_irq(s->irq); -} - static void esp_pci_init(Object *obj) { PCIESPState *pci =3D PCI_ESP(obj); @@ -412,7 +404,6 @@ static void esp_pci_class_init(ObjectClass *klass, void= *data) PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); =20 k->realize =3D esp_pci_scsi_realize; - k->exit =3D esp_pci_scsi_exit; k->vendor_id =3D PCI_VENDOR_ID_AMD; k->device_id =3D PCI_DEVICE_ID_AMD_SCSI; k->revision =3D 0x10; --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795578986549.7228794979326; Thu, 11 May 2023 01:59:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px28Z-0006LR-UW; Thu, 11 May 2023 04:58:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28Y-0006Kc-JV for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:58 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28X-0003pz-54 for qemu-devel@nongnu.org; Thu, 11 May 2023 04:58:58 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px27L-0008g9-MH; Thu, 11 May 2023 09:57:47 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HbG7N9o1tlV0eRHskmlPJzkBODQHUSbx9l35NNXblRQ=; b=KuqhvlKy7mizvlKj3EWALcBuW7 MFOGx6JZKaClWYB+Q8mMNHItY24SK7dh83xQxTdFBo5UmNb5wN5BRGRcjaI29yx4TP5p9/PZLYlx4 XC8U80upS+fqG3q270c3DC1BnwfAyJnHD9cNJHMC/piu6unXcS8SNYK8PX4xWg+2UcnJ92R58yp9p 6hSwG3+21K94waSEjroehYpL0IVB4zidqr0IRXMmtsPpBdPEmUVd5+aaygS4n6aZlu/dhW42G+UN6 j8fFrDtqOmc1OuQSxAR/5Mvtc5+4lcokOCCqVA+xOhG392Dn/gUtZV0izPTorglZVp6Ph2kSHtw1P UoY1SGkKrXtTa9UnnKOahmx4GcHJqUJdYRvEjaFCYtHrKbmjAKQUYeYRp0BlALXUqFKFxyM/9bluW VUJLcU2W0v2a2H3YDBrvHbOUvPPbJ8yEqmfQ/FG92YP+XMtaKsiZmmtt8ZW5UhQ1n3sO703nKXVx5 MfLV3t60c7hxRIKL4cADN5FuzZ0JHpHtoMe8dYtrT/EHH785TCwIWkgzQLpRmpleISxrIHe8Vs4mF kKt6YkzJtIKvUb6dAx+yBE4KJtPpY+VpSHAS2RpfVRT4ZWJZstJwuwh8Hku6QjkE8xGQii11lkXhs chrAIzWUOuhXHhJOLaAZJG4orRKB5xBCv7PRgNXVE=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:27 +0100 Message-Id: <20230511085731.171565-15-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 14/18] hw/sd/sdhci-pci.c: switch SDHCIState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795580925100001 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq(). Signed-off-by: Mark Cave-Ayland --- hw/sd/sdhci-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sdhci-pci.c b/hw/sd/sdhci-pci.c index c737c8b930..d2bb23c3f2 100644 --- a/hw/sd/sdhci-pci.c +++ b/hw/sd/sdhci-pci.c @@ -40,7 +40,7 @@ static void sdhci_pci_realize(PCIDevice *dev, Error **err= p) =20 dev->config[PCI_CLASS_PROG] =3D 0x01; /* Standard Host supported DMA */ dev->config[PCI_INTERRUPT_PIN] =3D 0x01; /* interrupt pin A */ - s->irq =3D pci_allocate_irq(dev); + s->irq =3D qdev_get_gpio_in_named(DEVICE(dev), "pci-input-irq", 0); s->dma_as =3D pci_get_address_space(dev); pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->iomem); } --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795571285608.4761571038418; Thu, 11 May 2023 01:59:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px28f-0006yW-DL; Thu, 11 May 2023 04:59:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28d-0006kp-9L for qemu-devel@nongnu.org; Thu, 11 May 2023 04:59:03 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28b-0003qS-Fm for qemu-devel@nongnu.org; Thu, 11 May 2023 04:59:03 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px27P-0008g9-WB; Thu, 11 May 2023 09:57:52 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4YZVQdXqDEVsRNtE8Rfyw4+n+zxNQRswA9eNgSgArg4=; b=C4DKOCQDC/h/hueTM4B24gipiK a3fCZynwEtiFIS15P4guYQ4hsNOOnd9nZNtjIChMuGtWz+IBRyffc8V7NkIHVMKgGBK8cTYuxV5kb W7t3OTe9hwoH4QCE+f/5ld4dn13aI2lg3JB0VJaWimaJQSOCh0XhiG4J/9eNGhXd3APpIpwsjZk0p YczxRkCIUGvrpxGlJDuFXw/uIo3vzukCS/UCDR+JVpNW4QWTN3r1bNfKErjJitKU/wvBZYd3dDKwJ cR6hTKooWTN0U+mJiIAGjdTI1Or3r/Ua5nXFW7rx9DBSlVy+yJsWYoV7mGiInDV/2BkmHWjXXsmVK k/NwEDiCVqNhSlxg27Zunj9kljJ0vOZ+UIA4UKRMGy5/uwGZuUhFg6N+pB0h2wCMAiWCTGAz+YMzl GSAkdSP9G2Es9Tx5A6EIVTG9oLv9XQraQ0Q4uZTAzRLG946fDQlb6I/R0/rGAYwVd5z/0TGkNOu6Z wEHtbQ7FREnMaPyB9/S2FO/KEWtBdhvAnhooTOn3fXIa4lIEuEsmjLUxCDyrD6XcP267asqoBSbsu 5xz10RwK9f6jIi76vdvyXTmE1ONZxf5eOazBojr/y+QFm0ZIDA281Xm+FMvMCnOG6E3veyMz8wXPZ qinf1kSInC/lqlv5DoFIzLeoUF8givX1aeil6uO3c=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:28 +0100 Message-Id: <20230511085731.171565-16-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 15/18] hw/usb/hcd-ehci-pci.c: switch EHCIState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795573407100003 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq() and also allows the correspond= ing qemu_free_irq() to be removed. Signed-off-by: Mark Cave-Ayland --- hw/usb/hcd-ehci-pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c index 4c37c8e227..eed98799b7 100644 --- a/hw/usb/hcd-ehci-pci.c +++ b/hw/usb/hcd-ehci-pci.c @@ -65,7 +65,7 @@ static void usb_ehci_pci_realize(PCIDevice *dev, Error **= errp) pci_conf[0x6e] =3D 0x00; pci_conf[0x6f] =3D 0xc0; /* USBLEFCTLSTS */ =20 - s->irq =3D pci_allocate_irq(dev); + s->irq =3D qdev_get_gpio_in_named(DEVICE(dev), "pci-input-irq", 0); s->as =3D pci_get_address_space(dev); =20 usb_ehci_realize(s, DEVICE(dev), NULL); @@ -107,7 +107,6 @@ static void usb_ehci_pci_exit(PCIDevice *dev) =20 usb_ehci_unrealize(s, DEVICE(dev)); =20 - g_free(s->irq); s->irq =3D NULL; } =20 --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795551288479.5913932122977; Thu, 11 May 2023 01:59:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px28j-0007E5-3W; Thu, 11 May 2023 04:59:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28h-00077N-8J for qemu-devel@nongnu.org; Thu, 11 May 2023 04:59:07 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28f-0003rX-L8 for qemu-devel@nongnu.org; Thu, 11 May 2023 04:59:06 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px27U-0008g9-CH; Thu, 11 May 2023 09:57:56 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bJ95nycvVFMDETOWiLWq8aEOvKQUQYL0eqDl8dg0lDc=; b=phqz/paXLNqXo8yVMfxSpvipxP 8qjOYoEk1sPk7/8vYDtxdZ9FHXRpDgwdzYMvK6NlCqwjm555KfHyUWnVjaDO0wtxa5IG4e0JG8H1m QRBtWAn4Q1D7NO5FkcXAe9SIGNFkn83q3RpFf/d1qm/lDvGYKIGwtiqO8SHJa1igAA46R4V6L8NY+ MExPeVRa6Lxa4+WOOEsF6azHd/1PUpG4xQzLUp32eseF6m6zeVgl/eqsVxbNFCRDQY3omWq9p/G0W 1c5VBxvbl8RcaOua5Zy15DvJHKfyTgWIbCZxMFdJiTp7gec3YGBkNQL00BZzohs1LFz+UrdvHfJrQ Fl8ag/JwzcZEYbfj/i7ehirJa6cnXd2gQc27MFs2+w7QBssS6LTsX0kmSQcgdHw4Qyofm6cLJLcz4 8ouT+uTXdbb7keRul25y4txaKCGhkJ89ixe5ReQCaYkSAfiDIPpfLbihMjxtGArm+9H6EpYMzFVy7 mP+CfzZ+Mwh0/PgfuP0ROuDBNNaChcHq+nGTGwYGw5FEIuRWlz2bu2xfZ/2RaqCdFrVp2QEh31oDp DOet9KUvKyic9Pg1PzQuDE511wzN/ZAOnQIUqwWnLJCwJkS+dKoOoprwbhfgBBKhpDrFyfc+JD29k XHsCtSpcRoeOgla6E/xuwkeWpg2LLVvg03Zviyscc=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:29 +0100 Message-Id: <20230511085731.171565-17-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 16/18] hw/usb/hcd-ohci-pci.c: switch OHCIState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795552800100001 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq() and also allows the correspond= ing qemu_free_irq() to be removed. Signed-off-by: Mark Cave-Ayland --- hw/usb/hcd-ohci-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ohci-pci.c b/hw/usb/hcd-ohci-pci.c index 6b630d35a7..35e4be2a62 100644 --- a/hw/usb/hcd-ohci-pci.c +++ b/hw/usb/hcd-ohci-pci.c @@ -75,7 +75,7 @@ static void usb_ohci_realize_pci(PCIDevice *dev, Error **= errp) return; } =20 - ohci->state.irq =3D pci_allocate_irq(dev); + ohci->state.irq =3D qdev_get_gpio_in_named(DEVICE(dev), "pci-input-irq= ", 0); pci_register_bar(dev, 0, 0, &ohci->state.mem); } =20 --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16837957583681012.2118043622238; Thu, 11 May 2023 02:02:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px28v-0007fd-OS; Thu, 11 May 2023 04:59:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28l-0007RQ-Hg for qemu-devel@nongnu.org; Thu, 11 May 2023 04:59:12 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28j-0003sV-Vw for qemu-devel@nongnu.org; Thu, 11 May 2023 04:59:11 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px27Y-0008g9-LY; Thu, 11 May 2023 09:58:00 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EsK7PVmpJ1jnWrUlJt2YH62mh+w6etdZNOiTuBLkiio=; b=k3hwOiXzLFnGbFZSyfBZ5Qy+Rc o0Z4U5GYZLku3Hna66lgYrb70i65J0tKxTvNluu2S4dB18Ct5C5tlCHdMfsvq4TeKGt+ANOa1Aiu7 Zl/7gPXLOl0Sslcvfj3yeXNkbuqNEsoQsxXc96uSPqodBWKlk15N1td61xkZ0e7axCZr3mZW36jgK ogFv4+vjr3E2Q2ERxg6VwXJAVb8BMzC/FDf5+vYb7eO7RSMUhhsNtyUfF6LAZ+Zs4AESsLcDm1Iux DJr0YlQyhdnyVOqBfsu1iT/UxqICYdrnooWOa1bWtpGW+5KY5FLzOpZWVJF6jpVd3X9COGaUz6wir cFSeDwPfeR9+tX1Ogyr8Sh+jHaO40xrBlttH1K8zWBw8YbWCxrf8aBqKNIn5r0xGULthIEpnJiaC1 tfZVxpiwQr1syrxRYaxb1vlRkpgDKRRHFgFws5PmKgnDSnK9B0QEpL3ZAyGYDedtyletyHReNWXyP 3zz9RRTd0uw4k9NV3qbenMk3YNdJ25lrTBVu43pDj1aIH9SVaGH6lzeCVOy6nxOWVzZg9m6jsVQot j1hdhnaNWss0fJ7ey08bk0oV1zR6sEVKnHHp2IbYUGe7tHlu6D2s4PgJr1YEGZpfM3auFJ3n2L1im hJXJUrCVphDdiDFajCFP3X2dIf3jBddJ510ZphX2s=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:30 +0100 Message-Id: <20230511085731.171565-18-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 17/18] hw/usb/hcd-uhci.c: switch UHCIState to use PCI device input gpio X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795758905100005 Content-Type: text/plain; charset="utf-8" This replaces the call to pci_allocate_irq(). Signed-off-by: Mark Cave-Ayland --- hw/usb/hcd-uhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index 77baaa7a6b..0b08dadd1b 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@ -1168,7 +1168,7 @@ void usb_uhci_common_realize(PCIDevice *dev, Error **= errp) /* TODO: reset value should be 0. */ pci_conf[USB_SBRN] =3D USB_RELEASE_1; /* release number */ pci_config_set_interrupt_pin(pci_conf, u->info.irq_pin + 1); - s->irq =3D pci_allocate_irq(dev); + s->irq =3D qdev_get_gpio_in_named(DEVICE(dev), "pci-input-irq", 0); =20 if (s->masterbus) { USBPort *ports[NB_PORTS]; --=20 2.30.2 From nobody Sat May 18 21:00:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=ilande.co.uk Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683795734619131.13575823163376; Thu, 11 May 2023 02:02:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1px29G-0008A9-6O; Thu, 11 May 2023 04:59:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28p-0007bM-P0 for qemu-devel@nongnu.org; Thu, 11 May 2023 04:59:16 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1px28o-0003tH-Dc for qemu-devel@nongnu.org; Thu, 11 May 2023 04:59:15 -0400 Received: from host81-151-114-25.range81-151.btcentralplus.com ([81.151.114.25] helo=kentang.home) by mail.ilande.co.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1px27c-0008g9-V3; Thu, 11 May 2023 09:58:05 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ilande.co.uk; s=20220518; h=Subject:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:To:From:Sender:Reply-To:Cc: Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/1EAtV9ozIx5RqiGdVoVYzK1DrV4ewSAV9CmS+LTqtk=; b=d4HLyS/YnCRWoUdMvWe+L46IJy US/K0W/tOJBIuBBLEl1NnFCSz2zZaFYuoRMNfreZ4wji0PeXcGmNTN5kDCwG22oEcHNqLN4oE7tGN xydSPZwUqKFFnvQB1qQ3ePnxwJ5ZfbYJam3XwyGBMkqdJJDrluShz5SnV4NrPXIScFtKJBcL+x2ck aG60Xb/d02hPhHsSy7L0mTMXE79PdY85uW+FvvS4emXfTz98kWnnRYmHAu2WjdLkHERMxB/JAOczP oR3ujRtCVTtoK2dAjl98JjBRVskMBxm+HuXxfEqzpqpHBEWxuLQ2d6iuuKs8vf9UHZ2GJ6STouGsJ oCSlIEF3VkkGANO2mPcfvUIbX+B8pGy8KTGJA4YUIYCLMERaPhVZfKTkKVeMPxiH4hMJQc5qdWc7B Q6rGBN5cc4jgL3uwztTlnrnBVVW9qhwD1ah2sm5xR8bnbXGhoOqvcIAgmskwEHYEy570e8TintzKs CbR859m+9xaMzuUhDpOmlFPW7sjLcdoUxKnmBOmoNL04vzDmmBLHeg+7ZNt76fIeZGX6AWOTsdwSO QlrpzjKM66l5tb+uanakc3dgeE19AIk3ofFoD60dkzjHRGaI7iSGnugVxAICiEADZJ3qh4z4EL6ja zPN8kJ9ua3Phn2jBIBGKQAc/baXzZB5/5G/XjRQYc=; From: Mark Cave-Ayland To: mst@redhat.com, marcel.apfelbaum@gmail.com, philmd@linaro.org, alex.bennee@linaro.org, qemu-devel@nongnu.org Date: Thu, 11 May 2023 09:57:31 +0100 Message-Id: <20230511085731.171565-19-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> References: <20230511085731.171565-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 81.151.114.25 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [RFC PATCH 18/18] hw/pci/pci.c: remove pci_allocate_irq() X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.ilande.co.uk) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.ilande.co.uk X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1683795736236100003 Content-Type: text/plain; charset="utf-8" This function is no longer used and can now be removed. Signed-off-by: Mark Cave-Ayland --- hw/pci/pci.c | 8 -------- include/hw/pci/pci.h | 1 - 2 files changed, 9 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 0dd3b24b62..79eb427709 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -1670,14 +1670,6 @@ static void pci_bus_irq_handler(void *opaque, int de= vfn, int level) pci_irq_handler(pci_dev, intx, level); } =20 -qemu_irq pci_allocate_irq(PCIDevice *pci_dev) -{ - int intx =3D pci_intx(pci_dev); - assert(0 <=3D intx && intx < PCI_NUM_PINS); - - return qemu_allocate_irq(pci_irq_handler, pci_dev, intx); -} - void pci_set_irq(PCIDevice *pci_dev, int level) { qemu_set_irq(pci_dev->irq, level); diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 935b4b91b4..080c5a0df2 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -587,7 +587,6 @@ PCIDevice *pci_create_simple(PCIBus *bus, int devfn, co= nst char *name); =20 void lsi53c8xx_handle_legacy_cmdline(DeviceState *lsi_dev); =20 -qemu_irq pci_allocate_irq(PCIDevice *pci_dev); void pci_set_irq(PCIDevice *pci_dev, int level); =20 static inline void pci_irq_assert(PCIDevice *pci_dev) --=20 2.30.2