[v9] block: refactor blockdev transactions

[PATCH v9 0/6] block: refactor blockdev transactions

Posted by Vladimir Sementsov-Ogievskiy 11 months, 3 weeks ago

Hi all!

Let's refactor QMP transactions implementation into new (relatively)
transaction API.

v9:
01: fix leaks
02-03: add r-b
04: fix leak, s/Transaction/transaction/
05: new, was part of 06
06: rework of bitmap-add action moved to 05

Vladimir Sementsov-Ogievskiy (6):
  blockdev: refactor transaction to use Transaction API
  blockdev: transactions: rename some things
  blockdev: qmp_transaction: refactor loop to classic for
  blockdev: transaction: refactor handling transaction properties
  blockdev:  use state.bitmap in block-dirty-bitmap-add action
  blockdev: qmp_transaction: drop extra generic layer

 blockdev.c | 606 ++++++++++++++++++++++-------------------------------
 1 file changed, 249 insertions(+), 357 deletions(-)

-- 
2.34.1

Re: [PATCH v9 0/6] block: refactor blockdev transactions

Posted by Kevin Wolf 11 months, 3 weeks ago

Am 10.05.2023 um 17:06 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Hi all!
> 
> Let's refactor QMP transactions implementation into new (relatively)
> transaction API.
> 
> v9:
> 01: fix leaks

That's a clever use of g_autofree. Wouldn't have thought of that. :-)

> 02-03: add r-b
> 04: fix leak, s/Transaction/transaction/
> 05: new, was part of 06
> 06: rework of bitmap-add action moved to 05

I took the liberty of moving the removal of the 'prepared' field in
BlockDirtyBitmapState from patch 6 to patch 5, I hope you agree.

Thanks, applied to the block branch.

Kevin

Re: [PATCH v9 0/6] block: refactor blockdev transactions

Posted by Vladimir Sementsov-Ogievskiy 11 months, 3 weeks ago

On 11.05.23 12:00, Kevin Wolf wrote:
> Am 10.05.2023 um 17:06 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> Hi all!
>>
>> Let's refactor QMP transactions implementation into new (relatively)
>> transaction API.
>>
>> v9:
>> 01: fix leaks
> 
> That's a clever use of g_autofree. Wouldn't have thought of that. :-)
> 
>> 02-03: add r-b
>> 04: fix leak, s/Transaction/transaction/
>> 05: new, was part of 06
>> 06: rework of bitmap-add action moved to 05
> 
> I took the liberty of moving the removal of the 'prepared' field in
> BlockDirtyBitmapState from patch 6 to patch 5, I hope you agree.

I agree

> 
> Thanks, applied to the block branch.
> 

Thanks!

-- 
Best regards,
Vladimir

Re: [PATCH v9 0/6] block: refactor blockdev transactions

Posted by Vladimir Sementsov-Ogievskiy 11 months, 3 weeks ago

Interesting, I see two 5/6 letters, equal body, but a bit different headers (the second has empty "Sender")..

On 10.05.23 18:06, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> Let's refactor QMP transactions implementation into new (relatively)
> transaction API.
> 
> v9:
> 01: fix leaks
> 02-03: add r-b
> 04: fix leak, s/Transaction/transaction/
> 05: new, was part of 06
> 06: rework of bitmap-add action moved to 05
> 
> Vladimir Sementsov-Ogievskiy (6):
>    blockdev: refactor transaction to use Transaction API
>    blockdev: transactions: rename some things
>    blockdev: qmp_transaction: refactor loop to classic for
>    blockdev: transaction: refactor handling transaction properties
>    blockdev:  use state.bitmap in block-dirty-bitmap-add action

Probably, the problem starts here: I accidentally add extra whitespace.. And the second (copied) letter doesn't have this mistake. That's something about how mailing list works.

>    blockdev: qmp_transaction: drop extra generic layer
> 
>   blockdev.c | 606 ++++++++++++++++++++++-------------------------------
>   1 file changed, 249 insertions(+), 357 deletions(-)
> 



-- 
Best regards,
Vladimir

Re: [PATCH v9 0/6] block: refactor blockdev transactions

Posted by Denis V. Lunev 11 months, 3 weeks ago

On 5/10/23 17:21, Vladimir Sementsov-Ogievskiy wrote:
> Interesting, I see two 5/6 letters, equal body, but a bit different 
> headers (the second has empty "Sender")..
>
for me all is OK