From nobody Fri May 10 21:52:35 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683618924; cv=none; d=zohomail.com; s=zohoarc; b=lEIU7TPnfpe0R7rWou0m4GBsu5sfDPXPjcrWxD0c+bkENCvfnxW+CxgeZHycxm+FSx1eTEJfOjsOUUsv/UHJKf9POta9o61Fm341WjZHMTpRNSKMhL5+K1QQEwvuH/tr5pja+iOTYcjo7e4zdT552zhFFae+6QI+PesPZHOQ22Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683618924; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=VEvtKRYBjsblfazOfiGmgPF0gMEXrgIo/R+yAE9LqZ0=; b=jvDhKu22SGQX4s6DyQsO8G6iJw9QxU0N4T/wgUeCB/KBRMjKNTQbB97+zqFN9FtgOXpSMopB4Ibl+2MyY4sSkbE+P/RoY0ce99aD5PnevvNCu1muniFJKtDtHmk6b//bGR/aNWrScMqrGyk/d9VTXuyRZ2BKxlQMx2XpWghzb+I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683618924707992.9558515870432; Tue, 9 May 2023 00:55:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwIA7-0004eh-TF; Tue, 09 May 2023 03:53:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwIA4-0004cN-Ru for qemu-devel@nongnu.org; Tue, 09 May 2023 03:53:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwIA2-0006X0-Hq for qemu-devel@nongnu.org; Tue, 09 May 2023 03:53:28 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-52-s2aNukQCMXSBjTgeO248zg-1; Tue, 09 May 2023 03:53:22 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 98444802A95; Tue, 9 May 2023 07:53:21 +0000 (UTC) Received: from f37-work.redhat.com (unknown [10.39.194.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CAD31492B00; Tue, 9 May 2023 07:53:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683618805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=VEvtKRYBjsblfazOfiGmgPF0gMEXrgIo/R+yAE9LqZ0=; b=eeY2EO2CyWqmw8M1rdanj+rhlHiNbc/+2RPddy2xVeRXcFsJoSdxxzkJQiqZxtvG+HmyQU jfDfKluCwcIwF6JlX4lny08B/TVaTCh+LeHUdXQMpXROx9FGs97qAd7d+r258z5yC4xpDl 3Yl6DeoGfR+YcJjOZZn2ZnUlbaSmeTg= X-MC-Unique: s2aNukQCMXSBjTgeO248zg-1 From: Mauro Matteo Cascella To: qemu-devel@nongnu.org Cc: mst@redhat.com, arei.gonglei@huawei.com, pizhenwei@bytedance.com, taoym@zju.edu.cn, mcascell@redhat.com Subject: [PATCH v2] virtio-crypto: fix NULL pointer dereference in virtio_crypto_free_request Date: Tue, 9 May 2023 09:53:17 +0200 Message-Id: <20230509075317.1132301-1-mcascell@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=mcascell@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683618926038100005 Content-Type: text/plain; charset="utf-8" Ensure op_info is not NULL in case of QCRYPTODEV_BACKEND_ALG_SYM algtype. Fixes: 0e660a6f90a ("crypto: Introduce RSA algorithm") Signed-off-by: Mauro Matteo Cascella Reported-by: Yiming Tao Reviewed-by: Gonglei Reviewed-by: zhenwei pi --- v2: - updated 'Fixes:' tag hw/virtio/virtio-crypto.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c index 2fe804510f..c729a1f79e 100644 --- a/hw/virtio/virtio-crypto.c +++ b/hw/virtio/virtio-crypto.c @@ -476,15 +476,17 @@ static void virtio_crypto_free_request(VirtIOCryptoRe= q *req) size_t max_len; CryptoDevBackendSymOpInfo *op_info =3D req->op_info.u.sym_op_info; =20 - max_len =3D op_info->iv_len + - op_info->aad_len + - op_info->src_len + - op_info->dst_len + - op_info->digest_result_len; - - /* Zeroize and free request data structure */ - memset(op_info, 0, sizeof(*op_info) + max_len); - g_free(op_info); + if (op_info) { + max_len =3D op_info->iv_len + + op_info->aad_len + + op_info->src_len + + op_info->dst_len + + op_info->digest_result_len; + + /* Zeroize and free request data structure */ + memset(op_info, 0, sizeof(*op_info) + max_len); + g_free(op_info); + } } else if (req->flags =3D=3D QCRYPTODEV_BACKEND_ALG_ASYM) { CryptoDevBackendAsymOpInfo *op_info =3D req->op_info.u.asym_op_inf= o; if (op_info) { --=20 2.40.1