[v3] target/arm: disable-tcg and without-default-devices fixes

[PATCH v3 0/3] target/arm: disable-tcg and without-default-devices fixes

Fabiano Rosas posted 3 patches 11 months, 3 weeks ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230508181611.2621-1-farosas@suse.de

Maintainers: Peter Maydell <peter.maydell@linaro.org>, John Snow <jsnow@redhat.com>, Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

target/arm/Kconfig       |  9 ++-------
tests/qtest/cdrom-test.c | 10 ++++++++++
2 files changed, 12 insertions(+), 7 deletions(-)

Expand all Fold all

[PATCH v3 0/3] target/arm: disable-tcg and without-default-devices fixes

Posted by Fabiano Rosas 11 months, 3 weeks ago

Changed the cdrom test to apply to only the x86 and s390x cdrom boot
tests.

CI run: https://gitlab.com/farosas/qemu/-/pipelines/860488769

v2:
https://lore.kernel.org/r/20230505123524.23401-1-farosas@suse.de

v1:
https://lore.kernel.org/r/20230503193833.29047-1-farosas@suse.de

Here's the fix for the cdrom test failure that we discussed in the
list, plus 2 fixes for the ---without-default-devices build.

When I moved the boards CONFIGs from default.mak to Kconfig, it became
possible (due to --without-default-devices) to disable the CONFIGs for
all the boards that require ARM_V7M. That breaks the build because
ARM_V7M is required to be always set.

Fabiano Rosas (3):
  target/arm: Select SEMIHOSTING when using TCG
  target/arm: Select CONFIG_ARM_V7M when TCG is enabled
  tests/qtest: Don't run cdrom boot tests if no accelerator is present

 target/arm/Kconfig       |  9 ++-------
 tests/qtest/cdrom-test.c | 10 ++++++++++
 2 files changed, 12 insertions(+), 7 deletions(-)

-- 
2.35.3

Re: [PATCH v3 0/3] target/arm: disable-tcg and without-default-devices fixes

Posted by Peter Maydell 11 months, 3 weeks ago

On Mon, 8 May 2023 at 19:16, Fabiano Rosas <farosas@suse.de> wrote:
>
> Changed the cdrom test to apply to only the x86 and s390x cdrom boot
> tests.
>
> CI run: https://gitlab.com/farosas/qemu/-/pipelines/860488769
>
> v2:
> https://lore.kernel.org/r/20230505123524.23401-1-farosas@suse.de
>
> v1:
> https://lore.kernel.org/r/20230503193833.29047-1-farosas@suse.de
>
> Here's the fix for the cdrom test failure that we discussed in the
> list, plus 2 fixes for the ---without-default-devices build.
>
> When I moved the boards CONFIGs from default.mak to Kconfig, it became
> possible (due to --without-default-devices) to disable the CONFIGs for
> all the boards that require ARM_V7M. That breaks the build because
> ARM_V7M is required to be always set.



Applied to target-arm.next, thanks.

-- PMM