target/m68k: Fix gen_load_fp for OS_LONG

[PATCH] target/m68k: Fix gen_load_fp for OS_LONG

Posted by Richard Henderson 2 years, 9 months ago

Case was accidentally dropped in b7a94da9550b.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/m68k/translate.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 744eb3748b..44d852b106 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -959,6 +959,7 @@ static void gen_load_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp,
     switch (opsize) {
     case OS_BYTE:
     case OS_WORD:
+    case OS_LONG:
         tcg_gen_qemu_ld_tl(tmp, addr, index, opsize | MO_SIGN | MO_TE);
         gen_helper_exts32(cpu_env, fp, tmp);
         break;
-- 
2.34.1

Re: [PATCH] target/m68k: Fix gen_load_fp for OS_LONG

Posted by Philippe Mathieu-Daudé 2 years, 9 months ago

On 8/5/23 16:08, Richard Henderson wrote:
> Case was accidentally dropped in b7a94da9550b.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/m68k/translate.c | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] target/m68k: Fix gen_load_fp for OS_LONG

Posted by Laurent Vivier 2 years, 9 months ago

Le 08/05/2023 à 16:08, Richard Henderson a écrit :
> Case was accidentally dropped in b7a94da9550b.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/m68k/translate.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
> index 744eb3748b..44d852b106 100644
> --- a/target/m68k/translate.c
> +++ b/target/m68k/translate.c
> @@ -959,6 +959,7 @@ static void gen_load_fp(DisasContext *s, int opsize, TCGv addr, TCGv_ptr fp,
>       switch (opsize) {
>       case OS_BYTE:
>       case OS_WORD:
> +    case OS_LONG:
>           tcg_gen_qemu_ld_tl(tmp, addr, index, opsize | MO_SIGN | MO_TE);
>           gen_helper_exts32(cpu_env, fp, tmp);
>           break;

Tested-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [PATCH] target/m68k: Fix gen_load_fp for OS_LONG

Posted by Richard Henderson 2 years, 9 months ago

On 5/8/23 17:06, Laurent Vivier wrote:
> Le 08/05/2023 à 16:08, Richard Henderson a écrit :
>> Case was accidentally dropped in b7a94da9550b.
>>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>>   target/m68k/translate.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/target/m68k/translate.c b/target/m68k/translate.c
>> index 744eb3748b..44d852b106 100644
>> --- a/target/m68k/translate.c
>> +++ b/target/m68k/translate.c
>> @@ -959,6 +959,7 @@ static void gen_load_fp(DisasContext *s, int opsize, TCGv addr, 
>> TCGv_ptr fp,
>>       switch (opsize) {
>>       case OS_BYTE:
>>       case OS_WORD:
>> +    case OS_LONG:
>>           tcg_gen_qemu_ld_tl(tmp, addr, index, opsize | MO_SIGN | MO_TE);
>>           gen_helper_exts32(cpu_env, fp, tmp);
>>           break;
> 
> Tested-by: Laurent Vivier <laurent@vivier.eu>
> Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Queued to tcg-next.


r~