From nobody Sat May 18 09:48:27 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683357672; cv=none; d=zohomail.com; s=zohoarc; b=dlAjgrNTE9BkMaV7yDL4NEwv9KKI90tHXz7tMG6qOOGH/rlhZRn1XAwvATts4dTXbh6iAKrx6tJaF3Q7enkxs3rRp5ZzEY17K3HOxeBbi4lNIoxhACdv0xucUrxP4Fm+7JxCo4rEMsQD2wjTN7H7GMf+mXRbpxnmDKYs46Ie4u0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683357672; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=QnPB2BYU9Iu+jMAG2o2hVEPT1XATPoA6UkH++BNC/EE=; b=BcZ86rW9mPn8TVvqVLKgVv+itlmlP98Lo0+81/8IuXsMQtrDx+/okpsLq89riknSazm28TAcDgd3mB+IjOfR1cl412R4ecstPQapRAQN3aLc1u/naWphHVT3iSBZYyTW5hZNkDIwzZCkTdUBfUbrPUCRtXSs5AklNRvYc+xQuLU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683357672732427.90194139699827; Sat, 6 May 2023 00:21:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvCDj-0002Vb-HN; Sat, 06 May 2023 03:20:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvCDc-0002Uz-Df for qemu-devel@nongnu.org; Sat, 06 May 2023 03:20:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvCDa-0003tr-8K for qemu-devel@nongnu.org; Sat, 06 May 2023 03:20:36 -0400 Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-7F0s7MhnPviFFs1SKth9Rw-1; Sat, 06 May 2023 03:20:27 -0400 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1aae625e57dso12937665ad.1 for ; Sat, 06 May 2023 00:20:27 -0700 (PDT) Received: from localhost.localdomain ([203.212.242.230]) by smtp.googlemail.com with ESMTPSA id jk1-20020a170903330100b001a216d44440sm2898092plb.200.2023.05.06.00.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 00:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683357628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QnPB2BYU9Iu+jMAG2o2hVEPT1XATPoA6UkH++BNC/EE=; b=UULLQkOIGEj4Y67A7Z7evZgKd9TRAfAwK08DbEfqqzh/pQYaJEWtIm50yWkPJAAtpPsBfJ n6eWp261LAyB7jW6GJkYCbLiOJhey0ME2H3vdAiBfZeDygq4pTrHCd5kVhVltVvSHAx6gb b56TD2e9fDYsmNjOxmItC1KjasD4Ylk= X-MC-Unique: 7F0s7MhnPviFFs1SKth9Rw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683357626; x=1685949626; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QnPB2BYU9Iu+jMAG2o2hVEPT1XATPoA6UkH++BNC/EE=; b=heFGuKI0prJDTvUxzZOQbjZ3RAyjsMbKJekT187bPBKEIndXPbgvhe6Y2Jz7ybmbWp ihro/GZm6AUzTLQY/0cuEfjCs/c77mVPzVs3RkFR9SfluZy74iT02S1K0LLBuUAHYwRu AvAQ9XmZhlvBUemmw9o3U380fVB1aGuz02HjIXfflZu39rfdXVMeOec5GyQ7bYaCl//i /FOF/iCwAH2W5dQnFZcal3jEUsNelhRK6055r2FFW5T3l28YCbZjbdXqxqXGQimHIWdI hA6SCWbzmeZfTbhoBJmuEfkHNMZLejC89ehr//dyEzpP0KFAMLEk9pTqpaT2DSbtyv/F rZoA== X-Gm-Message-State: AC+VfDyhQfqDOmjipXtT8z2x4mg8u15YVzUazcDGsNmcq1gpCxFbsvca ZpxSTEfi92tNdUeDMxgS6GBexFo4whdba9PimK+ntDbfmuhsH+Q/+yDuV+V7qZiDW0YlKf4ADvz j8PdVVl3LcsepG64= X-Received: by 2002:a17:902:bd85:b0:1a6:9ec2:a48f with SMTP id q5-20020a170902bd8500b001a69ec2a48fmr3688933pls.34.1683357626242; Sat, 06 May 2023 00:20:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5P19ijFeS7PGafi1GpRc6l5gufXtS4sy4nUgBJy206cjTWKF1y4Nn7DV74gV8LtjFdO4X/lg== X-Received: by 2002:a17:902:bd85:b0:1a6:9ec2:a48f with SMTP id q5-20020a170902bd8500b001a69ec2a48fmr3688920pls.34.1683357625878; Sat, 06 May 2023 00:20:25 -0700 (PDT) From: Ani Sinha To: =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , Wainer dos Santos Moschetta , Beraldo Leal Cc: berrange@redhat.com, Ani Sinha , qemu-devel@nongnu.org Subject: [PATCH] docs/devel: remind developers to run CI container pipeline when updating images Date: Sat, 6 May 2023 12:50:12 +0530 Message-Id: <20230506072012.10350-1-anisinha@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=anisinha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683357674430100003 Content-Type: text/plain; charset="utf-8" When new dependencies and packages are added to containers, its important to run CI container generation pipelines on gitlab to make sure that there are= no obvious conflicts between packages that are being added and those that are already present. Running CI container pipelines will make sure that there a= re no such breakages before we commit the change updating the containers. Add a line in the documentation reminding developers to run the pipeline before submitting the change. It will also ease the life of the maintainers. Signed-off-by: Ani Sinha Reviewed-by: Daniel P. Berrang=C3=A9 --- docs/devel/testing.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 4071e72710..203facb417 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -479,6 +479,12 @@ first to contribute the mapping to the ``libvirt-ci`` = project: contains the ``mappings.yml`` update. Then add the prerequisite and run ``make lcitool-refresh``. =20 + * Please also trigger gitlab container generation pipelines on your change + for as many OS distros as practical to make sure that there are no + obvious breakages when adding the new pre-requisite. Please see + `CI `__ documentation + page on how to trigger gitlab CI pipelines on your change. + For enterprise distros that default to old, end-of-life versions of the Python runtime, QEMU uses a separate set of mappings that work with more recent versions. These can be found in ``tests/lcitool/mappings.yml``. --=20 2.31.1