sbsa-ref: use Bochs graphics card instead of VGA

[PATCH] sbsa-ref: use Bochs graphics card instead of VGA

Marcin Juszkiewicz posted 1 patch 12 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230505120936.1097060-1-marcin.juszkiewicz@linaro.org

Maintainers: Radoslaw Biernacki <rad@semihalf.com>, Peter Maydell <peter.maydell@linaro.org>, Leif Lindholm <quic_llindhol@quicinc.com>

hw/arm/sbsa-ref.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] sbsa-ref: use Bochs graphics card instead of VGA

Posted by Marcin Juszkiewicz 12 months ago

Bochs card is normal PCI Express card so it fits better in system with
PCI Express bus. VGA is simple legacy PCI card.

Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
---
 hw/arm/sbsa-ref.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
index 3e3671f66e..0ace0fcc35 100644
--- a/hw/arm/sbsa-ref.c
+++ b/hw/arm/sbsa-ref.c
@@ -679,7 +679,7 @@ static void create_pcie(SBSAMachineState *sms)
         }
     }
 
-    pci_create_simple(pci->bus, -1, "VGA");
+    pci_create_simple(pci->bus, -1, "bochs-display");
 
     create_smmu(sms, pci->bus);
 }
-- 
2.40.1

Re: [PATCH] sbsa-ref: use Bochs graphics card instead of VGA

Posted by Leif Lindholm 11 months, 3 weeks ago

On 2023-05-05 13:09, Marcin Juszkiewicz wrote:
> Bochs card is normal PCI Express card so it fits better in system with
> PCI Express bus. VGA is simple legacy PCI card.
> 
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

> ---
>   hw/arm/sbsa-ref.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c
> index 3e3671f66e..0ace0fcc35 100644
> --- a/hw/arm/sbsa-ref.c
> +++ b/hw/arm/sbsa-ref.c
> @@ -679,7 +679,7 @@ static void create_pcie(SBSAMachineState *sms)
>           }
>       }
>   
> -    pci_create_simple(pci->bus, -1, "VGA");
> +    pci_create_simple(pci->bus, -1, "bochs-display");
>   
>       create_smmu(sms, pci->bus);
>   }

Re: [PATCH] sbsa-ref: use Bochs graphics card instead of VGA

Posted by Peter Maydell 11 months, 3 weeks ago

On Wed, 17 May 2023 at 11:55, Leif Lindholm <quic_llindhol@quicinc.com> wrote:
>
> On 2023-05-05 13:09, Marcin Juszkiewicz wrote:
> > Bochs card is normal PCI Express card so it fits better in system with
> > PCI Express bus. VGA is simple legacy PCI card.
> >
> > Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
>
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
>



Applied to target-arm.next, thanks.

-- PMM