scripts/coverity-scan: Add xtensa and openrisc components

[PATCH] scripts/coverity-scan: Add xtensa and openrisc components

Posted by Peter Maydell 12 months ago

We have two target architectures which don't have Coverity components
defined for them: xtensa and openrisc. Add them.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
As usual with coverity components, these will need to be added
manually via the scanner UI, since it has no import-from-file...

 scripts/coverity-scan/COMPONENTS.md | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
index 7c48e0f1d21..add7c5a279c 100644
--- a/scripts/coverity-scan/COMPONENTS.md
+++ b/scripts/coverity-scan/COMPONENTS.md
@@ -143,3 +143,9 @@ loongarch
 
 riscv
   ~ (/qemu)?((/include)?/hw/riscv/.*|/target/riscv/.*|/hw/.*/(riscv_|ibex_|sifive_).*)
+
+openrisc
+  ~ (/qemu)?((/include)?/hw/openrisc/.*|/target/openrisc/.*)
+
+xtensa
+  ~ (/qemu)?((/include)?/hw/xtensa/.*|/target/xtensa/.*)
-- 
2.34.1

Re: [PATCH] scripts/coverity-scan: Add xtensa and openrisc components

Posted by Paolo Bonzini 11 months, 4 weeks ago

On 5/4/23 15:45, Peter Maydell wrote:
> We have two target architectures which don't have Coverity components
> defined for them: xtensa and openrisc. Add them.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> As usual with coverity components, these will need to be added
> manually via the scanner UI, since it has no import-from-file...

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

but the UI is broken and adding the components results in a 404 for 
https://scan.coverity.com/projects/qemu/update_components. :(

This has been a recurring issue through the years, it was gone about a 
month ago and it's now back; I've sent an email to 
scan-admin@coverity.com but I wouldn't hold my breath.

Paolo

>   scripts/coverity-scan/COMPONENTS.md | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
> index 7c48e0f1d21..add7c5a279c 100644
> --- a/scripts/coverity-scan/COMPONENTS.md
> +++ b/scripts/coverity-scan/COMPONENTS.md
> @@ -143,3 +143,9 @@ loongarch
>   
>   riscv
>     ~ (/qemu)?((/include)?/hw/riscv/.*|/target/riscv/.*|/hw/.*/(riscv_|ibex_|sifive_).*)
> +
> +openrisc
> +  ~ (/qemu)?((/include)?/hw/openrisc/.*|/target/openrisc/.*)
> +
> +xtensa
> +  ~ (/qemu)?((/include)?/hw/xtensa/.*|/target/xtensa/.*)

Re: [PATCH] scripts/coverity-scan: Add xtensa and openrisc components

Posted by Stafford Horne 12 months ago

On Thu, May 04, 2023 at 02:45:26PM +0100, Peter Maydell wrote:
> We have two target architectures which don't have Coverity components
> defined for them: xtensa and openrisc. Add them.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> As usual with coverity components, these will need to be added
> manually via the scanner UI, since it has no import-from-file...
> 
>  scripts/coverity-scan/COMPONENTS.md | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/scripts/coverity-scan/COMPONENTS.md b/scripts/coverity-scan/COMPONENTS.md
> index 7c48e0f1d21..add7c5a279c 100644
> --- a/scripts/coverity-scan/COMPONENTS.md
> +++ b/scripts/coverity-scan/COMPONENTS.md
> @@ -143,3 +143,9 @@ loongarch
>  
>  riscv
>    ~ (/qemu)?((/include)?/hw/riscv/.*|/target/riscv/.*|/hw/.*/(riscv_|ibex_|sifive_).*)
> +
> +openrisc
> +  ~ (/qemu)?((/include)?/hw/openrisc/.*|/target/openrisc/.*)

This looks good to me for OpenRISC.  Where can we view the coverity reports?

  Is it this?: https://scan.coverity.com/projects/378

Acked-by: Stafford Horne <shorne@gmail.com>

> +xtensa
> +  ~ (/qemu)?((/include)?/hw/xtensa/.*|/target/xtensa/.*)