From nobody Thu May 16 02:50:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683196487; cv=none; d=zohomail.com; s=zohoarc; b=fIO6to3Q0CZ/a7XOEZdC5bgm7MPi1AF/zbddWvZwDSSOV7Jl8uD/oxYxmetblfdIMtJnsp8jJqraezMBcpxNSAWFT9K7zSYdvJfj4gsKPhEX5uEe0CWzghYwXnr3pzCx2Xy/m4CNspSgMDMBiMcfFGRee5E6shbQ0Zqt0JzAus4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683196487; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ujk3avns+nmBgOuRWFa+rgiPnIednyLGtiODp9kleV0=; b=UTHKJSdoniNbRL2PY5g7ivhg6cyfOiLMPWsdu0R3FiwuJ86jzzqf1m+TGBX5xDwDclNCNT5PqcpV3F95KF1eHpMk65i35lFGKAej7MyC4ChtvK9qthSA71UPQ4ONN3xY31c/26VzAXcQx7RKAcX90ejUsmJmx6Ndb6sv6MlL1PA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1683196487690526.6356792244842; Thu, 4 May 2023 03:34:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puWHq-000429-Va; Thu, 04 May 2023 06:34:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puWHp-00041o-Lc for qemu-devel@nongnu.org; Thu, 04 May 2023 06:34:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puWHj-0003EZ-2E for qemu-devel@nongnu.org; Thu, 04 May 2023 06:34:09 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-144-rgea44S4O5eyxF3pbkxCcg-1; Thu, 04 May 2023 06:34:00 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 973F5A0F380 for ; Thu, 4 May 2023 10:34:00 +0000 (UTC) Received: from secure.mitica (unknown [10.39.193.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id D1CA71121331; Thu, 4 May 2023 10:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683196442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ujk3avns+nmBgOuRWFa+rgiPnIednyLGtiODp9kleV0=; b=Wro0L6JUVRaWz0k0uBMV0QmgNiCRKDKGMAS2BqP6M2wDGjAwSvqa7NQNfBdT+SMlM+6lcZ jL2wCkEJHxMbTacAkDGevqNUr57ULXrvb0O9nP7VwBrJUALLpSzFwuTvQU6nJkZdf2xwrr eNRU5Ry7bcBjTYSd9TtIOsxn45o8fCk= X-MC-Unique: rgea44S4O5eyxF3pbkxCcg-1 From: Juan Quintela To: qemu-devel@nongnu.org Cc: Juan Quintela , Leonardo Bras , Peter Xu Subject: [PATCH 1/2] migration: Document all migration_stats Date: Thu, 4 May 2023 12:33:56 +0200 Message-Id: <20230504103357.22130-2-quintela@redhat.com> In-Reply-To: <20230504103357.22130-1-quintela@redhat.com> References: <20230504103357.22130-1-quintela@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683196488775100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: David Edmondson --- migration/migration-stats.h | 43 +++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) diff --git a/migration/migration-stats.h b/migration/migration-stats.h index 149af932d7..0e49c236fa 100644 --- a/migration/migration-stats.h +++ b/migration/migration-stats.h @@ -22,17 +22,60 @@ * one thread). */ typedef struct { + /* + * number of bytes that were dirty last time that we sync with the + * guest memory. We use that to calculate the downtime. As the + * remaining dirty amounts to what we know that is still dirty + * since last iteration, not counting what the guest has dirtied + * sync we synchronize bitmaps. + */ Stat64 dirty_bytes_last_sync; + /* + * number of pages dirtied by second. + */ Stat64 dirty_pages_rate; + /* + * number of times we have synchronize guest bitmaps. + */ Stat64 dirty_sync_count; + /* + * number of times zero copy failed to send any page using zero + * copy. + */ Stat64 dirty_sync_missed_zero_copy; + /* + * number of bytes sent at migration completion stage while the + * guest is stopped. + */ Stat64 downtime_bytes; + /* + * number of pages transferred that were full of zeros. + */ Stat64 zero_pages; + /* + * number of bytes sent through multifd channels. + */ Stat64 multifd_bytes; + /* + * number of pages transferred that were not full of zeros. + */ Stat64 normal_pages; + /* + * number of bytes sent during postcopy. + */ Stat64 postcopy_bytes; + /* + * number of postcopy page faults that we have handled during + * postocpy stage. + */ Stat64 postcopy_requests; + /* + * number of bytes sent during precopy stage. + */ Stat64 precopy_bytes; + /* + * total number of bytes transferred. + */ Stat64 transferred; } MigrationAtomicStats; =20 --=20 2.40.0 From nobody Thu May 16 02:50:23 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1683196495; cv=none; d=zohomail.com; s=zohoarc; b=DfoAxYdxYhY6IjfvNzjM+BZslEeVNLRKR5Yt6yhvZvZG6oPc9qA5KViH5VJq9jfiBNukbbKEUid+pOH3XxUUnbkyPY804UCLgRn0So7kd3GOdnDMhehFN/Loeh8lWHThQNqmK1SU0LTdSOIgjQhGwIibWrjWGbi2XZ6CcDltHIU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1683196495; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mdMxgAR31vfYmLUTDvi8jxeFI8ta5mNR2zgGQumKJW0=; b=m5iyfYmcc032AC7yQSg+CYf+95kDihObbuuTeTT2so3wIOaxTLahuE9cK5DP49Rkqe2+VZufSnnMwuRUF2y+ekytlNeyaMCfnc1eo9lE6xorKrKwL2ABst51HT+y/jH12mNoiREr/kDTAxSpGaUm9hojpkHye0h/MIQiWVAXZIc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 168319649506765.01053483920134; Thu, 4 May 2023 03:34:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puWHs-00042q-1o; Thu, 04 May 2023 06:34:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puWHq-000426-Es for qemu-devel@nongnu.org; Thu, 04 May 2023 06:34:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puWHj-0003Ej-P0 for qemu-devel@nongnu.org; Thu, 04 May 2023 06:34:10 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-549-TEfvqDoMNO-GNwpM_fXeRQ-1; Thu, 04 May 2023 06:34:02 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A15752A2AD47 for ; Thu, 4 May 2023 10:34:01 +0000 (UTC) Received: from secure.mitica (unknown [10.39.193.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB6411121339; Thu, 4 May 2023 10:34:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683196443; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mdMxgAR31vfYmLUTDvi8jxeFI8ta5mNR2zgGQumKJW0=; b=eSheAUPb9jtfpwc8Uaxnj0ap3n048UCQdiuBA/K7bBgmTGc/7jNEqK5VVCYVt4ZtunCWpR +c/ImbxP21q4N01OMM3xs86CtIjC0b9BcR9Uhh4Y18OxsBqlhhr98ohoP46PIRHOadF3HW xvtQiUnIcJgR0gXuBzejK6TBdUkIX+Y= X-MC-Unique: TEfvqDoMNO-GNwpM_fXeRQ-1 From: Juan Quintela To: qemu-devel@nongnu.org Cc: Juan Quintela , Leonardo Bras , Peter Xu Subject: [PATCH 2/2] migration: Put zero_pages in alphabetical order Date: Thu, 4 May 2023 12:33:57 +0200 Message-Id: <20230504103357.22130-3-quintela@redhat.com> In-Reply-To: <20230504103357.22130-1-quintela@redhat.com> References: <20230504103357.22130-1-quintela@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.161, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1683196497364100001 Content-Type: text/plain; charset="utf-8" I forgot to move it when I rename it from duplicated_pages. Signed-off-by: Juan Quintela Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: David Edmondson Reviewed-by: Peter Xu --- migration/migration-stats.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/migration/migration-stats.h b/migration/migration-stats.h index 0e49c236fa..b87ba30ea8 100644 --- a/migration/migration-stats.h +++ b/migration/migration-stats.h @@ -48,10 +48,6 @@ typedef struct { * guest is stopped. */ Stat64 downtime_bytes; - /* - * number of pages transferred that were full of zeros. - */ - Stat64 zero_pages; /* * number of bytes sent through multifd channels. */ @@ -77,6 +73,10 @@ typedef struct { * total number of bytes transferred. */ Stat64 transferred; + /* + * number of pages transferred that were full of zeros. + */ + Stat64 zero_pages; } MigrationAtomicStats; =20 extern MigrationAtomicStats mig_stats; --=20 2.40.0