From nobody Mon May 20 01:44:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1682975216; cv=none; d=zohomail.com; s=zohoarc; b=Wflg3bRYLWx/68CzLvF+JxQvnWYVdy+faRdmHfNKTg9J43CZOQrzOEkvdxPRbcumlyQXaZLrwN+g/XJ4eF3j5m0WV6AzwVF88IuRWCbwv2Y1v35xujA9lHJFki+agZ7gdmjEXVAgZ97j+imQsR/fuRT7VHRN3TazCAt9e9sEwGo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682975216; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=6Evq+MD3JUEiKzUlp7urbHg+OD3xjvH8WPXX9LOTAPg=; b=oKdw2CkyNVsiXQlVXkZJ2QKFu3W1elcfjS3MIFQm3CMeslLBXb/tPJMGJ2MDg5MO0Q1DF8hBNrF26JJIyNxO7z/BVUCtG3zIDbp0u3uNVaOHWmeHvvSm/ZvUwB96VSgqA5yMcWWegjjWxqfQAPxGKWJYPnIN2SjmI4oVR0hv4Zk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682975216309772.9682634366529; Mon, 1 May 2023 14:06:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptaih-00069u-CU; Mon, 01 May 2023 17:06:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptaif-00068m-OQ for qemu-devel@nongnu.org; Mon, 01 May 2023 17:06:01 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptaid-0006Rl-Kf for qemu-devel@nongnu.org; Mon, 01 May 2023 17:06:01 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f315712406so144242865e9.0 for ; Mon, 01 May 2023 14:05:58 -0700 (PDT) Received: from stoup.Home ([2a02:c7c:74db:8d00:eca5:8bcb:58d9:c940]) by smtp.gmail.com with ESMTPSA id t10-20020a05600001ca00b002fab755e10bsm28977061wrx.68.2023.05.01.14.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 14:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1682975156; x=1685567156; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6Evq+MD3JUEiKzUlp7urbHg+OD3xjvH8WPXX9LOTAPg=; b=xcbxO5xAGIEMkddhUGEnkr7RqiUHzyrii/EOyerByRtxn3u7dEqClwMoPxGEZQzWKG xaNXme3XMBCq8PY3Dmaw0EXoZkeZoOg3S/5pjBc86m2EAeESqrC0zx9tXHW9XOfcNFmz yYR3qaorGD4u/F0krIOYEujRgpt/1KGMQXS1Olr1z3R3YpYVyp6BZle1bGQAH4YCucpD 2/PgHS7YxbUcZAdXzJtaWcpGDWSxY3P2YdttpGasXftgy4hiz5ZmxIid7w7S398aDP/s Kc9AQ7IHcMxyO33yCNOMexG+t3T0GjcCFCtJ6F0M/r6ISIFDLScCQ7GErM7eqQsgaFXz NivQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682975156; x=1685567156; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6Evq+MD3JUEiKzUlp7urbHg+OD3xjvH8WPXX9LOTAPg=; b=fkX1t2axgz0q8/XFRhpdeS8Ia1T/sbPVkxpnBbz0gWF179nlOVhpbRihlH8AAtt2Y2 az5ooVDJIdhBJ6cOuOz1vVaP4435XLBTWD+HrB/aGtR154KAZSgcxf+RHUGWasCtn+qt 7g4wE4KCBFZ2AjGVw1UGoJLnmDUjNtvhl0wPJbRKjDuED6GDLaUeJPD0dE0C1qG0OtOr sSxDMedU3UrJf02BH8xHt6QMux3vlsFgcU5fyytYxgk8es5N8qsAMoM+mkKhsIOISxHC +m42w1PdeGkxXz+7uVVxEsbR8Yn7k8rIQbR8P4ZNR8mBmUCffTGzNNMwnenszeE11Ubm Rd8Q== X-Gm-Message-State: AC+VfDwFzEOfaVZgM0IzG7bXRNCmQaADJ1OKmEXXSjWO4H4Ea9KPcmC2 ffIuU9wU08cc7rdEC88nz/MOtuqV6lNFSjUjDbjF/g== X-Google-Smtp-Source: ACHHUZ5BgqfB4ina9gBqkfAcZSqrwjvoHMAMNdpPAIQxiXZbfBkYUd27WZcsiXQIQFuWmZz2eI1jyQ== X-Received: by 2002:adf:f40a:0:b0:2f5:9146:7024 with SMTP id g10-20020adff40a000000b002f591467024mr12403792wro.22.1682975156608; Mon, 01 May 2023 14:05:56 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: quintela@redhat.com, peterx@redhat.com, leobras@redhat.com, pbonzini@redhat.com Subject: [PATCH] migration/xbzrle: Use __attribute__((target)) for avx512 Date: Mon, 1 May 2023 22:05:55 +0100 Message-Id: <20230501210555.289806-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=richard.henderson@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1682975218028100003 Content-Type: text/plain; charset="utf-8" Use the attribute, which is supported by clang, instead of the #pragma, which is not supported and, for some reason, also not detected by the meson probe, so we fail by -Werror. Signed-off-by: Richard Henderson Reviewed-by: Juan Quintela --- migration/xbzrle.c | 9 ++++----- meson.build | 5 +---- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/migration/xbzrle.c b/migration/xbzrle.c index c6f8b20917..258e4959c9 100644 --- a/migration/xbzrle.c +++ b/migration/xbzrle.c @@ -177,11 +177,11 @@ int xbzrle_decode_buffer(uint8_t *src, int slen, uint= 8_t *dst, int dlen) } =20 #if defined(CONFIG_AVX512BW_OPT) -#pragma GCC push_options -#pragma GCC target("avx512bw") #include -int xbzrle_encode_buffer_avx512(uint8_t *old_buf, uint8_t *new_buf, int sl= en, - uint8_t *dst, int dlen) + +int __attribute__((target("avx512bw"))) +xbzrle_encode_buffer_avx512(uint8_t *old_buf, uint8_t *new_buf, int slen, + uint8_t *dst, int dlen) { uint32_t zrun_len =3D 0, nzrun_len =3D 0; int d =3D 0, i =3D 0, num =3D 0; @@ -296,5 +296,4 @@ int xbzrle_encode_buffer_avx512(uint8_t *old_buf, uint8= _t *new_buf, int slen, } return d; } -#pragma GCC pop_options #endif diff --git a/meson.build b/meson.build index f71653d0c8..4bbdbcef37 100644 --- a/meson.build +++ b/meson.build @@ -2386,12 +2386,9 @@ config_host_data.set('CONFIG_AVX512F_OPT', get_optio= n('avx512f') \ config_host_data.set('CONFIG_AVX512BW_OPT', get_option('avx512bw') \ .require(have_cpuid_h, error_message: 'cpuid.h not available, cannot ena= ble AVX512BW') \ .require(cc.links(''' - #pragma GCC push_options - #pragma GCC target("avx512bw") #include #include - static int bar(void *a) { - + static int __attribute__((target("avx512bw"))) bar(void *a) { __m512i *x =3D a; __m512i res=3D _mm512_abs_epi8(*x); return res[1]; --=20 2.34.1