Hi all!

v2: simply ignore romfile on incoming migration when romsize is
specified.

Here I suggest a way to solve a problem, when we have existing
running QEMU with old option ROM of small size and want to migrate to
new environment where we don't have this ROM file.

All the details are in patch 03; 01-02 are simple code style
improvements.

Vladimir Sementsov-Ogievskiy (3):
  pci: pci_add_option_rom(): improve style
  pci: pci_add_option_rom(): refactor: use g_autofree for path variable
  pci: ROM preallocation for incoming migration

 hw/pci/pci.c | 101 ++++++++++++++++++++++++++++-----------------------
 1 file changed, 55 insertions(+), 46 deletions(-)

-- 
2.34.1

On 25.04.23 19:14, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
> 
> v2: simply ignore romfile on incoming migration when romsize is
> specified.
> 
> Here I suggest a way to solve a problem, when we have existing
> running QEMU with old option ROM of small size and want to migrate to
> new environment where we don't have this ROM file.
> 
> All the details are in patch 03; 01-02 are simple code style
> improvements.
> 
> Vladimir Sementsov-Ogievskiy (3):
>    pci: pci_add_option_rom(): improve style
>    pci: pci_add_option_rom(): refactor: use g_autofree for path variable
>    pci: ROM preallocation for incoming migration
> 
>   hw/pci/pci.c | 101 ++++++++++++++++++++++++++++-----------------------
>   1 file changed, 55 insertions(+), 46 deletions(-)
> 

While being here, could I ask a question:

As I understand, netcard ROM file is needed only for network boot. So, it's absolutely correct to use romfile="" option: network boot will not work, but everything else will work correctly. Is that right?

-- 
Best regards,
Vladimir

  Hi,

> As I understand, netcard ROM file is needed only for network boot. So,
> it's absolutely correct to use romfile="" option: network boot will
> not work, but everything else will work correctly. Is that right?

In most cases yes.

The exception to the rule is virtio-net with UEFI firmware.  OVMF and
ArmVirt images ship with a virtio-net driver included, so network
booting works without a nic rom.

take care,
  Gerd

On Tue, Apr 25, 2023 at 07:37:43PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 25.04.23 19:14, Vladimir Sementsov-Ogievskiy wrote:
> > Hi all!
> > 
> > v2: simply ignore romfile on incoming migration when romsize is
> > specified.
> > 
> > Here I suggest a way to solve a problem, when we have existing
> > running QEMU with old option ROM of small size and want to migrate to
> > new environment where we don't have this ROM file.
> > 
> > All the details are in patch 03; 01-02 are simple code style
> > improvements.
> > 
> > Vladimir Sementsov-Ogievskiy (3):
> >    pci: pci_add_option_rom(): improve style
> >    pci: pci_add_option_rom(): refactor: use g_autofree for path variable
> >    pci: ROM preallocation for incoming migration
> > 
> >   hw/pci/pci.c | 101 ++++++++++++++++++++++++++++-----------------------
> >   1 file changed, 55 insertions(+), 46 deletions(-)
> > 
> 
> While being here, could I ask a question:
> 
> As I understand, netcard ROM file is needed only for network boot. So, it's absolutely correct to use romfile="" option: network boot will not work, but everything else will work correctly. Is that right?
> 
> -- 
> Best regards,
> Vladimir

That is correct.

-- 
MST