linux-user/main: Use list_cpus() instead of cpu_list()

[PATCH] linux-user/main: Use list_cpus() instead of cpu_list()

Posted by Thomas Huth 1 year ago

This way we can get rid of the if'deffery and the XXX comment
here (it's repeated in the list_cpus() function anyway).

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 linux-user/main.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/linux-user/main.c b/linux-user/main.c
index fe03293516..aece4d9e91 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -359,10 +359,7 @@ static void handle_arg_cpu(const char *arg)
 {
     cpu_model = strdup(arg);
     if (cpu_model == NULL || is_help_option(cpu_model)) {
-        /* XXX: implement xxx_cpu_list for targets that still miss it */
-#if defined(cpu_list)
-        cpu_list();
-#endif
+        list_cpus();
         exit(EXIT_FAILURE);
     }
 }
-- 
2.31.1

Re: [PATCH] linux-user/main: Use list_cpus() instead of cpu_list()

Posted by Laurent Vivier 1 year ago

Le 24/04/2023 à 14:21, Thomas Huth a écrit :
> This way we can get rid of the if'deffery and the XXX comment
> here (it's repeated in the list_cpus() function anyway).
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   linux-user/main.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/linux-user/main.c b/linux-user/main.c
> index fe03293516..aece4d9e91 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -359,10 +359,7 @@ static void handle_arg_cpu(const char *arg)
>   {
>       cpu_model = strdup(arg);
>       if (cpu_model == NULL || is_help_option(cpu_model)) {
> -        /* XXX: implement xxx_cpu_list for targets that still miss it */
> -#if defined(cpu_list)
> -        cpu_list();
> -#endif
> +        list_cpus();
>           exit(EXIT_FAILURE);
>       }
>   }

Applied to my linux-user-for-8.1 branch.

Thanks,
Laurent

Re: [PATCH] linux-user/main: Use list_cpus() instead of cpu_list()

Posted by Philippe Mathieu-Daudé 1 year ago

On 24/4/23 14:21, Thomas Huth wrote:
> This way we can get rid of the if'deffery and the XXX comment
> here (it's repeated in the list_cpus() function anyway).
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   linux-user/main.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] linux-user/main: Use list_cpus() instead of cpu_list()

Posted by Richard Henderson 1 year ago

On 4/24/23 13:21, Thomas Huth wrote:
> This way we can get rid of the if'deffery and the XXX comment
> here (it's repeated in the list_cpus() function anyway).
> 
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
>   linux-user/main.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~