From nobody Fri May 10 19:53:28 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1682080953; cv=none; d=zohomail.com; s=zohoarc; b=BcblXvrMTDYCxbdZIUYRG+hmt/+emGPB7PJ/5OrsR6f+KggFKfc0/bShJmRTbS+IY6Z1dcYFQF7QQquOGr3gnMJVd6IlpoXuvwfwG+Hs1fJr1kr7HqwcgaHhthxh6vqRUMm5urBXhy4UMq4vTmUSpt7ZCUcJbMxfV+DZZB0cz0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682080953; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iIh6lg3o4ewCwpoHfAI4uvVSuXfipoNFobWfD5eznNM=; b=l2kx0orIYNtbsmMWyagsgjPxtZvQHqUg0jI20O+cFTK8BVkyYw7bLrBMhvcxn4AHQeBOpXfeOLRcUPMP3IS7MuOFqsnTAccuu9a1cbxeTIO5N6Qr792A6QBNR5MuY8LSzApll/xaNZDqFDe1vQ3V0hXXj8C+kQAzsEo7IOLwNvE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682080953872594.9441800103898; Fri, 21 Apr 2023 05:42:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppq5G-0005DF-7k; Fri, 21 Apr 2023 08:41:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppq5E-0005D1-Ey for qemu-devel@nongnu.org; Fri, 21 Apr 2023 08:41:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppq5C-0003pY-Sr for qemu-devel@nongnu.org; Fri, 21 Apr 2023 08:41:48 -0400 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-441-gt2MR2VJPEORtP4sk_ZGPQ-1; Fri, 21 Apr 2023 08:41:44 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3A8F11C08DA4; Fri, 21 Apr 2023 12:41:44 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id E02825AB7A; Fri, 21 Apr 2023 12:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682080906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iIh6lg3o4ewCwpoHfAI4uvVSuXfipoNFobWfD5eznNM=; b=BwevQmWgAlsZz4Sn6QyVgx4F9APMylYiQx5hTIRgj0nCkU8Ha4YIB5ujNp3BSbrKg173nW TFMHtNyu2cFI5SKDoK0VYdNVLX7mUo+OL3aLxP4mA55oTvLso2Z3yGwgCU1z9FKfTHONBd gXXOXhl8BGaW+sBDk29vyWkulXu6Qew= X-MC-Unique: gt2MR2VJPEORtP4sk_ZGPQ-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Thomas Huth , Beraldo Leal , Eduardo Lima , Wainer dos Santos Moschetta , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 1/2] hw/pci-bridge: fix cast for pxb-cxl dev realization Date: Fri, 21 Apr 2023 08:41:41 -0400 Message-Id: <20230421124142.2640825-2-berrange@redhat.com> In-Reply-To: <20230421124142.2640825-1-berrange@redhat.com> References: <20230421124142.2640825-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1682080955078100002 Build QEMU --enable-qom-cast-debug and run a VM creating a pxb-cxl device: $ qemu-system-x86_64 -machine q35,cxl=3Don -device pxb-cxl,bus=3Dpcie.0 hw/pci-bridge/pci_expander_bridge.c:54:PXB_DEV: Object 0x555558313760 is n= ot an instance of type pxb This is seen when running 'tests/qtest/cxl-test' Signed-off-by: Daniel P. Berrang=C3=A9 --- hw/pci-bridge/pci_expander_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expand= er_bridge.c index ead33f0c05..a78327b5f2 100644 --- a/hw/pci-bridge/pci_expander_bridge.c +++ b/hw/pci-bridge/pci_expander_bridge.c @@ -311,7 +311,7 @@ static void pxb_cxl_dev_reset(DeviceState *dev) * The CXL specification allows for host bridges with no HDM decoders * if they only have a single root port. */ - if (!PXB_DEV(dev)->hdm_for_passthrough) { + if (!PXB_CXL_DEV(dev)->hdm_for_passthrough) { dsp_count =3D pcie_count_ds_ports(hb->bus); } /* Initial reset will have 0 dsp so wait until > 0 */ --=20 2.39.1 From nobody Fri May 10 19:53:28 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1682080954; cv=none; d=zohomail.com; s=zohoarc; b=Ovjo7C7DZ6iAgOXrz0tnFbhqav/7C6ZiNZiwGlxsIn+O2qEc7mCQLNRnbDLLEBzvPk1NQKF/qcXYMoQHdxHr/CSeFnBRdDUqmRlYvcbImoiAhhVZ6Sz7GmV4iAgC8BSUeeLRth1V53QoDw65r+QY/dbT3Vz4ZYw9CeG0I9tLMsE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1682080954; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UN9elrsGKR1g0fwNc6r4MG8ou1EcBD07lH4zkubvA2w=; b=Rl9o8CHzWv3bP8Y/6cezIYF63pDaywjhPMW4S04uNdDhHavqlVc7H68GEHbv1wm9mXHbwM26MF19ufwOaZGGE62VSkQ+tPVVJBLn9c6OZx1aUZZLAX9OQkdk6b7ZufZwYrAjEM30GCvuAsmqujOgSnqLDGhdneVX9BPGaCvg8oM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1682080954000380.0035927425281; Fri, 21 Apr 2023 05:42:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppq5J-0005Do-MB; Fri, 21 Apr 2023 08:41:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppq5G-0005DU-WA for qemu-devel@nongnu.org; Fri, 21 Apr 2023 08:41:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppq5E-0003pw-UV for qemu-devel@nongnu.org; Fri, 21 Apr 2023 08:41:50 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-345-BP-8KX14NHO5V0D-VJxO3Q-1; Fri, 21 Apr 2023 08:41:45 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8E6F9811E7B; Fri, 21 Apr 2023 12:41:44 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4490B5AB7A; Fri, 21 Apr 2023 12:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682080908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UN9elrsGKR1g0fwNc6r4MG8ou1EcBD07lH4zkubvA2w=; b=anY2a0qdGAVuS1O47Sx7YUEY4wxOLxDf/6KlYql46445uZg0JBtbbAW5m9ByE9utZ20nby DvHqlpSmDCphXXvFWZtkgcA4h6yh3UODiC9kMKKV/h//NZobjjeHoTNGlVrA7YxpvWDkUS RPJBcIVA5VwEbBHet3pCbsszUstasoQ= X-MC-Unique: BP-8KX14NHO5V0D-VJxO3Q-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Thomas Huth , Beraldo Leal , Eduardo Lima , Wainer dos Santos Moschetta , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 2/2] gitlab: run all jobs with QOM debugging enabled Date: Fri, 21 Apr 2023 08:41:42 -0400 Message-Id: <20230421124142.2640825-3-berrange@redhat.com> In-Reply-To: <20230421124142.2640825-1-berrange@redhat.com> References: <20230421124142.2640825-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1682080955779100007 The QMO cast debugging is designed to catch developer mistakes and as such should always be enabled during CI runs. Signed-off-by: Daniel P. Berrang=C3=A9 --- .gitlab-ci.d/buildtest-template.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.d/buildtest-template.yml b/.gitlab-ci.d/buildtest-t= emplate.yml index a6cfe9be97..9151dece6f 100644 --- a/.gitlab-ci.d/buildtest-template.yml +++ b/.gitlab-ci.d/buildtest-template.yml @@ -12,6 +12,7 @@ - mkdir build - cd build - ../configure --enable-werror --disable-docs --enable-fdt=3Dsystem + --enable-qom-cast-debug ${LD_JOBS:+--meson=3Dgit} ${TARGETS:+--target-list=3D"$TARGETS"} $CONFIGURE_ARGS || { cat config.log meson-logs/meson-log.txt && exit 1; } --=20 2.39.1