The following changes since commit 60ca584b8af0de525656f959991a440f8c191f12:

  Merge tag 'pull-for-8.0-220323-1' of https://gitlab.com/stsquad/qemu into staging (2023-03-22 17:58:12 +0000)

are available in the Git repository at:

  https://github.com/quic/qemu tags/pull-hex-20230419

for you to fetch changes up to 073de8caa8f9013b4dd8613df29d15d7c42aa8f4:

  Hexagon (target/hexagon) Additional instructions handled by idef-parser (2023-04-19 20:13:20 -0700)

----------------------------------------------------------------
Hexagon update

----------------------------------------------------------------
Marco Liebel (2):
      Use f-strings in python scripts
      Use black code style for python scripts

Matheus Tavares Bernardino (1):
      Hexagon (translate.c): avoid redundant PC updates on COF

Taylor Simpson (8):
      Hexagon (target/hexagon) Remove redundant/unused macros
      Hexagon (target/hexagon) Merge arguments to probe_pkt_scalar_hvx_stores
      Hexagon (target/hexagon) Add overrides for count trailing zeros/ones
      Hexagon (target/hexagon) Updates to USR should use get_result_gpr
      Hexagon (tests/tcg/hexagon) Move HVX test infra to header file
      Hexagon (target/hexagon) Remove unused slot variable in helpers
      Hexagon (target/hexagon) Add overrides for cache/sync/barrier instructions
      Hexagon (target/hexagon) Additional instructions handled by idef-parser

 target/hexagon/gen_tcg.h                    |  52 +-
 target/hexagon/genptr.h                     |  10 +-
 target/hexagon/helper.h                     |   4 +-
 target/hexagon/macros.h                     |  91 +---
 target/hexagon/op_helper.h                  |   2 +-
 target/hexagon/translate.h                  |   1 +
 tests/tcg/hexagon/hvx_misc.h                | 178 +++++++
 target/hexagon/genptr.c                     |  49 +-
 target/hexagon/idef-parser/parser-helpers.c |  21 +-
 target/hexagon/op_helper.c                  |   6 +-
 target/hexagon/translate.c                  |  31 +-
 tests/tcg/hexagon/fpstuff.c                 |  54 +++
 tests/tcg/hexagon/hvx_misc.c                | 160 +-----
 tests/tcg/hexagon/misc.c                    |  56 ++-
 target/hexagon/dectree.py                   | 396 ++++++++-------
 target/hexagon/gen_analyze_funcs.py         | 226 ++++-----
 target/hexagon/gen_helper_funcs.py          | 362 ++++++++------
 target/hexagon/gen_helper_protos.py         | 169 ++++---
 target/hexagon/gen_idef_parser_funcs.py     |  93 ++--
 target/hexagon/gen_op_attribs.py            |  12 +-
 target/hexagon/gen_op_regs.py               |  79 +--
 target/hexagon/gen_opcodes_def.py           |   8 +-
 target/hexagon/gen_printinsn.py             |  84 ++--
 target/hexagon/gen_shortcode.py             |  19 +-
 target/hexagon/gen_tcg_func_table.py        |  18 +-
 target/hexagon/gen_tcg_funcs.py             | 729 +++++++++++++++-------------
 target/hexagon/hex_common.py                | 181 ++++---
 target/hexagon/idef-parser/idef-parser.y    |   2 +-
 tests/tcg/hexagon/Makefile.target           |   1 +
 29 files changed, 1735 insertions(+), 1359 deletions(-)
 create mode 100644 tests/tcg/hexagon/hvx_misc.h

On 4/20/23 05:26, Taylor Simpson wrote:
> The following changes since commit 60ca584b8af0de525656f959991a440f8c191f12:
> 
>    Merge tag 'pull-for-8.0-220323-1' of https://gitlab.com/stsquad/qemu into staging (2023-03-22 17:58:12 +0000)
> 
> are available in the Git repository at:
> 
>    https://github.com/quic/qemu tags/pull-hex-20230419
> 
> for you to fetch changes up to 073de8caa8f9013b4dd8613df29d15d7c42aa8f4:
> 
>    Hexagon (target/hexagon) Additional instructions handled by idef-parser (2023-04-19 20:13:20 -0700)
> 
> ----------------------------------------------------------------
> Hexagon update
> 
> ----------------------------------------------------------------
> Marco Liebel (2):
>        Use f-strings in python scripts
>        Use black code style for python scripts
> 
> Matheus Tavares Bernardino (1):
>        Hexagon (translate.c): avoid redundant PC updates on COF
> 
> Taylor Simpson (8):
>        Hexagon (target/hexagon) Remove redundant/unused macros
>        Hexagon (target/hexagon) Merge arguments to probe_pkt_scalar_hvx_stores
>        Hexagon (target/hexagon) Add overrides for count trailing zeros/ones
>        Hexagon (target/hexagon) Updates to USR should use get_result_gpr
>        Hexagon (tests/tcg/hexagon) Move HVX test infra to header file
>        Hexagon (target/hexagon) Remove unused slot variable in helpers
>        Hexagon (target/hexagon) Add overrides for cache/sync/barrier instructions
>        Hexagon (target/hexagon) Additional instructions handled by idef-parser

Fails CI job clang-user:

target/hexagon/idef-generated-emitter.indented.c:32174:39: error: implicit conversion from 
'int64_t' (aka 'long') to 'int32_t' (aka 'int') changes value from 2147483648 to 
-2147483648 [-Werror,-Wconstant-conversion]

int32_t qemu_tmp_3 = ((int64_t) 1ULL) << ((int64_t) 31ULL);
         ~~~~~~~~~~   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~

https://gitlab.com/qemu-project/qemu/-/jobs/4153502279#L1140


r~

> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Friday, April 21, 2023 3:21 AM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: philmd@linaro.org; peter.maydell@linaro.org; Brian Cain
> <bcain@quicinc.com>; Matheus Bernardino (QUIC)
> <quic_mathbern@quicinc.com>; stefanha@redhat.com; ale@rev.ng;
> anjo@rev.ng; Marco Liebel (QUIC) <quic_mliebel@quicinc.com>
> Subject: Re: [PULL 00/11] Hexagon queue
> 
> On 4/20/23 05:26, Taylor Simpson wrote:
> > The following changes since commit
> 60ca584b8af0de525656f959991a440f8c191f12:
> >        
> Fails CI job clang-user:
> 
> target/hexagon/idef-generated-emitter.indented.c:32174:39: error: implicit
> conversion from 'int64_t' (aka 'long') to 'int32_t' (aka 'int') changes value from
> 2147483648 to
> -2147483648 [-Werror,-Wconstant-conversion]
> 
> int32_t qemu_tmp_3 = ((int64_t) 1ULL) << ((int64_t) 31ULL);
>          ~~~~~~~~~~   ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/4153502279#L1140

My apologies.

This is the patch causing the error
    Hexagon (target/hexagon) Additional instructions handled by idef-parser
I'll have to work with the rev.ng guys to get it fixed.

For now, I'll remove this patch and resubmit the pull request.

Thanks,
Taylor