[v2] COLO: improve build options

[PATCH v2 0/4] COLO: improve build options

Vladimir Sementsov-Ogievskiy posted 4 patches 1 year ago

Diff against v1 v3 v4 v5
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230419225232.508121-1-vsementsov@yandex-team.ru

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Hailiang Zhang <zhanghailiang@xfusion.com>, Juan Quintela <quintela@redhat.com>, Jason Wang <jasowang@redhat.com>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, Michael Roth <michael.roth@amd.com>

There is a newer version of this series

block/meson.build              |  2 +-
hmp-commands.hx                |  2 ++
meson.build                    |  1 +
meson_options.txt              |  2 ++
migration/colo.c               |  6 +++++
migration/meson.build          |  6 +++--
migration/migration-hmp-cmds.c |  2 ++
migration/migration.c          | 19 +++-----------
net/meson.build                | 16 +++++++++---
qapi/migration.json            | 12 ++++++---
scripts/meson-buildoptions.sh  |  3 +++
scripts/qapi/types.py          |  2 ++
stubs/colo.c                   | 47 ++++++++++++++++++++++++++++++++++
stubs/meson.build              |  1 +
14 files changed, 95 insertions(+), 26 deletions(-)
create mode 100644 stubs/colo.c

Expand all Fold all

[PATCH v2 0/4] COLO: improve build options

Posted by Vladimir Sementsov-Ogievskiy 1 year ago

Hi all!

COLO substem seems to be useless when CONFIG_REPLICATION is unset, as we
simply don't allow to set x-colo capability in this case. So, let's not
compile in unreachable code and interface we cannot use when
CONFIG_REPLICATION is unset.

Also, provide personal configure option for COLO Proxy subsystem.

v1 was 
[PATCH] replication: compile out some staff when replication is not configured
Supersedes: <20230411145112.497785-1-vsementsov@yandex-team.ru>

Vladimir Sementsov-Ogievskiy (4):
  block/meson.build: prefer positive condition for replication
  scripts/qapi: allow optional experimental enum values
  build: move COLO under CONFIG_REPLICATION
  configure: add --disable-colo-filters option

 block/meson.build              |  2 +-
 hmp-commands.hx                |  2 ++
 meson.build                    |  1 +
 meson_options.txt              |  2 ++
 migration/colo.c               |  6 +++++
 migration/meson.build          |  6 +++--
 migration/migration-hmp-cmds.c |  2 ++
 migration/migration.c          | 19 +++-----------
 net/meson.build                | 16 +++++++++---
 qapi/migration.json            | 12 ++++++---
 scripts/meson-buildoptions.sh  |  3 +++
 scripts/qapi/types.py          |  2 ++
 stubs/colo.c                   | 47 ++++++++++++++++++++++++++++++++++
 stubs/meson.build              |  1 +
 14 files changed, 95 insertions(+), 26 deletions(-)
 create mode 100644 stubs/colo.c

-- 
2.34.1

Re: [PATCH v2 0/4] COLO: improve build options

Posted by Lukas Straub 1 year ago

On Thu, 20 Apr 2023 01:52:28 +0300
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:

> Hi all!
> 
> COLO substem seems to be useless when CONFIG_REPLICATION is unset, as we
> simply don't allow to set x-colo capability in this case. So, let's not
> compile in unreachable code and interface we cannot use when
> CONFIG_REPLICATION is unset.
> 
> Also, provide personal configure option for COLO Proxy subsystem.
> 
> v1 was 
> [PATCH] replication: compile out some staff when replication is not configured
> Supersedes: <20230411145112.497785-1-vsementsov@yandex-team.ru>

Hey,
This series is a good idea, and looks fine to me. Maybe you can remove
the #ifdef CONFIG_REPLICATION/#ifndef CONFIG_REPLICATION from
migration/colo.c too while you are at it.

Regards,
Lukas Straub

> Vladimir Sementsov-Ogievskiy (4):
>   block/meson.build: prefer positive condition for replication
>   scripts/qapi: allow optional experimental enum values
>   build: move COLO under CONFIG_REPLICATION
>   configure: add --disable-colo-filters option
> 
>  block/meson.build              |  2 +-
>  hmp-commands.hx                |  2 ++
>  meson.build                    |  1 +
>  meson_options.txt              |  2 ++
>  migration/colo.c               |  6 +++++
>  migration/meson.build          |  6 +++--
>  migration/migration-hmp-cmds.c |  2 ++
>  migration/migration.c          | 19 +++-----------
>  net/meson.build                | 16 +++++++++---
>  qapi/migration.json            | 12 ++++++---
>  scripts/meson-buildoptions.sh  |  3 +++
>  scripts/qapi/types.py          |  2 ++
>  stubs/colo.c                   | 47 ++++++++++++++++++++++++++++++++++
>  stubs/meson.build              |  1 +
>  14 files changed, 95 insertions(+), 26 deletions(-)
>  create mode 100644 stubs/colo.c
> 



--

Re: [PATCH v2 0/4] COLO: improve build options

Posted by Vladimir Sementsov-Ogievskiy 1 year ago

On 20.04.23 11:33, Lukas Straub wrote:
> On Thu, 20 Apr 2023 01:52:28 +0300
> Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> wrote:
> 
>> Hi all!
>>
>> COLO substem seems to be useless when CONFIG_REPLICATION is unset, as we
>> simply don't allow to set x-colo capability in this case. So, let's not
>> compile in unreachable code and interface we cannot use when
>> CONFIG_REPLICATION is unset.
>>
>> Also, provide personal configure option for COLO Proxy subsystem.
>>
>> v1 was
>> [PATCH] replication: compile out some staff when replication is not configured
>> Supersedes: <20230411145112.497785-1-vsementsov@yandex-team.ru>
> 
> Hey,
> This series is a good idea, and looks fine to me. Maybe you can remove
> the #ifdef CONFIG_REPLICATION/#ifndef CONFIG_REPLICATION from
> migration/colo.c too while you are at it.
> 

Oh, right, will do in v3. Thanks!

-- 
Best regards,
Vladimir