hw/rdma: Compile target-independent parts of the rdma code only once

[PATCH] hw/rdma: Compile target-independent parts of the rdma code only once

Thomas Huth posted 1 patch 1 year ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20230419114937.667221-1-thuth@redhat.com

Maintainers: Yuval Shaia <yuval.shaia.ml@gmail.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>

hw/rdma/meson.build | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH] hw/rdma: Compile target-independent parts of the rdma code only once

Posted by Thomas Huth 1 year ago

Some files of the rdma code do not depend on any target specific
macros. Compile these only once to safe some time during the build.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/rdma/meson.build | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/hw/rdma/meson.build b/hw/rdma/meson.build
index 7325f40c32..fc7917192f 100644
--- a/hw/rdma/meson.build
+++ b/hw/rdma/meson.build
@@ -1,10 +1,12 @@
-specific_ss.add(when: 'CONFIG_VMW_PVRDMA', if_true: files(
+softmmu_ss.add(when: 'CONFIG_VMW_PVRDMA', if_true: files(
   'rdma.c',
   'rdma_backend.c',
-  'rdma_rm.c',
   'rdma_utils.c',
+  'vmw/pvrdma_qp_ops.c',
+))
+specific_ss.add(when: 'CONFIG_VMW_PVRDMA', if_true: files(
+  'rdma_rm.c',
   'vmw/pvrdma_cmd.c',
   'vmw/pvrdma_dev_ring.c',
   'vmw/pvrdma_main.c',
-  'vmw/pvrdma_qp_ops.c',
 ))
-- 
2.31.1

Re: [PATCH] hw/rdma: Compile target-independent parts of the rdma code only once

Posted by Philippe Mathieu-Daudé 1 year ago

On 19/4/23 13:49, Thomas Huth wrote:
> Some files of the rdma code do not depend on any target specific
> macros. Compile these only once to safe some time during the build.

s/safe/save/

> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   hw/rdma/meson.build | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>