hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI

[PATCH] hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI

Thomas Huth posted 1 patch 1 year ago

Download mbox

Failed in applying to current master (apply log)

Maintainers: Yuval Shaia <yuval.shaia.ml@gmail.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>

hw/rdma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI

Posted by Thomas Huth 1 year ago

The "pvrdma" device is only usable in conjunction with the "vmxnet3"
NIC - see the check for TYPE_VMXNET3 in pvrdma_realize().

By adding this dependency, the amount of total files that have to
be compiled for a configuration with all targets decreases by 64
files (!), since the rdma code is marked as target specific and thus
got recompiled for all targets that enable PCI so far.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/rdma/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/rdma/Kconfig b/hw/rdma/Kconfig
index 8e2211288f..840320bdc0 100644
--- a/hw/rdma/Kconfig
+++ b/hw/rdma/Kconfig
@@ -1,3 +1,3 @@
 config VMW_PVRDMA
     default y if PCI_DEVICES
-    depends on PVRDMA && PCI && MSI_NONBROKEN
+    depends on PVRDMA && MSI_NONBROKEN && VMXNET3_PCI
-- 
2.31.1

Re: [PATCH] hw/rdma: VMW_PVRDMA should depend on VMXNET3_PCI

Posted by Philippe Mathieu-Daudé 1 year ago

On 19/4/23 13:13, Thomas Huth wrote:
> The "pvrdma" device is only usable in conjunction with the "vmxnet3"
> NIC - see the check for TYPE_VMXNET3 in pvrdma_realize().
> 
> By adding this dependency, the amount of total files that have to
> be compiled for a configuration with all targets decreases by 64
> files (!), since the rdma code is marked as target specific and thus
> got recompiled for all targets that enable PCI so far.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   hw/rdma/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>