From nobody Fri May 17 03:54:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1681331708; cv=none; d=zohomail.com; s=zohoarc; b=Y7pwDP/yoLBsrK9ZhXqEXulre4BS6noVGXW+FRGzueC4qqwpO0VVKiTsN7N1K81pnc5XhDr0mnHE5zGYyjfschE6hOxTIet3nSklExHIHWk3ydjy11hlw/nILLodwEY4E4j8s9ssrHHYpk94j3ZcODSEDdIrPoG9rZZyvplLUV4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681331708; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KBi57RubtRq0TtlG9oGfWf0snZrujl3dgxBWHg38KOI=; b=HvFTNs6/malb9CaKgaDTb8YklWxXXKnHqqIoHU88ai18/6koBjbby/yoMUTkWh3UP8L49Y9sm2IXVikOjuqw/nswj2X742PQhhMl34m61TkkCJe9TDM6OmmJlB26vYAkn8Vmm96O+rdObCA+UDpEJuqmo1m1Mz23f8M6HmZVSnM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681331708636649.7645350253496; Wed, 12 Apr 2023 13:35:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmhB2-0004gv-EC; Wed, 12 Apr 2023 16:34:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmhB0-0004gP-QO for qemu-devel@nongnu.org; Wed, 12 Apr 2023 16:34:46 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmhAy-0000RA-I4 for qemu-devel@nongnu.org; Wed, 12 Apr 2023 16:34:46 -0400 Received: by mail-ej1-x62d.google.com with SMTP id z9so5002929ejx.11 for ; Wed, 12 Apr 2023 13:34:44 -0700 (PDT) Received: from Provence.localdomain (dynamic-089-012-055-150.89.12.pool.telefonica.de. [89.12.55.150]) by smtp.gmail.com with ESMTPSA id o8-20020a170906358800b0094a6f908b8bsm4093562ejb.166.2023.04.12.13.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 13:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681331682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KBi57RubtRq0TtlG9oGfWf0snZrujl3dgxBWHg38KOI=; b=PycmZW/pTpReAEZ5DUfhBzqZAqT2mfBn/gI97FQVPGnYFfzkkVyhmk/CIYGkG8cnaM EtucgedJybI/J2b4zOQKRaf0xshH/Wv2i6gMkzJewTiFR0Ec1K751Tjm1xBTG75ImQDO cxPthamacuxLpLKI60bkTJdLlZUNDaVN3AVzfVHe0+auaAxWMUTzbmxyTPlrgkiFLHwE uT3+HNKkNwMbA6txRB8Graxc+TPq7zU3GAbzo4njNJQ/JV0sd2tyNsvJWKuFijp11tOw mJIfyylUkzLq3XybEuabURW0Wwcoz0cC/8FarF++RQn9MdcEbUzfekP29FoMPO1NiVcP yzxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681331682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KBi57RubtRq0TtlG9oGfWf0snZrujl3dgxBWHg38KOI=; b=i8RWKaJmGKYc0EIqH69UZZggC/SHNXRHOtESMpdmaF8APeZy4iqZToE6wONWqp9V6x RzEEd1CXYbt4jcs+XLtgtnlw4gHlrJAYDp9uqiLZ4D52qrfK7oxkFhHZl08ZX8qzvyaU 2tQtuvgxs6Zj3QwzFeWiGisEoMjikUbCOX5Kds9O1aDiXqYf+iPGDGFSOMxkDSrj+uUx sXvaArJnN+QYqkjIGApCrOrh7V1McXtM27/DsECgPgsXU93EgVeQ/3EfolCtayo5ztdb n3pyXleFM5qamXbVwEjRVbrkbuM8AIekGAiAOT0B61+2YuKWdw6Tsr2Vpuo1StdWYQiG oVYg== X-Gm-Message-State: AAQBX9cq+/UF2vhERf9lltaz7G/Z/njEBDX5346uhkUPBRMnh0WEGmky QZ/fFceIxlFAJltyJr2+KltWM4uTHRM= X-Google-Smtp-Source: AKy350bDxGlN9HNrh+GQ2dTSDnSyzVQBp4NsXnugKAO123rozI0paeioCNbe+L5oZhc3ildI5YPS/A== X-Received: by 2002:a17:906:81c1:b0:94c:2548:395 with SMTP id e1-20020a17090681c100b0094c25480395mr135819ejx.52.1681331682597; Wed, 12 Apr 2023 13:34:42 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Stefan Weil , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , Bernhard Beschow Subject: [PATCH 1/3] ui/sdl2: Grab Alt+Tab also in fullscreen mode Date: Wed, 12 Apr 2023 22:34:23 +0200 Message-Id: <20230412203425.32566-2-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230412203425.32566-1-shentey@gmail.com> References: <20230412203425.32566-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=shentey@gmail.com; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1681331709937100002 Content-Type: text/plain; charset="utf-8" By default, SDL grabs Alt+Tab only in non-fullscreen mode. This causes Alt+= Tab to switch tasks on the host rather than in the VM in fullscreen mode while = it switches tasks in non-fullscreen mode in the VM. Fix this confusing behavior by grabbing Alt+F4 in fullscreen mode, always causing tasks to be switched = in the VM. Signed-off-by: Bernhard Beschow --- ui/sdl2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index b12dec4caf..91705e4bce 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -856,6 +856,7 @@ static void sdl2_display_init(DisplayState *ds, Display= Options *o) SDL_SetHint(SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR, "0"); #endif SDL_SetHint(SDL_HINT_GRAB_KEYBOARD, "1"); + SDL_SetHint(SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED, "0"); memset(&info, 0, sizeof(info)); SDL_VERSION(&info.version); =20 --=20 2.40.0 From nobody Fri May 17 03:54:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1681331769; cv=none; d=zohomail.com; s=zohoarc; b=GPxxIReQnF0xF1H09pwF78B45evLGu6gNzw9lzbqrFXkMhsiHTldQ4cZ60C7SkSzXx6eYsAiQI6TVwcLx9WdMzwhAQJHdZKiI/E4PJFFEDU6hIw4aIppDuyyqBdG4iWYXDGAoCfAdCuxFk80UHdVHkJsnTf33POdb/EvYHJRlMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681331769; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=YSExnx5QC9RqN2HqXaE0eED1yYxvpJdGPWDYki2hz1Q=; b=hSFhJGAX9hmRZw+H9Lh2vDWCOcEdjb4aizPRHNLpo6VT9ZfEPJTEQ+/9R+/QZVo/IjAbpBGPutCbAI/rRulEPp5oRztgv+FKzSPy4xrvMQTvSbm4hohOAzVnlcc/X42xCRrk92yfRJxfubYJL9RWpFCbgDKqqOm6np2VEQD7/co= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681331769529765.4068713098445; Wed, 12 Apr 2023 13:36:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmhB3-0004hD-3v; Wed, 12 Apr 2023 16:34:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmhB1-0004gd-4W for qemu-devel@nongnu.org; Wed, 12 Apr 2023 16:34:47 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmhAz-0000RP-GD for qemu-devel@nongnu.org; Wed, 12 Apr 2023 16:34:46 -0400 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-94a342f15e4so240036266b.0 for ; Wed, 12 Apr 2023 13:34:45 -0700 (PDT) Received: from Provence.localdomain (dynamic-089-012-055-150.89.12.pool.telefonica.de. [89.12.55.150]) by smtp.gmail.com with ESMTPSA id o8-20020a170906358800b0094a6f908b8bsm4093562ejb.166.2023.04.12.13.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 13:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681331683; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YSExnx5QC9RqN2HqXaE0eED1yYxvpJdGPWDYki2hz1Q=; b=rRkepYbY3sOmcpIlUVtCmWdZqt/jshNZS+eplM0WfyvUTFIPhzobK5u/RyABcllQR+ wH4Jaagx/TXlWUdKsZODS5a2d9vHk6T3j9E3lVvHWRjVIj1YcR2f7CZIlkpIrioJqPb/ 5B1EWC2vzNNgbi7THldAzT6vY9BxQ5ASB3F5mIsJNJik+HG5P4/cmabpxf2LiieJAx5s 3Qn0ZL+j8mI0m2sZezmMEIycPF7PfFMhmAiLYtF4rLGo7UdtNW8W0QCvud8Jjq+r0C24 ZNWdYiA1ZtrLWqsupDxHWdBAMKEVuFsSflVY7dwt7X5KbHiEO5+Qs7rl3Cm8VhWFFGqm wUQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681331683; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YSExnx5QC9RqN2HqXaE0eED1yYxvpJdGPWDYki2hz1Q=; b=FXCNVt8qNkCU2GGWr+bagwIoi5UZi+6S5rabdZGP6r5PQYQLtA9/TKu+C6uko/ivyI BLEga5xz+Bgx2F+FCOGQabD4safIOKuFl3jd4UEavEIWY/PsA0Rsx83hx0ALfV22vTBL JRaXikWbR6Kj6rWS1Xq7vO/CHAifmCLQR7jINeo6FhbP5yIE38MU7gqWJBunp/JqQjjS 4EWUZeP1yFJaR81j/2KYBspqiFmzHJF0wTbbTYmjw5aE/wvCS8FZXlQenaHX2Hg23Bn4 6UodcE23cyQojVVXNAGh6h3nnsQm2EdSEKb9YkS9zQlJiPtuvArhYLCLr+DSaWh2lFyN VOIw== X-Gm-Message-State: AAQBX9fw5IYmWiCUTy/uXnbjy7yyAU/j1BxOTCbDkrPUze6ZFwA99WJQ 46B7TF4mZs5rvfVQDVgnHa/bi8Hag+8= X-Google-Smtp-Source: AKy350YxltZUyK5UvvKOrKl4WbZ4RYDM5akskR1tb8rrgPLxqB7gk6eaub19bjVOGyIbVYYWI6/5GQ== X-Received: by 2002:aa7:d891:0:b0:4fa:ee01:a0cb with SMTP id u17-20020aa7d891000000b004faee01a0cbmr18216940edq.32.1681331683701; Wed, 12 Apr 2023 13:34:43 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Stefan Weil , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , Bernhard Beschow Subject: [PATCH 2/3] ui/sdl2: Grab Alt+F4 also under Windows Date: Wed, 12 Apr 2023 22:34:24 +0200 Message-Id: <20230412203425.32566-3-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230412203425.32566-1-shentey@gmail.com> References: <20230412203425.32566-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=shentey@gmail.com; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1681331770299100001 Content-Type: text/plain; charset="utf-8" SDL doesn't grab Alt+F4 under Windows by default. Pressing Alt+F4 thus clos= es the VM immediately without confirmation, possibly leading to data loss. Fix this by always grabbing Alt+F4 on Windows hosts, too. Signed-off-by: Bernhard Beschow --- ui/sdl2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/sdl2.c b/ui/sdl2.c index 91705e4bce..0031f9bca2 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -857,6 +857,7 @@ static void sdl2_display_init(DisplayState *ds, Display= Options *o) #endif SDL_SetHint(SDL_HINT_GRAB_KEYBOARD, "1"); SDL_SetHint(SDL_HINT_ALLOW_ALT_TAB_WHILE_GRABBED, "0"); + SDL_SetHint(SDL_HINT_WINDOWS_NO_CLOSE_ON_ALT_F4, "1"); memset(&info, 0, sizeof(info)); SDL_VERSION(&info.version); =20 --=20 2.40.0 From nobody Fri May 17 03:54:32 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1681331707; cv=none; d=zohomail.com; s=zohoarc; b=S6lPgd/879TFCEoaj1g1/A9hVL7yZ4KuQSTH89J+cMdKYB3WTS/Xu7OtAB0NUV1IRx2VMslgQKZkbXO2YlltMu9d8D+I1vACMISTSuqN24xZc6Gk8RV93hs33gKWRDD3nrCallXiEyOEEAQT6tDJ0oQaRyOraYictQcSSpl1baw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681331707; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ol1QVpM6FT8I/EBtMG8vNh8lfip/GRVz6FxUW2l2o30=; b=f45N7UBpTKVWExRPPMDLla3AXIeDWnOMtDodqzcuxQHXLtB5u6kyYMxivByjkYX+VeB9hqak9pvBr+RJiUFT9Rz4pbRY9OiYRDWJBk4WJgqrSF3RvjlTttbbFwk55p6VnoSRO/+sJUTGd4YDHhMye/MWqKLAKaWusB7b0QEQ8vo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681331707428436.61085308565214; Wed, 12 Apr 2023 13:35:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmhB4-0004ic-Qp; Wed, 12 Apr 2023 16:34:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmhB2-0004gw-Of for qemu-devel@nongnu.org; Wed, 12 Apr 2023 16:34:48 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pmhB1-0000SK-8x for qemu-devel@nongnu.org; Wed, 12 Apr 2023 16:34:48 -0400 Received: by mail-ej1-x633.google.com with SMTP id z9so5003211ejx.11 for ; Wed, 12 Apr 2023 13:34:46 -0700 (PDT) Received: from Provence.localdomain (dynamic-089-012-055-150.89.12.pool.telefonica.de. [89.12.55.150]) by smtp.gmail.com with ESMTPSA id o8-20020a170906358800b0094a6f908b8bsm4093562ejb.166.2023.04.12.13.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 13:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681331685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ol1QVpM6FT8I/EBtMG8vNh8lfip/GRVz6FxUW2l2o30=; b=ExVDzMzFWFmEwhgXyF8EX9ewxHzciroLjuo10a4igdquUzeqrpOWbgq35gOeoEDV91 nQyOsdZOcgeh5Xh5/jNcdwTQe3z2arQmMSru0XvWk1+JUf+hNsDyyqVydXXcSrjoQ3r8 1Y/rM1hdNWJeGK+YhxhzrfaMfZLDaphOecYXdacHVC7MlspYGlNP7VrajuzAdItrbFFJ kPVORf4C6Q1swuz2TOQwXY2yArROUicpD69qFdlwi8g+B/hit+saPva3+GMcEk32AEK9 DahG77VRfy+KNnWdRTTc+PwdLaHFZ43AE0wALkEHO+FMnwv+bI0VhQYk1tX58Yb0WerG KQLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681331685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ol1QVpM6FT8I/EBtMG8vNh8lfip/GRVz6FxUW2l2o30=; b=YlEf+Y7gRYi74gSygpVACJBYhpuo8f2mNNkL2ibknF7mDJFx8Hj+HZ9E2zlzZJ8EdS LZnQh/cKYKUAB7lvlZpRY4ZZFmo9FMjbID+aCuNn+K5Z2g9oPZZb8JMX7LDfs8/T0K3S Ybqo+PCsDVVuORGKhL27YSPt5zS7UDG9j0SEmqjA0ByOoZazwuOc+QWv9lhDLED8sggc FW+B1odWRx0Xqu04VMyONcPD8AV2YHNJAOfLGzocbmb1dpK9uS+53j+UTBnpuFr4FjxP QAxcGRpmEOFQ/0Me1YpST7dch23Vgk3b568R+KC8Iir3Z5XRG+UeJNznjf8CAOXz1GnR b88w== X-Gm-Message-State: AAQBX9cB0CEbhHHqpvQH3NLmfmXs2L1jAWkx1CFzp8CUNiTcgCjJdtTX SIUCZnGTesYUvdQClbakX9NFJREID14= X-Google-Smtp-Source: AKy350Zqc5IOczKB8ZMWwuodTz1dl6tx0nhWSk1Vam5o7qqXtBOWM1J/I+Z5PAxe53Q2Vh+MloTnMQ== X-Received: by 2002:a17:906:ae42:b0:94c:8cd8:559d with SMTP id lf2-20020a170906ae4200b0094c8cd8559dmr141685ejb.70.1681331685389; Wed, 12 Apr 2023 13:34:45 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Stefan Weil , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann , Bernhard Beschow Subject: [PATCH 3/3] ui/sdl2-input: Fix AltGr modifier on Windows hosts Date: Wed, 12 Apr 2023 22:34:25 +0200 Message-Id: <20230412203425.32566-4-shentey@gmail.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230412203425.32566-1-shentey@gmail.com> References: <20230412203425.32566-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=shentey@gmail.com; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1681331709937100003 Content-Type: text/plain; charset="utf-8" Windows generates Ctrl + Alt_R for AltGr. By removing the Ctrl modifier Lin= ux guests see AltGr. This fixes e.g. the '~' key on german keyboards. Signed-off-by: Bernhard Beschow --- ui/sdl2-input.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c index f068382209..a6538b56d2 100644 --- a/ui/sdl2-input.c +++ b/ui/sdl2-input.c @@ -39,6 +39,19 @@ void sdl2_process_key(struct sdl2_console *scon, return; } qcode =3D qemu_input_map_usb_to_qcode[ev->keysym.scancode]; + +#ifdef CONFIG_WIN32 + if (qcode =3D=3D Q_KEY_CODE_ALT_R && + qkbd_state_modifier_get(scon->kbd, QKBD_MOD_CTRL)) { + /* + * Windows generates Ctrl + Alt_R for AltGr. By removing the Ctrl + * modifier (Linux) guests see AltGr. + */ + trace_sdl2_process_key(ev->keysym.scancode, Q_KEY_CODE_CTRL, "up"); + qkbd_state_key_event(scon->kbd, Q_KEY_CODE_CTRL, false); + } +#endif + trace_sdl2_process_key(ev->keysym.scancode, qcode, ev->type =3D=3D SDL_KEYDOWN ? "down" : "up"); qkbd_state_key_event(scon->kbd, qcode, ev->type =3D=3D SDL_KEYDOWN); --=20 2.40.0