From nobody Fri May 17 01:44:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1681309239; cv=none; d=zohomail.com; s=zohoarc; b=Z9yFuhkpXcFaYjMQTWFV+JM5cZIJznTEgMFdavYHW67lUT7NUgepK27mr9tMxr9gTjOpjt+NHx6XnYYwjBGKvSNxfvqz1s81arc30mHLp9AI0c7qBJCbq4FElfX4C+GwVvw3AT2LteONCIQ4NWfmCMtw0II2pH5mGbagO19sRvc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681309239; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=20xoR6SGneEelWb3r5aH55Sk7AbGjL5NQa4GizZfs2A=; b=kuDuVTWNe5OiR8hqBUFlLla/RRY7lkt8onUSH2ypYtGDH+3J3R74ft6VDQpcOjJa7Wj3AnAlKVdXqYQJtqCoNVkAZemmhgytxSzz55ySL454wlY3DpYOk7yrMdCyyPHQdYEzhL2qSslgxJb6sLWyvl64TeMuwBi4UQ3KIq3UoDg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681309239433368.0096594657588; Wed, 12 Apr 2023 07:20:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmbKU-0000hD-Sm; Wed, 12 Apr 2023 10:20:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmbKT-0000gv-SU for qemu-devel@nongnu.org; Wed, 12 Apr 2023 10:20:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmbKS-0006Sv-Dw for qemu-devel@nongnu.org; Wed, 12 Apr 2023 10:20:09 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-221-JqVSPl-nNdOcbZ4tKZ87jA-1; Wed, 12 Apr 2023 10:20:05 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E5616858F09 for ; Wed, 12 Apr 2023 14:20:04 +0000 (UTC) Received: from secure.mitica (unknown [10.39.192.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1519E1121320; Wed, 12 Apr 2023 14:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681309207; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=20xoR6SGneEelWb3r5aH55Sk7AbGjL5NQa4GizZfs2A=; b=W0bGDjaTTsoJ+P/6VgLBXOY32+Owb5LSy090xCk/yj7dgN2739b0W6Ph1rS218ZnupGyLk SMKprrmO+we4eDGMWLlNYvZNTV2dGCPz56PY/PRs5WZOKX4OhoqzPZ6KtgFfUb1ckGxj+F 7+4s3xJf2WrUPP05G/ev7f2DnzkdN4c= X-MC-Unique: JqVSPl-nNdOcbZ4tKZ87jA-1 From: Juan Quintela To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier , Juan Quintela , Thomas Huth Subject: [PATCH 1/2] tests/migration: Make precopy fast Date: Wed, 12 Apr 2023 16:20:00 +0200 Message-Id: <20230412142001.16501-2-quintela@redhat.com> In-Reply-To: <20230412142001.16501-1-quintela@redhat.com> References: <20230412142001.16501-1-quintela@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1681309241196100001 Content-Type: text/plain; charset="utf-8" Otherwise we do the 1st migration iteration at a too slow speed. Signed-off-by: Juan Quintela Tested-by: Thomas Huth --- tests/qtest/migration-test.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 3b615b0da9..7b05b0b7dd 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -1348,6 +1348,7 @@ static void test_precopy_common(MigrateCommon *args) migrate_qmp(from, args->connect_uri, "{}"); } =20 + migrate_ensure_converge(from); =20 if (args->result !=3D MIG_TEST_SUCCEED) { bool allow_active =3D args->result =3D=3D MIG_TEST_FAIL; @@ -1365,8 +1366,6 @@ static void test_precopy_common(MigrateCommon *args) wait_for_migration_pass(from); } =20 - migrate_ensure_converge(from); - /* We do this first, as it has a timeout to stop us * hanging forever if migration didn't converge */ wait_for_migration_complete(from); --=20 2.39.2 From nobody Fri May 17 01:44:10 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1681309254; cv=none; d=zohomail.com; s=zohoarc; b=In+ykhxtxh1lQeEa5f8o9pAPf8waEhSsO7bIcNlGZ4sOKniLNgw84bZ23ZOqToqhjPFA2V30HP4UpytBoYLsZM0KMGABt55aoy0D6QscZtX8xV6WHlzT0uQL9npEXtpMsToMttDw8EW/UoqnbmQK+G9O10X5Wo+tSrEdXpBE2oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1681309254; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zHd/Hc2Shq/LhFkYLXvRRxBndKDfCZnW2r2zw+r3qjo=; b=nViZXgQtCM1xDgKmGpXM0sjs91IBaJdEYjHbd05VFPFHFsKoG+TRItFgelXeD/NW0cRo4OPN0ZHOndkdkG7y6q3dtq+gNIKLVAD6lfx3o38voT2TQI9epItfz5IOKROfyb/L9/VLxB3/UZvYphi+2KhmlV08lPzT9fv9zI5LHVI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1681309254268181.25692116918424; Wed, 12 Apr 2023 07:20:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pmbKW-0000i0-Ep; Wed, 12 Apr 2023 10:20:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmbKV-0000hJ-5s for qemu-devel@nongnu.org; Wed, 12 Apr 2023 10:20:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pmbKT-0006TS-0V for qemu-devel@nongnu.org; Wed, 12 Apr 2023 10:20:10 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-532-U4sckj56NXaDw_1P7eHV9w-1; Wed, 12 Apr 2023 10:20:06 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1051A858F09 for ; Wed, 12 Apr 2023 14:20:06 +0000 (UTC) Received: from secure.mitica (unknown [10.39.192.175]) by smtp.corp.redhat.com (Postfix) with ESMTP id 33E8A1121320; Wed, 12 Apr 2023 14:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681309208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zHd/Hc2Shq/LhFkYLXvRRxBndKDfCZnW2r2zw+r3qjo=; b=Zr/+VW/CGSQMEBPhwTU9J+zThUChbyc7+SADSKZPAeFWOW7QTIEeKQK3soBCEqyC0cwhdK AoWx23PEoSftZYbV6wmYerl1mruk3buc1thF/ootXE/kBt7DfSHztyfosPqLISsjVR5+8o vYEyBActDtwt9/C7X7DArq24Ihsql5o= X-MC-Unique: U4sckj56NXaDw_1P7eHV9w-1 From: Juan Quintela To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier , Juan Quintela , Thomas Huth Subject: [PATCH 2/2] tests/migration: Only run auto_converge in slow mode Date: Wed, 12 Apr 2023 16:20:01 +0200 Message-Id: <20230412142001.16501-3-quintela@redhat.com> In-Reply-To: <20230412142001.16501-1-quintela@redhat.com> References: <20230412142001.16501-1-quintela@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1681309256041100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Juan Quintela Tested-by: Thomas Huth --- tests/qtest/migration-test.c | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 7b05b0b7dd..6317131b50 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -1795,6 +1795,21 @@ static void test_validate_uuid_dst_not_set(void) do_test_validate_uuid(&args, false); } =20 +/* + * The way auto_converge works, we need to do too many passes to + * run this test. Auto_converge logic is only run once every + * three iterations, so: + * + * - 3 iterations without auto_converge enabled + * - 3 iterations with pct =3D 5 + * - 3 iterations with pct =3D 30 + * - 3 iterations with pct =3D 55 + * - 3 iterations with pct =3D 80 + * - 3 iterations with pct =3D 95 (max(95, 80 + 25)) + * + * To make things even worse, we need to run the initial stage at + * 3MB/s so we enter autoconverge even when host is (over)loaded. + */ static void test_migrate_auto_converge(void) { g_autofree char *uri =3D g_strdup_printf("unix:%s/migsocket", tmpfs); @@ -2574,8 +2589,12 @@ int main(int argc, char **argv) test_validate_uuid_src_not_set); qtest_add_func("/migration/validate_uuid_dst_not_set", test_validate_uuid_dst_not_set); - - qtest_add_func("/migration/auto_converge", test_migrate_auto_converge); + /* + * See explanation why this test is slow on function definition + */ + if (g_test_slow()) { + qtest_add_func("/migration/auto_converge", test_migrate_auto_conve= rge); + } qtest_add_func("/migration/multifd/tcp/plain/none", test_multifd_tcp_none); /* --=20 2.39.2